| Message ID | 20240426-jag-sysctl_remset_net-v5-4-e3b12f6111a6@samsung.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v5,1/8] net: Remove the now superfluous sentinel elements from ctl_table array | expand |
On Fri, 2024-04-26 at 12:46 +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados <j.granados@samsung.com> > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > * Remove sentinel element from ctl_table structs. > > Signed-off-by: Joel Granados <j.granados@samsung.com> > --- > net/sunrpc/sysctl.c | 1 - > net/sunrpc/xprtrdma/svc_rdma.c | 1 - > net/sunrpc/xprtrdma/transport.c | 1 - > net/sunrpc/xprtsock.c | 1 - > 4 files changed, 4 deletions(-) > > diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c > index 93941ab12549..5f3170a1c9bb 100644 > --- a/net/sunrpc/sysctl.c > +++ b/net/sunrpc/sysctl.c > @@ -160,7 +160,6 @@ static struct ctl_table debug_table[] = { > .mode = 0444, > .proc_handler = proc_do_xprt, > }, > - { } > }; > > void > diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c > index f86970733eb0..474f7a98fe9e 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma.c > +++ b/net/sunrpc/xprtrdma/svc_rdma.c > @@ -209,7 +209,6 @@ static struct ctl_table svcrdma_parm_table[] = { > .extra1 = &zero, > .extra2 = &zero, > }, > - { }, > }; > > static void svc_rdma_proc_cleanup(void) > diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c > index 29b0562d62e7..9a8ce5df83ca 100644 > --- a/net/sunrpc/xprtrdma/transport.c > +++ b/net/sunrpc/xprtrdma/transport.c > @@ -137,7 +137,6 @@ static struct ctl_table xr_tunables_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec, > }, > - { }, > }; > > #endif > diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c > index bb9b747d58a1..f62f7b65455b 100644 > --- a/net/sunrpc/xprtsock.c > +++ b/net/sunrpc/xprtsock.c > @@ -160,7 +160,6 @@ static struct ctl_table xs_tunables_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec_jiffies, > }, > - { }, > }; > > /* > Reviewed-by: Jeffrey Layton <jlayton@kernel.org>
On Fri, Apr 26, 2024 at 12:46:56PM +0200, Joel Granados via B4 Relay wrote: > From: Joel Granados <j.granados@samsung.com> > > This commit comes at the tail end of a greater effort to remove the > empty elements at the end of the ctl_table arrays (sentinels) which > will reduce the overall build time size of the kernel and run time > memory bloat by ~64 bytes per sentinel (further information Link : > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/) > > * Remove sentinel element from ctl_table structs. > > Signed-off-by: Joel Granados <j.granados@samsung.com> > --- > net/sunrpc/sysctl.c | 1 - > net/sunrpc/xprtrdma/svc_rdma.c | 1 - > net/sunrpc/xprtrdma/transport.c | 1 - > net/sunrpc/xprtsock.c | 1 - > 4 files changed, 4 deletions(-) > > diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c > index 93941ab12549..5f3170a1c9bb 100644 > --- a/net/sunrpc/sysctl.c > +++ b/net/sunrpc/sysctl.c > @@ -160,7 +160,6 @@ static struct ctl_table debug_table[] = { > .mode = 0444, > .proc_handler = proc_do_xprt, > }, > - { } > }; > > void > diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c > index f86970733eb0..474f7a98fe9e 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma.c > +++ b/net/sunrpc/xprtrdma/svc_rdma.c > @@ -209,7 +209,6 @@ static struct ctl_table svcrdma_parm_table[] = { > .extra1 = &zero, > .extra2 = &zero, > }, > - { }, > }; > > static void svc_rdma_proc_cleanup(void) > diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c > index 29b0562d62e7..9a8ce5df83ca 100644 > --- a/net/sunrpc/xprtrdma/transport.c > +++ b/net/sunrpc/xprtrdma/transport.c > @@ -137,7 +137,6 @@ static struct ctl_table xr_tunables_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec, > }, > - { }, > }; > > #endif > diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c > index bb9b747d58a1..f62f7b65455b 100644 > --- a/net/sunrpc/xprtsock.c > +++ b/net/sunrpc/xprtsock.c > @@ -160,7 +160,6 @@ static struct ctl_table xs_tunables_table[] = { > .mode = 0644, > .proc_handler = proc_dointvec_jiffies, > }, > - { }, > }; > > /* > > -- > 2.43.0 > Acked-by: Chuck Lever <chuck.lever@oracle.com>
diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c index 93941ab12549..5f3170a1c9bb 100644 --- a/net/sunrpc/sysctl.c +++ b/net/sunrpc/sysctl.c @@ -160,7 +160,6 @@ static struct ctl_table debug_table[] = { .mode = 0444, .proc_handler = proc_do_xprt, }, - { } }; void diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c index f86970733eb0..474f7a98fe9e 100644 --- a/net/sunrpc/xprtrdma/svc_rdma.c +++ b/net/sunrpc/xprtrdma/svc_rdma.c @@ -209,7 +209,6 @@ static struct ctl_table svcrdma_parm_table[] = { .extra1 = &zero, .extra2 = &zero, }, - { }, }; static void svc_rdma_proc_cleanup(void) diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c index 29b0562d62e7..9a8ce5df83ca 100644 --- a/net/sunrpc/xprtrdma/transport.c +++ b/net/sunrpc/xprtrdma/transport.c @@ -137,7 +137,6 @@ static struct ctl_table xr_tunables_table[] = { .mode = 0644, .proc_handler = proc_dointvec, }, - { }, }; #endif diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index bb9b747d58a1..f62f7b65455b 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c @@ -160,7 +160,6 @@ static struct ctl_table xs_tunables_table[] = { .mode = 0644, .proc_handler = proc_dointvec_jiffies, }, - { }, }; /*