| Message ID | 20240425113746.335530-1-kernel@pankajraghav.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | enable bs > ps in XFS | expand |
"Pankaj Raghav (Samsung)" <kernel@pankajraghav.com> writes: > From: Pankaj Raghav <p.raghav@samsung.com> > > This is the fourth version of the series that enables block size > page size > (Large Block Size) in XFS. The context and motivation can be seen in cover > letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], > if someone would like more context on this effort. > > This series does not split a folio during truncation even though we have > an API to do so due to some issues with writeback. While it is not a > blocker, this feature can be added as a future improvement once we > get the base patches upstream (See patch 7). > > A lot of emphasis has been put on testing using kdevops. The testing has > been split into regression and progression. > > Regression testing: > In regression testing, we ran the whole test suite to check for > *regression on existing profiles due to the page cache changes. > > No regression was found with the patches added on top. > > Progression testing: > For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. > To compare it with existing support, an ARM VM with 64k base page system > (without our patches) was used as a reference to check for actual failures > due to LBS support in a 4k base page size system. > > There are some tests that assumes block size < page size that needs to > be fixed. I have a tree with fixes for xfstests here [6], which I will be > sending soon to the list. Already a part of this has been upstreamed to > fstest. > > No new failures were found with the LBS support. I just did portability testing by creating XFS with 16k bs on x86 VM (4k pagesize), created some files + checksums. I then moved the disk to Power VM with 64k pagesize and mounted this. I was able to mount and all the file checksums passed. Then I did the vice versa, created a filesystem on Power VM with 64k blocksize and created 10 files with random data of 10MB each. I then hotplugged this device out from Power and plugged it into x86 VM and mounted it. <Logs of the 2nd operation> ~# mount /dev/vdk /mnt1/ [ 35.145350] XFS (vdk): EXPERIMENTAL: Filesystem with Large Block Size (65536 bytes) enabled. [ 35.149858] XFS (vdk): Mounting V5 Filesystem 91933a8b-1370-4931-97d1-c21213f31f8f [ 35.227459] XFS (vdk): Ending clean mount [ 35.235090] xfs filesystem being mounted at /mnt1 supports timestamps until 2038-01-19 (0x7fffffff) ~# cd /mnt1/ ~# sha256sum -c checksums file-1.img: OK file-2.img: OK file-3.img: OK file-4.img: OK file-5.img: OK file-6.img: OK file-7.img: OK file-8.img: OK file-9.img: OK file-10.img: OK So thanks for this nice portability which this series offers :) -ritesh
On Sat, Apr 27, 2024 at 10:12:38AM +0530, Ritesh Harjani wrote: > "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com> writes: > > > From: Pankaj Raghav <p.raghav@samsung.com> > > > > This is the fourth version of the series that enables block size > page size > > (Large Block Size) in XFS. The context and motivation can be seen in cover > > letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], > > if someone would like more context on this effort. > > > > This series does not split a folio during truncation even though we have > > an API to do so due to some issues with writeback. While it is not a > > blocker, this feature can be added as a future improvement once we > > get the base patches upstream (See patch 7). > > > > A lot of emphasis has been put on testing using kdevops. The testing has > > been split into regression and progression. > > > > Regression testing: > > In regression testing, we ran the whole test suite to check for > > *regression on existing profiles due to the page cache changes. > > > > No regression was found with the patches added on top. > > > > Progression testing: > > For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. > > To compare it with existing support, an ARM VM with 64k base page system > > (without our patches) was used as a reference to check for actual failures > > due to LBS support in a 4k base page size system. > > > > There are some tests that assumes block size < page size that needs to > > be fixed. I have a tree with fixes for xfstests here [6], which I will be > > sending soon to the list. Already a part of this has been upstreamed to > > fstest. > > > > No new failures were found with the LBS support. > > I just did portability testing by creating XFS with 16k bs on x86 VM (4k > pagesize), created some files + checksums. I then moved the disk to > Power VM with 64k pagesize and mounted this. I was able to mount and > all the file checksums passed. > > Then I did the vice versa, created a filesystem on Power VM with 64k > blocksize and created 10 files with random data of 10MB each. I then > hotplugged this device out from Power and plugged it into x86 VM and > mounted it. > > <Logs of the 2nd operation> > ~# mount /dev/vdk /mnt1/ > [ 35.145350] XFS (vdk): EXPERIMENTAL: Filesystem with Large Block Size (65536 bytes) enabled. > [ 35.149858] XFS (vdk): Mounting V5 Filesystem 91933a8b-1370-4931-97d1-c21213f31f8f > [ 35.227459] XFS (vdk): Ending clean mount > [ 35.235090] xfs filesystem being mounted at /mnt1 supports timestamps until 2038-01-19 (0x7fffffff) > ~# cd /mnt1/ > ~# sha256sum -c checksums > file-1.img: OK > file-2.img: OK > file-3.img: OK > file-4.img: OK > file-5.img: OK > file-6.img: OK > file-7.img: OK > file-8.img: OK > file-9.img: OK > file-10.img: OK > > So thanks for this nice portability which this series offers :) Yessss this is awesome to see this coming together after many years! --D > -ritesh > >
On Sat, Apr 27, 2024 at 10:12:38AM +0530, Ritesh Harjani wrote: > "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com> writes: > > > From: Pankaj Raghav <p.raghav@samsung.com> > > > > This is the fourth version of the series that enables block size > page size > > (Large Block Size) in XFS. The context and motivation can be seen in cover > > letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], > > if someone would like more context on this effort. > > > > This series does not split a folio during truncation even though we have > > an API to do so due to some issues with writeback. While it is not a > > blocker, this feature can be added as a future improvement once we > > get the base patches upstream (See patch 7). > > > > A lot of emphasis has been put on testing using kdevops. The testing has > > been split into regression and progression. > > > > Regression testing: > > In regression testing, we ran the whole test suite to check for > > *regression on existing profiles due to the page cache changes. > > > > No regression was found with the patches added on top. > > > > Progression testing: > > For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. > > To compare it with existing support, an ARM VM with 64k base page system > > (without our patches) was used as a reference to check for actual failures > > due to LBS support in a 4k base page size system. > > > > There are some tests that assumes block size < page size that needs to > > be fixed. I have a tree with fixes for xfstests here [6], which I will be > > sending soon to the list. Already a part of this has been upstreamed to > > fstest. > > > > No new failures were found with the LBS support. > > I just did portability testing by creating XFS with 16k bs on x86 VM (4k > pagesize), created some files + checksums. I then moved the disk to > Power VM with 64k pagesize and mounted this. I was able to mount and > all the file checksums passed. > > Then I did the vice versa, created a filesystem on Power VM with 64k > blocksize and created 10 files with random data of 10MB each. I then > hotplugged this device out from Power and plugged it into x86 VM and > mounted it. > > <Logs of the 2nd operation> > ~# mount /dev/vdk /mnt1/ > [ 35.145350] XFS (vdk): EXPERIMENTAL: Filesystem with Large Block Size (65536 bytes) enabled. > [ 35.149858] XFS (vdk): Mounting V5 Filesystem 91933a8b-1370-4931-97d1-c21213f31f8f > [ 35.227459] XFS (vdk): Ending clean mount > [ 35.235090] xfs filesystem being mounted at /mnt1 supports timestamps until 2038-01-19 (0x7fffffff) > ~# cd /mnt1/ > ~# sha256sum -c checksums > file-1.img: OK > file-2.img: OK > file-3.img: OK > file-4.img: OK > file-5.img: OK > file-6.img: OK > file-7.img: OK > file-8.img: OK > file-9.img: OK > file-10.img: OK > > So thanks for this nice portability which this series offers :) That is indeed nice. Thanks a lot for testing this Ritesh. :) > > -ritesh >
From: Pankaj Raghav <p.raghav@samsung.com> This is the fourth version of the series that enables block size > page size (Large Block Size) in XFS. The context and motivation can be seen in cover letter of the RFC v1[1]. We also recorded a talk about this effort at LPC [3], if someone would like more context on this effort. This series does not split a folio during truncation even though we have an API to do so due to some issues with writeback. While it is not a blocker, this feature can be added as a future improvement once we get the base patches upstream (See patch 7). A lot of emphasis has been put on testing using kdevops. The testing has been split into regression and progression. Regression testing: In regression testing, we ran the whole test suite to check for *regression on existing profiles due to the page cache changes. No regression was found with the patches added on top. Progression testing: For progression testing, we tested for 8k, 16k, 32k and 64k block sizes. To compare it with existing support, an ARM VM with 64k base page system (without our patches) was used as a reference to check for actual failures due to LBS support in a 4k base page size system. There are some tests that assumes block size < page size that needs to be fixed. I have a tree with fixes for xfstests here [6], which I will be sending soon to the list. Already a part of this has been upstreamed to fstest. No new failures were found with the LBS support. We've done some preliminary performance tests with fio on XFS on 4k block size against pmem and NVMe with buffered IO and Direct IO on vanilla Vs + these patches applied, and detected no regressions. We also wrote an eBPF tool called blkalgn [7] to see if IO sent to the device is aligned and at least filesystem block size in length. Git tree: https://github.com/linux-kdevops/linux/tree/large-block-minorder-6.9-rc4 [1] https://lore.kernel.org/lkml/20230915183848.1018717-1-kernel@pankajraghav.com/ [2] https://lore.kernel.org/linux-xfs/20240213093713.1753368-1-kernel@pankajraghav.com/ [3] https://www.youtube.com/watch?v=ar72r5Xf7x4 [4] https://github.com/linux-kdevops/kdevops/blob/master/docs/xfs-bugs.md 489 non-critical issues and 55 critical issues. We've determined and reported that the 55 critical issues have all fall into 5 common XFS asserts or hung tasks and 2 memory management asserts. [5] https://lore.kernel.org/linux-xfs/fe7fec1c-3b08-430f-9c95-ea76b237acf4@samsung.com/ [6] https://github.com/linux-kdevops/fstests/tree/lbs-fixes [7] https://github.com/iovisor/bcc/pull/4813 Changes since v3: - Cap the PTE range to i_size for LBS configuration in folio_map_range() - Added Chinners kvmalloc xattr patches - Moved Hannes patches before adding the minorder patches to avoid confusion. - Added mapping_set_folio_order_range(). - Return EINVAL instead EAGAIN in split_huge_page_to_list_to_order() Changes since v2: - Simplified the filemap and readahead changes. (Thanks willy) - Removed DEFINE_READAHEAD_ALIGN. - Added minorder support to readahead_expand(). Changes since v1: - Round up to nearest min nr pages in ra_init - Calculate index in filemap_create instead of doing in filemap_get_pages - Remove unnecessary BUG_ONs in the delete path - Use check_shl_overflow instead of check_mul_overflow - Cast to uint32_t instead of unsigned long in xfs_stat_blksize Changes since RFC v2: - Move order 1 patch above the 1st patch - Remove order == 1 conditional in `fs: Allow fine-grained control of folio sizes`. This fixed generic/630 that was reported in the previous version. - Hide the max order and expose `mapping_set_folio_min_order` instead. - Add new helper mapping_start_index_align and DEFINE_READAHEAD_ALIGN - don't call `page_cache_ra_order` with min order in do_mmap_sync_readahead - simplify ondemand readahead with only aligning the start index at the end - Don't cap ra_pages based on bdi->io_pages - use `checked_mul_overflow` while calculating bytes in validate_fsb - Remove config lbs option - Add a warning while mounting a LBS kernel - Add Acked-by and Reviewed-by from Hannes and Darrick. Changes since RFC v1: - Added willy's patch to enable order-1 folios. - Unified common page cache effort from Hannes LBS work. - Added a new helper min_nrpages and added CONFIG_THP for enabling mapping_large_folio_support - Don't split a folio if it has minorder set. Remove the old code where we set extra pins if it has that requirement. - Split the code in XFS between the validation of mapping count. Put the icache code changes with enabling bs > ps. - Added CONFIG_XFS_LBS option - align the index in do_read_cache_folio() - Removed truncate changes - Fixed generic/091 with iomap changes to iomap_dio_zero function. - Took care of folio truncation scenario in page_cache_ra_unbounded() that happens after read_pages if a folio was found. - Sqaushed and moved commits around - Rebased on top of v6.8-rc4 Dave Chinner (1): xfs: use kvmalloc for xattr buffers Hannes Reinecke (1): readahead: rework loop in page_cache_ra_unbounded() Luis Chamberlain (1): filemap: allocate mapping_min_order folios in the page cache Matthew Wilcox (Oracle) (1): fs: Allow fine-grained control of folio sizes Pankaj Raghav (7): readahead: allocate folios with mapping_min_order in readahead mm: do not split a folio if it has minimum folio order requirement filemap: cap PTE range to be created to i_size in folio_map_range() iomap: fix iomap_dio_zero() for fs bs > system page size xfs: expose block size in stat xfs: make the calculation generic in xfs_sb_validate_fsb_count() xfs: enable block size larger than page size support fs/iomap/direct-io.c | 13 +++- fs/xfs/libxfs/xfs_attr_leaf.c | 15 ++--- fs/xfs/libxfs/xfs_ialloc.c | 5 ++ fs/xfs/libxfs/xfs_shared.h | 3 + fs/xfs/xfs_icache.c | 6 +- fs/xfs/xfs_iops.c | 2 +- fs/xfs/xfs_mount.c | 10 ++- fs/xfs/xfs_super.c | 10 +-- include/linux/pagemap.h | 116 ++++++++++++++++++++++++++++------ mm/filemap.c | 29 ++++++--- mm/huge_memory.c | 9 +++ mm/readahead.c | 94 +++++++++++++++++++++------ 12 files changed, 242 insertions(+), 70 deletions(-) base-commit: 0bbac3facb5d6cc0171c45c9873a2dc96bea9680