diff mbox series

[v7,1/3] dt-bindings: arm: fsl: add Engicam i.Core MX93 EDIMM 2.0 Starter Kit

Message ID 20240429084422.8369-2-fabio.aiuto@engicam.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx93: add i.Core MX93 EDIMM 2.0 board | expand

Commit Message

Fabio Aiuto April 29, 2024, 8:44 a.m. UTC 
i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.

EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
Evaluation Board by Engicam.

i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.

Add bindings for this board.

Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
Reviewed-by: Krzysztof Kozlowsky <krzk@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Fabio Aiuto <fabio.aiuto@engicam.com>
---
v3 ---> v7:
        - no changes
v2 ---> v3:
        - added {Reviewed,Acked}-by tags
v1 ---> v2:
        - no changes

 Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski April 29, 2024, 8:53 a.m. UTC | #1 
On 29/04/2024 10:44, Fabio Aiuto wrote:
> i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.
> 
> EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
> Evaluation Board by Engicam.
> 
> i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
> to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.
> 
> Add bindings for this board.
> 
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
> Reviewed-by: Krzysztof Kozlowsky <krzk@kernel.org>

What the hell? Why are you changing tags?

This is corrupted since v3!

NAK.

Best regards,
Krzysztof
Fabio Aiuto April 29, 2024, 9:01 a.m. UTC | #2 
Dear Krzysztof,

Il Mon, Apr 29, 2024 at 10:53:08AM +0200, Krzysztof Kozlowski ha scritto:
> On 29/04/2024 10:44, Fabio Aiuto wrote:
> > i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.
> > 
> > EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
> > Evaluation Board by Engicam.
> > 
> > i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
> > to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.
> > 
> > Add bindings for this board.
> > 
> > Cc: Matteo Lisi <matteo.lisi@engicam.com>
> > Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
> > Reviewed-by: Krzysztof Kozlowsky <krzk@kernel.org>
> 
> What the hell? Why are you changing tags?

I fear I don't understand your comment. Did you gave me
your Reviewed-by: tag, didn't you?

When Conor gave me his Acked-by in v2 told me to pick up
yours too...

that's all

kr,

fabio

> 
> This is corrupted since v3!
> 
> NAK.
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski April 29, 2024, 9:04 a.m. UTC | #3 
On 29/04/2024 11:01, Fabio Aiuto wrote:
> Dear Krzysztof,
> 
> Il Mon, Apr 29, 2024 at 10:53:08AM +0200, Krzysztof Kozlowski ha scritto:
>> On 29/04/2024 10:44, Fabio Aiuto wrote:
>>> i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.
>>>
>>> EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
>>> Evaluation Board by Engicam.
>>>
>>> i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
>>> to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.
>>>
>>> Add bindings for this board.
>>>
>>> Cc: Matteo Lisi <matteo.lisi@engicam.com>
>>> Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
>>> Reviewed-by: Krzysztof Kozlowsky <krzk@kernel.org>
>>
>> What the hell? Why are you changing tags?
> 
> I fear I don't understand your comment. Did you gave me
> your Reviewed-by: tag, didn't you?
> 
> When Conor gave me his Acked-by in v2 told me to pick up
> yours too...

I *DID NOT* give such tag. Why do you manually type people names? You
are ought to COPY the entire tag. Not amend it, not change it, not try
to write by yourself.

Best regards,
Krzysztof
Fabio Aiuto April 29, 2024, 9:22 a.m. UTC | #4 
Dear Krzysztof,

Il Mon, Apr 29, 2024 at 11:04:03AM +0200, Krzysztof Kozlowski ha scritto:
> On 29/04/2024 11:01, Fabio Aiuto wrote:
> > Dear Krzysztof,
> > 
> > Il Mon, Apr 29, 2024 at 10:53:08AM +0200, Krzysztof Kozlowski ha scritto:
> >> On 29/04/2024 10:44, Fabio Aiuto wrote:
> >>> i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.
> >>>
> >>> EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
> >>> Evaluation Board by Engicam.
> >>>
> >>> i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
> >>> to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.
> >>>
> >>> Add bindings for this board.
> >>>
> >>> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> >>> Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
> >>> Reviewed-by: Krzysztof Kozlowsky <krzk@kernel.org>
> >>
> >> What the hell? Why are you changing tags?
> > 
> > I fear I don't understand your comment. Did you gave me
> > your Reviewed-by: tag, didn't you?
> > 
> > When Conor gave me his Acked-by in v2 told me to pick up
> > yours too...
> 
> I *DID NOT* give such tag. Why do you manually type people names? You
> are ought to COPY the entire tag. Not amend it, not change it, not try
> to write by yourself.

I apologize for that, will send a v8

kr,

fabio

> 
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 0027201e19f8..b497a01c7418 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1265,6 +1265,13 @@  properties:
               - fsl,imx93-11x11-evk       # i.MX93 11x11 EVK Board
           - const: fsl,imx93
 
+      - description: Engicam i.Core MX93 based Boards
+        items:
+          - enum:
+              - engicam,icore-mx93-edimm2         # i.MX93 Engicam i.Core MX93 EDIMM 2.0 Starter Kit
+          - const: engicam,icore-mx93             # i.MX93 Engicam i.Core MX93 Som
+          - const: fsl,imx93
+
       - description: i.MXRT1050 based Boards
         items:
           - enum: