| Message ID | 20240426-samsung-pinctrl-busclock-v3-0-adb8664b8a7e@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | clock support for Samsung Exynos pin controller (Google Tensor gs101) | expand |
On Fri, 26 Apr 2024 14:25:13 +0100, André Draszik wrote: > This series enables clock support on the Samsung Exynos pin controller > driver. > > This is required on Socs like Google Tensor gs101, which implement > fine-grained clock control / gating, and as such a running bus clock is > required for register access to work. > > [...] Applied, thanks! [1/2] dt-bindings: pinctrl: samsung: google,gs101-pinctrl needs a clock https://git.kernel.org/pinctrl/samsung/c/dff9f3fb6ba4f74eb805bc172cc16ff2c91648bf [2/2] pinctrl: samsung: support a bus clock https://git.kernel.org/pinctrl/samsung/c/f9c74474797351c60e009ebc59a798fcfd93ee57 Best regards,
On 29/04/2024 19:28, Krzysztof Kozlowski wrote: > > On Fri, 26 Apr 2024 14:25:13 +0100, André Draszik wrote: >> This series enables clock support on the Samsung Exynos pin controller >> driver. >> >> This is required on Socs like Google Tensor gs101, which implement >> fine-grained clock control / gating, and as such a running bus clock is >> required for register access to work. >> Where's the DTS? Best regards, Krzysztof
Hi Krzysztof, On Mon, 2024-04-29 at 19:45 +0200, Krzysztof Kozlowski wrote: > On 29/04/2024 19:28, Krzysztof Kozlowski wrote: > > > > On Fri, 26 Apr 2024 14:25:13 +0100, André Draszik wrote: > > > This series enables clock support on the Samsung Exynos pin controller > > > driver. > > > > > > This is required on Socs like Google Tensor gs101, which implement > > > fine-grained clock control / gating, and as such a running bus clock is > > > required for register access to work. > > > > > Where's the DTS? Here: https://lore.kernel.org/r/20240429-samsung-pinctrl-busclock-dts-v1-0-5e935179f3ca@linaro.org (I was waiting to see how the HSI2 patches pan out) Thanks, Andre
On Mon, 2024-04-29 at 21:06 +0100, André Draszik wrote: > Hi Krzysztof, > > On Mon, 2024-04-29 at 19:45 +0200, Krzysztof Kozlowski wrote: > > On 29/04/2024 19:28, Krzysztof Kozlowski wrote: > > > > > > On Fri, 26 Apr 2024 14:25:13 +0100, André Draszik wrote: > > > > This series enables clock support on the Samsung Exynos pin controller > > > > driver. > > > > > > > > This is required on Socs like Google Tensor gs101, which implement > > > > fine-grained clock control / gating, and as such a running bus clock is > > > > required for register access to work. > > > > > > > > Where's the DTS? > > Here: https://lore.kernel.org/r/20240429-samsung-pinctrl-busclock-dts-v1-0-5e935179f3ca@linaro.org > > (I was waiting to see how the HSI2 patches pan out) ... and potential binding feedback of course :-)
This series enables clock support on the Samsung Exynos pin controller driver. This is required on Socs like Google Tensor gs101, which implement fine-grained clock control / gating, and as such a running bus clock is required for register access to work. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- Changes in v3: - fix binding for non-gs101 platforms (Krzysztof), sorry I missed that initially :-( - Link to v2: https://lore.kernel.org/r/20240426-samsung-pinctrl-busclock-v2-0-8dfecaabf020@linaro.org Changes in v2: - propagate clk_enable() errors in samsung_pinmux_setup(), i.e. struct pinmux_ops::set_mux() - move clk_enable()/disable() outside bank->slock lock, to avoid possible deadlocks due to locking inversion (Krzysztof) - fix some comments (Krzysztof) - use 'ret' instead of 'i' in samsung_pinctrl_resume() (Krzysztof) - Link to v1: https://lore.kernel.org/r/20240425-samsung-pinctrl-busclock-v1-0-898a200abe68@linaro.org --- André Draszik (2): dt-bindings: pinctrl: samsung: google,gs101-pinctrl needs a clock pinctrl: samsung: support a bus clock .../bindings/pinctrl/samsung,pinctrl.yaml | 21 ++++ drivers/pinctrl/samsung/pinctrl-exynos.c | 112 +++++++++++++++++++++ drivers/pinctrl/samsung/pinctrl-samsung.c | 95 ++++++++++++++++- drivers/pinctrl/samsung/pinctrl-samsung.h | 2 + 4 files changed, 227 insertions(+), 3 deletions(-) --- base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8 change-id: 20240425-samsung-pinctrl-busclock-151c23d76860 Best regards,