| Message ID | 20240502052356.2630798-1-kiran.k@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d250f0cced6247cc4b2e38098fa2c8b4269ce78a |
| Headers | show |
| Series | [v1,1/2] Bluetooth: btintel: Add support for BlazarI | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
| tedd_an/CheckSmatch | fail | CheckSparse: FAIL: Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139 make[4]: *** Deleting file 'net/bluetooth/hci_core.o' make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: net] Error 2 make[2]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o' make[4]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o' make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: drivers] Error 2 make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2 make: *** [Makefile:240: __sub-make] Error 2 |
| tedd_an/BuildKernel32 | success | BuildKernel32 PASS |
| tedd_an/TestRunnerSetup | success | TestRunnerSetup PASS |
| tedd_an/TestRunner_l2cap-tester | success | TestRunner PASS |
| tedd_an/TestRunner_iso-tester | fail | TestRunner_iso-tester: Total: 122, Passed: 121 (99.2%), Failed: 1, Not Run: 0 |
| tedd_an/TestRunner_bnep-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mgmt-tester | success | TestRunner PASS |
| tedd_an/TestRunner_rfcomm-tester | success | TestRunner PASS |
| tedd_an/TestRunner_sco-tester | success | TestRunner PASS |
| tedd_an/TestRunner_ioctl-tester | success | TestRunner PASS |
| tedd_an/TestRunner_mesh-tester | success | TestRunner PASS |
| tedd_an/TestRunner_smp-tester | success | TestRunner PASS |
| tedd_an/TestRunner_userchan-tester | success | TestRunner PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=849788 ---Test result--- Test Summary: CheckPatch PASS 1.21 seconds GitLint PASS 0.59 seconds SubjectPrefix PASS 0.22 seconds BuildKernel PASS 29.72 seconds CheckAllWarning PASS 32.10 seconds CheckSparse PASS 38.11 seconds CheckSmatch FAIL 35.68 seconds BuildKernel32 PASS 28.43 seconds TestRunnerSetup PASS 513.61 seconds TestRunner_l2cap-tester PASS 20.23 seconds TestRunner_iso-tester FAIL 34.77 seconds TestRunner_bnep-tester PASS 5.29 seconds TestRunner_mgmt-tester PASS 112.66 seconds TestRunner_rfcomm-tester PASS 7.28 seconds TestRunner_sco-tester PASS 14.90 seconds TestRunner_ioctl-tester PASS 7.54 seconds TestRunner_mesh-tester PASS 5.73 seconds TestRunner_smp-tester PASS 8.17 seconds TestRunner_userchan-tester PASS 4.81 seconds IncrementalBuild PASS 33.92 seconds Details ############################## Test: CheckSmatch - FAIL Desc: Run smatch tool with source Output: Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139 make[4]: *** Deleting file 'net/bluetooth/hci_core.o' make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: net] Error 2 make[2]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o' make[4]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o' make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: drivers] Error 2 make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2 make: *** [Makefile:240: __sub-make] Error 2 ############################## Test: TestRunner_iso-tester - FAIL Desc: Run iso-tester with test-runner Output: Total: 122, Passed: 121 (99.2%), Failed: 1, Not Run: 0 Failed Test Cases ISO Connect Suspend - Success Failed 4.165 seconds --- Regards, Linux Bluetooth
Dear Kiran, Thank you for your patch. Am 02.05.24 um 07:23 schrieb Kiran K: > Add support for BlazarI (cnvi) bluetooth core. It’d be great if you documented the datasheet name and revision. Also, it’d help people reading the diff, if you added what the support entails. In this case a note, that it’s a “standard device” and only the new id needs to be added, would be nice. > Signed-off-by: Kiran K <kiran.k@intel.com> > --- > drivers/bluetooth/btintel.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c > index dc48352166a5..4f4bd5538b6e 100644 > --- a/drivers/bluetooth/btintel.c > +++ b/drivers/bluetooth/btintel.c > @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev *hdev, > case 0x19: /* Slr-F */ > case 0x1b: /* Mgr */ > case 0x1c: /* Gale Peak (GaP) */ > + case 0x1e: /* BlazarI (Bzr) */ > break; > default: > bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)", > @@ -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant) > case 0x19: > case 0x1b: > case 0x1c: > + case 0x1e: > hci_set_msft_opcode(hdev, 0xFC1E); > break; > default: > @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev *hdev) > case 0x19: > case 0x1b: > case 0x1c: > + case 0x1e: > /* Display version information of TLV type */ > btintel_version_info_tlv(hdev, &ver_tlv); Kind regards, Paul
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 2 May 2024 10:53:55 +0530 you wrote: > Add support for BlazarI (cnvi) bluetooth core. > > Signed-off-by: Kiran K <kiran.k@intel.com> > --- > drivers/bluetooth/btintel.c | 3 +++ > 1 file changed, 3 insertions(+) Here is the summary with links: - [v1,1/2] Bluetooth: btintel: Add support for BlazarI https://git.kernel.org/bluetooth/bluetooth-next/c/d250f0cced62 - [v1,2/2] Bluetooth: btintel: Add support for Filmore Peak2 (BE201) https://git.kernel.org/bluetooth/bluetooth-next/c/93ff8ae40fcc You are awesome, thank you!
Hi Paul, Appreciate your comments. > -----Original Message----- > From: Paul Menzel <pmenzel@molgen.mpg.de> > Sent: Thursday, May 2, 2024 11:24 AM > To: K, Kiran <kiran.k@intel.com> > Cc: linux-bluetooth@vger.kernel.org; Srivatsa, Ravishankar > <ravishankar.srivatsa@intel.com>; Tumkur Narayan, Chethan > <chethan.tumkur.narayan@intel.com>; Devegowda, Chandrashekar > <chandrashekar.devegowda@intel.com> > Subject: Re: [PATCH v1 1/2] Bluetooth: btintel: Add support for BlazarI > > Dear Kiran, > > > Thank you for your patch. > > Am 02.05.24 um 07:23 schrieb Kiran K: > > Add support for BlazarI (cnvi) bluetooth core. > > It’d be great if you documented the datasheet name and revision. I am afraid to provide these details as these data is internal. > > Also, it’d help people reading the diff, if you added what the support entails. > In this case a note, that it’s a “standard device” and only the new id needs to > be added, would be nice. Ack. > > > Signed-off-by: Kiran K <kiran.k@intel.com> > > --- > > drivers/bluetooth/btintel.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c > > index dc48352166a5..4f4bd5538b6e 100644 > > --- a/drivers/bluetooth/btintel.c > > +++ b/drivers/bluetooth/btintel.c > > @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev > *hdev, > > case 0x19: /* Slr-F */ > > case 0x1b: /* Mgr */ > > case 0x1c: /* Gale Peak (GaP) */ > > + case 0x1e: /* BlazarI (Bzr) */ > > break; > > default: > > bt_dev_err(hdev, "Unsupported Intel hardware variant > (0x%x)", @@ > > -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev > *hdev, u8 hw_variant) > > case 0x19: > > case 0x1b: > > case 0x1c: > > + case 0x1e: > > hci_set_msft_opcode(hdev, 0xFC1E); > > break; > > default: > > @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev > *hdev) > > case 0x19: > > case 0x1b: > > case 0x1c: > > + case 0x1e: > > /* Display version information of TLV type */ > > btintel_version_info_tlv(hdev, &ver_tlv); > > > Kind regards, > > Paul Thanks, Kiran
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index dc48352166a5..4f4bd5538b6e 100644 --- a/drivers/bluetooth/btintel.c +++ b/drivers/bluetooth/btintel.c @@ -481,6 +481,7 @@ static int btintel_version_info_tlv(struct hci_dev *hdev, case 0x19: /* Slr-F */ case 0x1b: /* Mgr */ case 0x1c: /* Gale Peak (GaP) */ + case 0x1e: /* BlazarI (Bzr) */ break; default: bt_dev_err(hdev, "Unsupported Intel hardware variant (0x%x)", @@ -2698,6 +2699,7 @@ static void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant) case 0x19: case 0x1b: case 0x1c: + case 0x1e: hci_set_msft_opcode(hdev, 0xFC1E); break; default: @@ -3037,6 +3039,7 @@ static int btintel_setup_combined(struct hci_dev *hdev) case 0x19: case 0x1b: case 0x1c: + case 0x1e: /* Display version information of TLV type */ btintel_version_info_tlv(hdev, &ver_tlv);
Add support for BlazarI (cnvi) bluetooth core. Signed-off-by: Kiran K <kiran.k@intel.com> --- drivers/bluetooth/btintel.c | 3 +++ 1 file changed, 3 insertions(+)