Message ID | 30ba385282572a2a5803b762decde061f81b8cc0.1714046812.git.siyanteng@loongson.cn (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | stmmac: Add Loongson platform support | expand |
Hi, Yanteng, On Thu, Apr 25, 2024 at 9:11 PM Yanteng Si <siyanteng@loongson.cn> wrote: > > Add Yanteng Si as MODULE_AUTHOR of Loongson DWMAC PCI driver. > > Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn> > Signed-off-by: Yinggang Gu <guyinggang@loongson.cn> > Signed-off-by: Yanteng Si <siyanteng@loongson.cn> > --- > drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > index dea02de030e6..f0eebed751f3 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > @@ -638,4 +638,5 @@ module_pci_driver(loongson_dwmac_driver); > > MODULE_DESCRIPTION("Loongson DWMAC PCI driver"); > MODULE_AUTHOR("Qing Zhang <zhangqing@loongson.cn>"); > +MODULE_AUTHOR("Yanteng Si <siyanteng@loongson.cn>"); > MODULE_LICENSE("GPL v2"); The patch splitting is toooo strange for this line. Since Qing Zhang is the major author of GMAC, and you are the major author of GNET, I think this line can be in Patch-13. Huacai > -- > 2.31.4 >
On Mon, May 06, 2024 at 10:12:14AM +0800, Huacai Chen wrote: > Hi, Yanteng, > > On Thu, Apr 25, 2024 at 9:11 PM Yanteng Si <siyanteng@loongson.cn> wrote: > > > > Add Yanteng Si as MODULE_AUTHOR of Loongson DWMAC PCI driver. > > > > Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn> > > Signed-off-by: Yinggang Gu <guyinggang@loongson.cn> > > Signed-off-by: Yanteng Si <siyanteng@loongson.cn> > > --- > > drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > > index dea02de030e6..f0eebed751f3 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c > > @@ -638,4 +638,5 @@ module_pci_driver(loongson_dwmac_driver); > > > > MODULE_DESCRIPTION("Loongson DWMAC PCI driver"); > > MODULE_AUTHOR("Qing Zhang <zhangqing@loongson.cn>"); > > +MODULE_AUTHOR("Yanteng Si <siyanteng@loongson.cn>"); > > MODULE_LICENSE("GPL v2"); > The patch splitting is toooo strange for this line. It's not. > Since Qing Zhang > is the major author of GMAC, and you are the major author of GNET, I > think this line can be in Patch-13. The patch size isn't something that determines the change placement, but the change solving only one problem per patch. This patch is about adding the driver author. The patch 13 is about adding the GNET device support. It's perfectly fine to have these changes provided separately and in the order they are submitted in v12. Besides the patch 13 has just started getting to look reviewable enough. Stop trying to mix up various changes in there again. It was me who asked Yanteng to detach this changes into a separate and final patch of the series, for the exact reasons I described above. -Serge(y) > > Huacai > > > -- > > 2.31.4 > >
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index dea02de030e6..f0eebed751f3 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -638,4 +638,5 @@ module_pci_driver(loongson_dwmac_driver); MODULE_DESCRIPTION("Loongson DWMAC PCI driver"); MODULE_AUTHOR("Qing Zhang <zhangqing@loongson.cn>"); +MODULE_AUTHOR("Yanteng Si <siyanteng@loongson.cn>"); MODULE_LICENSE("GPL v2");