| Message ID | 20240429-regulator-get-enable-get-votlage-v2-0-b1f11ab766c1@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | regulator: new API for voltage reference supplies | expand |
On Mon, 29 Apr 2024 18:40:08 -0500, David Lechner wrote: > In the IIO subsystem, we noticed a pattern in many drivers where we need > to get, enable and get the voltage of a supply that provides a reference > voltage. In these cases, we only need the voltage and not a handle to > the regulator. Another common pattern is for chips to have an internal > reference voltage that is used when an external reference is not > available. There are also a few drivers outside of IIO that do the same. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/7] regulator: devres: add API for reference voltage supplies commit: b250c20b64290808aa4b5cc6d68819a7ee28237f [2/7] hwmon: (adc128d818) Use devm_regulator_get_enable_read_voltage() commit: cffb8d74bd4e9dd0653c7093c4a5164a72c52b1f [3/7] hwmon: (da9052) Use devm_regulator_get_enable_read_voltage() commit: d72fd5228c9f2136a3143daf5c7822140211883a All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Mon, May 6, 2024 at 9:59 AM Mark Brown <broonie@kernel.org> wrote: > > On Mon, 29 Apr 2024 18:40:08 -0500, David Lechner wrote: > > In the IIO subsystem, we noticed a pattern in many drivers where we need > > to get, enable and get the voltage of a supply that provides a reference > > voltage. In these cases, we only need the voltage and not a handle to > > the regulator. Another common pattern is for chips to have an internal > > reference voltage that is used when an external reference is not > > available. There are also a few drivers outside of IIO that do the same. > > > > [...] > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next > > Thanks! > > [1/7] regulator: devres: add API for reference voltage supplies > commit: b250c20b64290808aa4b5cc6d68819a7ee28237f > [2/7] hwmon: (adc128d818) Use devm_regulator_get_enable_read_voltage() > commit: cffb8d74bd4e9dd0653c7093c4a5164a72c52b1f > [3/7] hwmon: (da9052) Use devm_regulator_get_enable_read_voltage() > commit: d72fd5228c9f2136a3143daf5c7822140211883a > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent to Linus during > the next merge window (or sooner if it is a bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > Hi Jonathan, if Mark doesn't pick up the iio patches here, I'll resend them after the next kernel release.
On Mon, 29 Apr 2024 18:40:08 -0500, David Lechner wrote: > In the IIO subsystem, we noticed a pattern in many drivers where we need > to get, enable and get the voltage of a supply that provides a reference > voltage. In these cases, we only need the voltage and not a handle to > the regulator. Another common pattern is for chips to have an internal > reference voltage that is used when an external reference is not > available. There are also a few drivers outside of IIO that do the same. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [4/7] iio: addac: ad74115: Use devm_regulator_get_enable_read_voltage() commit: 41b94bc6d96b9b046ef08114f057dcc6c52e28b6 [5/7] iio: frequency: admv1013: Use devm_regulator_get_enable_read_voltage() commit: 2f4bb1fa758abf4f5ee5a70ea7c2b1b8c8f7625d [6/7] staging: iio: impedance-analyzer: ad5933: Use devm_regulator_get_enable_read_voltage() commit: 9fcf6ef3e10b9fc605d84802058c0f30517bbaa7 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
In the IIO subsystem, we noticed a pattern in many drivers where we need to get, enable and get the voltage of a supply that provides a reference voltage. In these cases, we only need the voltage and not a handle to the regulator. Another common pattern is for chips to have an internal reference voltage that is used when an external reference is not available. There are also a few drivers outside of IIO that do the same. So we would like to propose a new regulator consumer API to handle these specific cases to avoid repeating the same boilerplate code in multiple drivers. As an example of how these functions are used, I have included a few patches to consumer drivers. But to avoid a giant patch bomb, I have omitted the iio/adc and iio/dac patches I have prepared from this series. I will send those separately but these will add 36 more users of devm_regulator_get_enable_read_voltage() in addition to the 6 here. In total, this will eliminate nearly 1000 lines of similar code and will simplify writing and reviewing new drivers in the future. --- Changes in v2: - Reworked regulator patch to remove dev_err_probe() and properly unwind - Combined two proposed functions into a single function - Renamed function to devm_regulator_get_enable_read_voltage() everywhere - Fixed other feedback on consumer patches (see individual patches) - Picked up Jonathan's Reviewed-bys (hopefully changes were trivial enough) - Link to v1: https://lore.kernel.org/r/20240327-regulator-get-enable-get-votlage-v1-0-5f4517faa059@baylibre.com --- David Lechner (7): regulator: devres: add API for reference voltage supplies hwmon: (adc128d818) Use devm_regulator_get_enable_read_voltage() hwmon: (da9052) Use devm_regulator_get_enable_read_voltage() iio: addac: ad74115: Use devm_regulator_get_enable_read_voltage() iio: frequency: admv1013: Use devm_regulator_get_enable_read_voltage() staging: iio: impedance-analyzer: ad5933: Use devm_regulator_get_enable_read_voltage() Input: mpr121: Use devm_regulator_get_enable_read_voltage() Documentation/driver-api/driver-model/devres.rst | 1 + drivers/hwmon/adc128d818.c | 57 +++++++---------------- drivers/hwmon/da9052-hwmon.c | 38 ++++----------- drivers/iio/addac/ad74115.c | 40 ++++++---------- drivers/iio/frequency/admv1013.c | 40 ++++------------ drivers/input/keyboard/mpr121_touchkey.c | 45 ++---------------- drivers/regulator/devres.c | 59 ++++++++++++++++++++++++ drivers/staging/iio/impedance-analyzer/ad5933.c | 26 +---------- include/linux/regulator/consumer.h | 7 +++ 9 files changed, 124 insertions(+), 189 deletions(-) --- base-commit: 84c1815e46bdcb8bb0259db3d6cdd934cb70a0e9 change-id: 20240326-regulator-get-enable-get-votlage-5dedf40ff338