| Message ID | 20240421134752.2652-1-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Use new helper function for clock and PM macro | expand |
On Sun, Apr 21, 2024, Anand Moon wrote: > using new helper functions for dev resources for clock and PM > to simplify the code changes. > > Addressed some review comments. > > v4: Add Reviewed-by: Alan Stern For patches 1 - 4: > Add Acked-by: Thinh Nguyen For patch 5 > Fix rephase commit messaeg for patch 2 and 4 > Fix some typo in the commit messagee > > v3 changes: > 1 Use new DEFINE_SIMPLE_DEV_PM_OPS macro for PM operations > Thanks to Thinh Nguyen for your inputs. > so I have to update the $subject and commit messagee with using new > macro. > > 2 Drop the dev_err_probe in return to simplify the error for clocks. > > 3 Dop the devm_regulator_bulk_get_enable patch. > > Tests on Odroid XU4 and Odroid U3. > found no regression with suspend resume functionality. > > Previous changes: > V3: https://urldefense.com/v3/__https://lore.kernel.org/all/20240412142317.5191-6-linux.amoon@gmail.com/__;!!A4F2R9G_pg!b2EBzV-UTfuvwSmse-8kl4jsq8t4KgBPT_G--QCG_TDV4atcywVQgLHPFGmxGnPASOKOmp6r0xyI2DnUnRp_cur6Ew$ > > V2: https://urldefense.com/v3/__https://lore.kernel.org/all/20240404071350.4242-3-linux.amoon@gmail.com/__;!!A4F2R9G_pg!b2EBzV-UTfuvwSmse-8kl4jsq8t4KgBPT_G--QCG_TDV4atcywVQgLHPFGmxGnPASOKOmp6r0xyI2DnUnRqoIl7uEA$ > > V1: https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-samsung-soc/patch/20240301193831.3346-2-linux.amoon@gmail.com/__;!!A4F2R9G_pg!b2EBzV-UTfuvwSmse-8kl4jsq8t4KgBPT_G--QCG_TDV4atcywVQgLHPFGmxGnPASOKOmp6r0xyI2DnUnRpJKM0R2g$ > > Thanks > -Anand > > Anand Moon (5): > usb: ehci-exynos: Use devm_clk_get_enabled() helpers > usb: ehci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions > usb: ohci-exynos: Use devm_clk_get_enabled() helpers > usb: ohci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions > usb: dwc3: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions > > drivers/usb/dwc3/dwc3-exynos.c | 13 +++---------- > drivers/usb/host/ehci-exynos.c | 27 ++++++--------------------- > drivers/usb/host/ohci-exynos.c | 27 ++++++--------------------- > 3 files changed, 15 insertions(+), 52 deletions(-) > > -- > 2.44.0 > The v3 of this series is already pulled by Greg. Changes for v4 are not important. We can ignore v4. Thanks, Thinh
Hi Thinh, On Wed, 24 Apr 2024 at 06:51, Thinh Nguyen <Thinh.Nguyen@synopsys.com> wrote: > > On Sun, Apr 21, 2024, Anand Moon wrote: > > using new helper functions for dev resources for clock and PM > > to simplify the code changes. > > > > Addressed some review comments. > > > > v4: Add Reviewed-by: Alan Stern For patches 1 - 4: > > Add Acked-by: Thinh Nguyen For patch 5 > > Fix rephase commit messaeg for patch 2 and 4 > > Fix some typo in the commit messagee > > > > v3 changes: > > 1 Use new DEFINE_SIMPLE_DEV_PM_OPS macro for PM operations > > Thanks to Thinh Nguyen for your inputs. > > so I have to update the $subject and commit messagee with using new > > macro. > > > > 2 Drop the dev_err_probe in return to simplify the error for clocks. > > > > 3 Dop the devm_regulator_bulk_get_enable patch. > > > > Tests on Odroid XU4 and Odroid U3. > > found no regression with suspend resume functionality. > > > > Previous changes: > > V3: https://urldefense.com/v3/__https://lore.kernel.org/all/20240412142317.5191-6-linux.amoon@gmail.com/__;!!A4F2R9G_pg!b2EBzV-UTfuvwSmse-8kl4jsq8t4KgBPT_G--QCG_TDV4atcywVQgLHPFGmxGnPASOKOmp6r0xyI2DnUnRp_cur6Ew$ > > > > V2: https://urldefense.com/v3/__https://lore.kernel.org/all/20240404071350.4242-3-linux.amoon@gmail.com/__;!!A4F2R9G_pg!b2EBzV-UTfuvwSmse-8kl4jsq8t4KgBPT_G--QCG_TDV4atcywVQgLHPFGmxGnPASOKOmp6r0xyI2DnUnRqoIl7uEA$ > > > > V1: https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-samsung-soc/patch/20240301193831.3346-2-linux.amoon@gmail.com/__;!!A4F2R9G_pg!b2EBzV-UTfuvwSmse-8kl4jsq8t4KgBPT_G--QCG_TDV4atcywVQgLHPFGmxGnPASOKOmp6r0xyI2DnUnRpJKM0R2g$ > > > > Thanks > > -Anand > > > > Anand Moon (5): > > usb: ehci-exynos: Use devm_clk_get_enabled() helpers > > usb: ehci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions > > usb: ohci-exynos: Use devm_clk_get_enabled() helpers > > usb: ohci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions > > usb: dwc3: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions > > > > drivers/usb/dwc3/dwc3-exynos.c | 13 +++---------- > > drivers/usb/host/ehci-exynos.c | 27 ++++++--------------------- > > drivers/usb/host/ohci-exynos.c | 27 ++++++--------------------- > > 3 files changed, 15 insertions(+), 52 deletions(-) > > > > -- > > 2.44.0 > > > > The v3 of this series is already pulled by Greg. Changes for v4 are not > important. We can ignore v4. > Anyway thanks for the input, I just tried to update the commit message relevant to the changes. > Thanks, > Thinh Thanks -Anand
using new helper functions for dev resources for clock and PM to simplify the code changes. Addressed some review comments. v4: Add Reviewed-by: Alan Stern For patches 1 - 4: Add Acked-by: Thinh Nguyen For patch 5 Fix rephase commit messaeg for patch 2 and 4 Fix some typo in the commit messagee v3 changes: 1 Use new DEFINE_SIMPLE_DEV_PM_OPS macro for PM operations Thanks to Thinh Nguyen for your inputs. so I have to update the $subject and commit messagee with using new macro. 2 Drop the dev_err_probe in return to simplify the error for clocks. 3 Dop the devm_regulator_bulk_get_enable patch. Tests on Odroid XU4 and Odroid U3. found no regression with suspend resume functionality. Previous changes: V3: https://lore.kernel.org/all/20240412142317.5191-6-linux.amoon@gmail.com/ V2: https://lore.kernel.org/all/20240404071350.4242-3-linux.amoon@gmail.com/ V1: https://patchwork.kernel.org/project/linux-samsung-soc/patch/20240301193831.3346-2-linux.amoon@gmail.com/ Thanks -Anand Anand Moon (5): usb: ehci-exynos: Use devm_clk_get_enabled() helpers usb: ehci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions usb: ohci-exynos: Use devm_clk_get_enabled() helpers usb: ohci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions usb: dwc3: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions drivers/usb/dwc3/dwc3-exynos.c | 13 +++---------- drivers/usb/host/ehci-exynos.c | 27 ++++++--------------------- drivers/usb/host/ohci-exynos.c | 27 ++++++--------------------- 3 files changed, 15 insertions(+), 52 deletions(-)