diff mbox series

[v2,1/5] dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A

Message ID 20240511121245.109644-2-felix@kaechele.ca (mailing list archive)
State Mainlined
Commit dd2d6b00ccdc6ab7416d63c5e722b0687150b4bc
Headers show
Series input: himax_hx83112b: add support for HX83100A | expand

Commit Message

Felix Kaechele May 11, 2024, 12:12 p.m. UTC
Add a compatible string for the Himax HX83100A touch controller.

Signed-off-by: Felix Kaechele <felix@kaechele.ca>
---
 .../devicetree/bindings/input/touchscreen/himax,hx83112b.yaml    | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley May 11, 2024, 12:38 p.m. UTC | #1
On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote:
> Add a compatible string for the Himax HX83100A touch controller.
> 
> Signed-off-by: Felix Kaechele <felix@kaechele.ca>

Commit message should mention what makes this device incompatible with
the existing device.

Thanks,
Conor.

> ---
>  .../devicetree/bindings/input/touchscreen/himax,hx83112b.yaml    | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
> index f42b23d532eb..f5cfacb5e966 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
> @@ -15,6 +15,7 @@ allOf:
>  properties:
>    compatible:
>      enum:
> +      - himax,hx83100a
>        - himax,hx83112b
>  
>    reg:
> -- 
> 2.45.0
>
Felix Kaechele May 11, 2024, 2:10 p.m. UTC | #2
On 2024-05-11 08:38, Conor Dooley wrote:
> On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote:
>> Add a compatible string for the Himax HX83100A touch controller.
>>
>> Signed-off-by: Felix Kaechele <felix@kaechele.ca>
> 
> Commit message should mention what makes this device incompatible with
> the existing device.

Thanks!

I have added this note in the commit message which will be part of a v3, 
coming after I hopefully receive a few more comments on the other parts 
of this change:

The HX83100A presents touch events on its internal bus rather than 
offering a dedicated event register like the other chips in this family do.

Felix
Conor Dooley May 12, 2024, 12:04 p.m. UTC | #3
On Sat, May 11, 2024 at 10:10:08AM -0400, Felix Kaechele wrote:
> On 2024-05-11 08:38, Conor Dooley wrote:
> > On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote:
> > > Add a compatible string for the Himax HX83100A touch controller.
> > > 
> > > Signed-off-by: Felix Kaechele <felix@kaechele.ca>
> > 
> > Commit message should mention what makes this device incompatible with
> > the existing device.
> 
> Thanks!
> 
> I have added this note in the commit message which will be part of a v3,
> coming after I hopefully receive a few more comments on the other parts of
> this change:
> 
> The HX83100A presents touch events on its internal bus rather than offering
> a dedicated event register like the other chips in this family do.

Ye, that sounds good. W/ that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
index f42b23d532eb..f5cfacb5e966 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml
@@ -15,6 +15,7 @@  allOf:
 properties:
   compatible:
     enum:
+      - himax,hx83100a
       - himax,hx83112b
 
   reg: