| Message ID | 20240511132423.311884-1-sui.jingfeng@linux.dev (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: tfp410: Remove a small useless code snippet | expand |
Hi Sui, Thank you for the patch. On Sat, May 11, 2024 at 09:24:23PM +0800, Sui Jingfeng wrote: > In the tfp410_attach(), the check on the existence of bridge->encoder has > already been done in the implementation of drm_bridge_attach() function. > The driver won't go further if bridge->encoder is NULL and the driver will > quit even if drm_bridge_attach() fails for some reasons. > > Therefore there is no need to check another time at the later, remove the > redundant checking codes "if (!bridge->encoder) { ... }". > > Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/ti-tfp410.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c > index c7bef5c23927..b1b1e4d5a24a 100644 > --- a/drivers/gpu/drm/bridge/ti-tfp410.c > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c > @@ -133,11 +133,6 @@ static int tfp410_attach(struct drm_bridge *bridge, > if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) > return 0; > > - if (!bridge->encoder) { > - dev_err(dvi->dev, "Missing encoder\n"); > - return -ENODEV; > - } > - > if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT) > dvi->connector.polled = DRM_CONNECTOR_POLL_HPD; > else
diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index c7bef5c23927..b1b1e4d5a24a 100644 --- a/drivers/gpu/drm/bridge/ti-tfp410.c +++ b/drivers/gpu/drm/bridge/ti-tfp410.c @@ -133,11 +133,6 @@ static int tfp410_attach(struct drm_bridge *bridge, if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) return 0; - if (!bridge->encoder) { - dev_err(dvi->dev, "Missing encoder\n"); - return -ENODEV; - } - if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT) dvi->connector.polled = DRM_CONNECTOR_POLL_HPD; else
In the tfp410_attach(), the check on the existence of bridge->encoder has already been done in the implementation of drm_bridge_attach() function. The driver won't go further if bridge->encoder is NULL and the driver will quit even if drm_bridge_attach() fails for some reasons. Therefore there is no need to check another time at the later, remove the redundant checking codes "if (!bridge->encoder) { ... }". Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev> --- drivers/gpu/drm/bridge/ti-tfp410.c | 5 ----- 1 file changed, 5 deletions(-)