diff mbox series

[BlueZ] tools: fix using too small buffers in test-runner

Message ID 9b7b8130a4296de7e02435d7be3c6d00c4976427.1715423446.git.pav@iki.fi (mailing list archive)
State Accepted
Commit 24039249854ee027b565753a82ec962e2f3035f8
Headers show
Series [BlueZ] tools: fix using too small buffers in test-runner | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/CheckPatch success CheckPatch PASS
tedd_an/GitLint success Gitlint PASS
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/IncrementalBuild success Incremental Build PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Pauli Virtanen May 11, 2024, 10:32 a.m. UTC
Fix compiler warning:

tools/test-runner.c:309:57: error: 'sprintf' may write a terminating nul
  past the end of the destination [-Werror=format-overflow=]
---
 tools/test-runner.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

bluez.test.bot@gmail.com May 11, 2024, 11:59 a.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=852514

---Test result---

Test Summary:
CheckPatch                    PASS      0.45 seconds
GitLint                       PASS      0.32 seconds
BuildEll                      PASS      24.29 seconds
BluezMake                     PASS      1620.69 seconds
MakeCheck                     PASS      13.30 seconds
MakeDistcheck                 PASS      176.44 seconds
CheckValgrind                 PASS      249.65 seconds
CheckSmatch                   PASS      349.86 seconds
bluezmakeextell               PASS      118.87 seconds
IncrementalBuild              PASS      1419.35 seconds
ScanBuild                     PASS      982.15 seconds



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org May 13, 2024, 2:10 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sat, 11 May 2024 13:32:07 +0300 you wrote:
> Fix compiler warning:
> 
> tools/test-runner.c:309:57: error: 'sprintf' may write a terminating nul
>   past the end of the destination [-Werror=format-overflow=]
> ---
>  tools/test-runner.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [BlueZ] tools: fix using too small buffers in test-runner
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=24039249854e

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/test-runner.c b/tools/test-runner.c
index 243eab468..5bdcf42fc 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -302,10 +302,10 @@  static void start_qemu(void)
 		const char *path = "/tmp/bt-server-bredr";
 		char *chrdev, *serdev;
 
-		chrdev = alloca(32 + strlen(path));
+		chrdev = alloca(48 + strlen(path));
 		sprintf(chrdev, "socket,path=%s,id=bt%d", path, i);
 
-		serdev = alloca(32);
+		serdev = alloca(48);
 		sprintf(serdev, "pci-serial,chardev=bt%d", i);
 
 		argv[pos++] = "-chardev";