[BlueZ,1/3] shared/tester: add ability to skip tests unless explicitly selected

Commit Message

Pauli Virtanen May 14, 2024, 8:41 p.m. UTC

Make it possible to skip running a test, and skip running if the test
was not explicitly selected on command line.
---

Notes:
    This series disables the TX timestamping related tests by default for
    now. The TX timestamping itself should be OK, and the assumption is we'd
    re-enable these tests again once the kernel feature is reworked.
    
    I left the BT_POLL_ERRQUEUE parts in aside from the tests for now, not
    yet clear where if that is going to go further yet.

 src/shared/tester.c | 32 ++++++++++++++++++++++++++++++++
 src/shared/tester.h |  2 ++
 2 files changed, 34 insertions(+)

Comments

[e-mail] May 14, 2024, 11:29 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=853223

---Test result---

Test Summary:
CheckPatch                    FAIL      1.22 seconds
GitLint                       FAIL      1.09 seconds
BuildEll                      PASS      24.25 seconds
BluezMake                     PASS      1664.16 seconds
MakeCheck                     PASS      13.01 seconds
MakeDistcheck                 PASS      174.92 seconds
CheckValgrind                 PASS      247.08 seconds
CheckSmatch                   WARNING   348.72 seconds
bluezmakeextell               PASS      118.31 seconds
IncrementalBuild              PASS      4560.27 seconds
ScanBuild                     PASS      999.19 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,3/3] Revert "mgmt-tester: update for Poll Errqueue experimental fature"
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'c777c55ab662db4e9853bb08a6e1e6c77b319e09', maybe rebased or not pulled?
#96: 
This reverts commit c777c55ab662db4e9853bb08a6e1e6c77b319e09.

/github/workspace/src/src/13664420.patch total: 0 errors, 1 warnings, 18 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13664420.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,1/3] shared/tester: add ability to skip tests unless explicitly selected

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
11: B2 Line has trailing whitespace: "    "
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
tools/sco-tester.c: note: in included file:./lib/bluetooth.h:219:15: warning: array of flexible structures./lib/bluetooth.h:224:31: warning: array of flexible structures


---
Regards,
Linux Bluetooth

[e-mail] May 15, 2024, 5:40 p.m. UTC | #2

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Tue, 14 May 2024 23:41:48 +0300 you wrote:
> Make it possible to skip running a test, and skip running if the test
> was not explicitly selected on command line.
> ---
> 
> Notes:
>     This series disables the TX timestamping related tests by default for
>     now. The TX timestamping itself should be OK, and the assumption is we'd
>     re-enable these tests again once the kernel feature is reworked.
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/3] shared/tester: add ability to skip tests unless explicitly selected
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a9f80a8195b7
  - [BlueZ,2/3] tools: disable running TX timestamping tests for now
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=975d3b148694
  - [BlueZ,3/3] Revert "mgmt-tester: update for Poll Errqueue experimental fature"
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d9de306a28fe

You are awesome, thank you!

Patch

diff --git a/src/shared/tester.c b/src/shared/tester.c
index a1ee5b687..56c8cba6f 100644
--- a/src/shared/tester.c
+++ b/src/shared/tester.c
@@ -563,6 +563,38 @@  void tester_pre_setup_failed(void)
 	g_idle_add(done_callback, test);
 }
 
+void tester_pre_setup_abort(void)
+{
+	struct test_case *test;
+
+	if (!test_current)
+		return;
+
+	test = test_current->data;
+
+	if (test->stage != TEST_STAGE_PRE_SETUP)
+		return;
+
+	if (test->timeout_id > 0) {
+		timeout_remove(test->timeout_id);
+		test->timeout_id = 0;
+	}
+
+	print_progress(test->name, COLOR_YELLOW, "not run");
+
+	g_idle_add(done_callback, test);
+}
+
+bool tester_pre_setup_skip_by_default(void)
+{
+	if (!option_prefix && !option_string) {
+		tester_pre_setup_abort();
+		return true;
+	}
+
+	return false;
+}
+
 void tester_setup_complete(void)
 {
 	struct test_case *test;
diff --git a/src/shared/tester.h b/src/shared/tester.h
index 16f41022d..1f8138434 100644
--- a/src/shared/tester.h
+++ b/src/shared/tester.h
@@ -59,6 +59,8 @@  void *tester_get_data(void);
 
 void tester_pre_setup_complete(void);
 void tester_pre_setup_failed(void);
+void tester_pre_setup_abort(void);
+bool tester_pre_setup_skip_by_default(void);
 
 void tester_setup_complete(void);
 void tester_setup_failed(void);