diff mbox series

drm/fbdev-dma: Clean up deferred I/O

Message ID 20240507145529.31368-1-tzimmermann@suse.de (mailing list archive)
State New, archived
Headers show
Series drm/fbdev-dma: Clean up deferred I/O | expand

Commit Message

Thomas Zimmermann May 7, 2024, 2:55 p.m. UTC 
Call fb_deferred_io_cleanup() upon destroying the framebuffer
device. Releases the internal memory.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred I/O")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
---
 drivers/gpu/drm/drm_fbdev_dma.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Javier Martinez Canillas May 15, 2024, 11:59 a.m. UTC | #1 
Thomas Zimmermann <tzimmermann@suse.de> writes:

> Call fb_deferred_io_cleanup() upon destroying the framebuffer
> device. Releases the internal memory.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred I/O")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> ---
>  drivers/gpu/drm/drm_fbdev_dma.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Thomas Zimmermann May 15, 2024, 12:55 p.m. UTC | #2 
Am 15.05.24 um 13:59 schrieb Javier Martinez Canillas:
> Thomas Zimmermann <tzimmermann@suse.de> writes:
>
>> Call fb_deferred_io_cleanup() upon destroying the framebuffer
>> device. Releases the internal memory.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>> Fixes: 808a40b69468 ("drm/fbdev-dma: Implement damage handling and deferred I/O")
>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>> Cc: Javier Martinez Canillas <javierm@redhat.com>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Cc: Maxime Ripard <mripard@kernel.org>
>> ---
>>   drivers/gpu/drm/drm_fbdev_dma.c | 1 +
>>   1 file changed, 1 insertion(+)
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

Thanks a lot. I've pushed this patch and the other one to drm-misc-next.

>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
index 5eeb5164e9e2b..97ef6300d47e0 100644
--- a/drivers/gpu/drm/drm_fbdev_dma.c
+++ b/drivers/gpu/drm/drm_fbdev_dma.c
@@ -59,6 +59,7 @@  static void drm_fbdev_dma_fb_destroy(struct fb_info *info)
 	if (!fb_helper->dev)
 		return;
 
+	fb_deferred_io_cleanup(info);
 	drm_fb_helper_fini(fb_helper);
 
 	drm_client_buffer_vunmap(fb_helper->buffer);