| Message ID | 20240515-dma-buf-ecc-heap-v1-3-54cbbd049511@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dma-buf: heaps: Support carved-out heaps and ECC related-flags | expand |
Am 15.05.24 um 15:56 schrieb Maxime Ripard: > The uAPI header has a bunch of constants and structures that might be > handy in drivers. > > Let's include the header in the driver-side dma-heap header. Well as long as this header doesn't need any symbols from the uAPI itself I think that is a no-go. Includes should only be applied for things which are really necessary and not because some driver might need it. Regards, Christian. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- > include/linux/dma-heap.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/dma-heap.h b/include/linux/dma-heap.h > index 0c05561cad6e..e7cf110c5fdc 100644 > --- a/include/linux/dma-heap.h > +++ b/include/linux/dma-heap.h > @@ -10,10 +10,12 @@ > #define _DMA_HEAPS_H > > #include <linux/cdev.h> > #include <linux/types.h> > > +#include <uapi/linux/dma-heap.h> > + > struct dma_heap; > > /** > * struct dma_heap_ops - ops to operate on a given heap > * @allocate: allocate dmabuf and return struct dma_buf ptr >
diff --git a/include/linux/dma-heap.h b/include/linux/dma-heap.h index 0c05561cad6e..e7cf110c5fdc 100644 --- a/include/linux/dma-heap.h +++ b/include/linux/dma-heap.h @@ -10,10 +10,12 @@ #define _DMA_HEAPS_H #include <linux/cdev.h> #include <linux/types.h> +#include <uapi/linux/dma-heap.h> + struct dma_heap; /** * struct dma_heap_ops - ops to operate on a given heap * @allocate: allocate dmabuf and return struct dma_buf ptr
The uAPI header has a bunch of constants and structures that might be handy in drivers. Let's include the header in the driver-side dma-heap header. Signed-off-by: Maxime Ripard <mripard@kernel.org> --- include/linux/dma-heap.h | 2 ++ 1 file changed, 2 insertions(+)