| Message ID | 4fba8ba903d32bba3f8f92db50823fd7aea38bc4.1715831939.git.anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs-progs: tune: fix btrfstune --help for -m -M option | expand |
在 2024/5/16 13:49, Anand Jain 写道: > The -m | -M option for the btrfstune, sounds like metadata_uuid is being > changed which is wrong, the fsid is being changed the original fsid is > being copied into the metadata_uuid. So update the help. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > --- > tune/main.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/tune/main.c b/tune/main.c > index cfb5b5d6e323..7ae48fe6e80b 100644 > --- a/tune/main.c > +++ b/tune/main.c > @@ -113,8 +113,12 @@ static const char * const tune_usage[] = { > "UUID changes:", > OPTLINE("-u", "rewrite fsid, use a random one"), > OPTLINE("-U UUID", "rewrite fsid to UUID"), > - OPTLINE("-m", "change fsid in metadata_uuid to a random UUID incompat change, more lightweight than -u|-U)"), > - OPTLINE("-M UUID", "change fsid in metadata_uuid to UUID"), > + OPTLINE("-m", "change fsid to a random UUID, copy original fsid into " > + "metadata_uuid if it's not NULL. Incompat change " > + "(more lightweight than -u|-U)"), > + OPTLINE("-M UUID", "change fsid to UUID, copy original fsid into " > + "metadata_uuid if it's not NULL. Incompat change " > + "(more lightweight than -u|-U)"), > "", > "General:", > OPTLINE("-f", "allow dangerous operations, make sure that you are aware of the dangers"),
On Thu, May 16, 2024 at 12:19:03PM +0800, Anand Jain wrote: > The -m | -M option for the btrfstune, sounds like metadata_uuid is being > changed which is wrong, the fsid is being changed the original fsid is > being copied into the metadata_uuid. So update the help. > > Signed-off-by: Anand Jain <anand.jain@oracle.com> Added to devel, thanks.
diff --git a/tune/main.c b/tune/main.c index cfb5b5d6e323..7ae48fe6e80b 100644 --- a/tune/main.c +++ b/tune/main.c @@ -113,8 +113,12 @@ static const char * const tune_usage[] = { "UUID changes:", OPTLINE("-u", "rewrite fsid, use a random one"), OPTLINE("-U UUID", "rewrite fsid to UUID"), - OPTLINE("-m", "change fsid in metadata_uuid to a random UUID incompat change, more lightweight than -u|-U)"), - OPTLINE("-M UUID", "change fsid in metadata_uuid to UUID"), + OPTLINE("-m", "change fsid to a random UUID, copy original fsid into " + "metadata_uuid if it's not NULL. Incompat change " + "(more lightweight than -u|-U)"), + OPTLINE("-M UUID", "change fsid to UUID, copy original fsid into " + "metadata_uuid if it's not NULL. Incompat change " + "(more lightweight than -u|-U)"), "", "General:", OPTLINE("-f", "allow dangerous operations, make sure that you are aware of the dangers"),
The -m | -M option for the btrfstune, sounds like metadata_uuid is being changed which is wrong, the fsid is being changed the original fsid is being copied into the metadata_uuid. So update the help. Signed-off-by: Anand Jain <anand.jain@oracle.com> --- tune/main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)