| Message ID | 20240511153051.1355825-3-a-bhatia1@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: cdns-dsi: Fix the color-shift issue | expand |
On Sat, May 11, 2024 at 09:00:46PM +0530, Aradhya Bhatia wrote: > Update the Phy initialized state to "not initialized" when the driver > (and the hardware by extension) gets suspended. This will allow the Phy > to get initialized again after resume. > > Fix the OF node that gets passed to find the next available bridge in > the display pipeline. > > Fix the order of DSI Link and DSI Phy inits. The link init needs to > happen before the Phy is initialized, so the Phy can lock on the > incoming PLL reference clock. If this doesn't happen, the Phy cannot > lock (until DSI Link is init later on). This causes a warning dump > during the kernel boot. > > Allow the D-Phy config checks to use mode->clock instead of > mode->crtc_clock during mode_valid checks, like everywhere else in the > driver. All these should be in separate patches. Maxime
On 16/05/24 13:41, Maxime Ripard wrote: > On Sat, May 11, 2024 at 09:00:46PM +0530, Aradhya Bhatia wrote: >> Update the Phy initialized state to "not initialized" when the driver >> (and the hardware by extension) gets suspended. This will allow the Phy >> to get initialized again after resume. >> >> Fix the OF node that gets passed to find the next available bridge in >> the display pipeline. >> >> Fix the order of DSI Link and DSI Phy inits. The link init needs to >> happen before the Phy is initialized, so the Phy can lock on the >> incoming PLL reference clock. If this doesn't happen, the Phy cannot >> lock (until DSI Link is init later on). This causes a warning dump >> during the kernel boot. >> >> Allow the D-Phy config checks to use mode->clock instead of >> mode->crtc_clock during mode_valid checks, like everywhere else in the >> driver. > > All these should be in separate patches. > Alright! I will split them into different patches in v2. Regards Aradhya
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 7457d38622b0..557b037bbc67 100644 --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c @@ -574,7 +574,7 @@ static int cdns_dsi_check_conf(struct cdns_dsi *dsi, if (ret) return ret; - phy_mipi_dphy_get_default_config(mode->crtc_clock * 1000, + phy_mipi_dphy_get_default_config((mode_valid_check ? mode->clock : mode->crtc_clock) * 1000, mipi_dsi_pixel_format_to_bpp(output->dev->format), nlanes, phy_cfg); @@ -775,8 +775,8 @@ static void cdns_dsi_bridge_enable(struct drm_bridge *bridge) WARN_ON_ONCE(cdns_dsi_check_conf(dsi, mode, &dsi_cfg, false)); - cdns_dsi_hs_init(dsi); cdns_dsi_init_link(dsi); + cdns_dsi_hs_init(dsi); writel(HBP_LEN(dsi_cfg.hbp) | HSA_LEN(dsi_cfg.hsa), dsi->regs + VID_HSIZE1); @@ -952,7 +952,7 @@ static int cdns_dsi_attach(struct mipi_dsi_host *host, bridge = drm_panel_bridge_add_typed(panel, DRM_MODE_CONNECTOR_DSI); } else { - bridge = of_drm_find_bridge(dev->dev.of_node); + bridge = of_drm_find_bridge(np); if (!bridge) bridge = ERR_PTR(-EINVAL); } @@ -1153,6 +1153,7 @@ static int __maybe_unused cdns_dsi_suspend(struct device *dev) clk_disable_unprepare(dsi->dsi_p_clk); reset_control_assert(dsi->dsi_p_rst); dsi->link_initialized = false; + dsi->phy_initialized = false; return 0; }
Update the Phy initialized state to "not initialized" when the driver (and the hardware by extension) gets suspended. This will allow the Phy to get initialized again after resume. Fix the OF node that gets passed to find the next available bridge in the display pipeline. Fix the order of DSI Link and DSI Phy inits. The link init needs to happen before the Phy is initialized, so the Phy can lock on the incoming PLL reference clock. If this doesn't happen, the Phy cannot lock (until DSI Link is init later on). This causes a warning dump during the kernel boot. Allow the D-Phy config checks to use mode->clock instead of mode->crtc_clock during mode_valid checks, like everywhere else in the driver. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Aradhya Bhatia <a-bhatia1@ti.com> --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)