| Message ID | 20240515075548.852777-1-srinuvasan.a@siemens.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [isar-cip-core] kas/opt/expand-on-first-boot.yml: add an optional expand-on-first-boot | expand |
On 15.05.24 09:55, srinuvasan.a@siemens.com wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > Add expand-on-first-boot package as an optional file, > this systemd service expands the last partition on a the > boot medium to the full size of that medium and then deactivates itself. > So, what should this tell us? Given the complexity of the changes below, the text above does not add information. At the same time, it contains no information about WHY we want this change. Jan > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > kas/opt/expand-on-first-boot.yml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 kas/opt/expand-on-first-boot.yml > > diff --git a/kas/opt/expand-on-first-boot.yml b/kas/opt/expand-on-first-boot.yml > new file mode 100644 > index 0000000..03d666b > --- /dev/null > +++ b/kas/opt/expand-on-first-boot.yml > @@ -0,0 +1,17 @@ > +# > +# CIP Core, generic profile > +# > +# Copyright (c) Siemens AG, 2024 > +# > +# Authors: > +# Srinuvasan Arjunan <srinuvasan.a@siemens.com> > +# > +# SPDX-License-Identifier: MIT > +# > + > +header: > + version: 14 > + > +local_conf_header: > + package-expand-on-first-boot: | > + IMAGE_INSTALL:append = " expand-on-first-boot"
Hi Jan, Cip-core already has the encryption support, if anyone interested how expand-on-first boot works for encrypted partition, cip-core is the right place to do the analyse/fix, Purely this I brought for understanding purposes of how expand-on-first-boot works with the encrypted filesystem. Many thanks, Srinu -----Original Message----- From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com> Sent: 16 May 2024 00:03 To: Arjunan, Srinu (DI CTO FDS CES LX PBU 2) <srinuvasan.a@siemens.com>; cip-dev@lists.cip-project.org Subject: Re: [PATCH][isar-cip-core] kas/opt/expand-on-first-boot.yml: add an optional expand-on-first-boot On 15.05.24 09:55, srinuvasan.a@siemens.com wrote: > From: Srinuvasan A <srinuvasan.a@siemens.com> > > Add expand-on-first-boot package as an optional file, this systemd > service expands the last partition on a the boot medium to the full > size of that medium and then deactivates itself. > So, what should this tell us? Given the complexity of the changes below, the text above does not add information. At the same time, it contains no information about WHY we want this change. Jan > Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> > --- > kas/opt/expand-on-first-boot.yml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 kas/opt/expand-on-first-boot.yml > > diff --git a/kas/opt/expand-on-first-boot.yml > b/kas/opt/expand-on-first-boot.yml > new file mode 100644 > index 0000000..03d666b > --- /dev/null > +++ b/kas/opt/expand-on-first-boot.yml > @@ -0,0 +1,17 @@ > +# > +# CIP Core, generic profile > +# > +# Copyright (c) Siemens AG, 2024 > +# > +# Authors: > +# Srinuvasan Arjunan <srinuvasan.a@siemens.com> # # > +SPDX-License-Identifier: MIT # > + > +header: > + version: 14 > + > +local_conf_header: > + package-expand-on-first-boot: | > + IMAGE_INSTALL:append = " expand-on-first-boot" -- Siemens AG, Technology Linux Expert Center
On 16.05.24 12:57, Arjunan, Srinu (DI CTO FDS CES LX PBU 2) wrote: > Hi Jan, > > Cip-core already has the encryption support, if anyone interested how expand-on-first boot works for encrypted partition, cip-core is the right place to do the analyse/fix, Purely this I brought for understanding purposes of how expand-on-first-boot works with the encrypted filesystem. > OK, I'm starting to understand a bit of your intention. But there are still open questions: - Why this should be implemented here permanently? - If there is a reason beyond your experiment, then how should this be discovered by others (no kconfig menu entry)? - And do we want to add this to CI? You commit message should explain this and demonstrate that you thought this through. Jan > > Many thanks, > Srinu > > -----Original Message----- > From: Kiszka, Jan (T CED) <jan.kiszka@siemens.com> > Sent: 16 May 2024 00:03 > To: Arjunan, Srinu (DI CTO FDS CES LX PBU 2) <srinuvasan.a@siemens.com>; cip-dev@lists.cip-project.org > Subject: Re: [PATCH][isar-cip-core] kas/opt/expand-on-first-boot.yml: add an optional expand-on-first-boot > > On 15.05.24 09:55, srinuvasan.a@siemens.com wrote: >> From: Srinuvasan A <srinuvasan.a@siemens.com> >> >> Add expand-on-first-boot package as an optional file, this systemd >> service expands the last partition on a the boot medium to the full >> size of that medium and then deactivates itself. >> > > So, what should this tell us? Given the complexity of the changes below, the text above does not add information. At the same time, it contains no information about WHY we want this change. > > Jan > >> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com> >> --- >> kas/opt/expand-on-first-boot.yml | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 kas/opt/expand-on-first-boot.yml >> >> diff --git a/kas/opt/expand-on-first-boot.yml >> b/kas/opt/expand-on-first-boot.yml >> new file mode 100644 >> index 0000000..03d666b >> --- /dev/null >> +++ b/kas/opt/expand-on-first-boot.yml >> @@ -0,0 +1,17 @@ >> +# >> +# CIP Core, generic profile >> +# >> +# Copyright (c) Siemens AG, 2024 >> +# >> +# Authors: >> +# Srinuvasan Arjunan <srinuvasan.a@siemens.com> # # >> +SPDX-License-Identifier: MIT # >> + >> +header: >> + version: 14 >> + >> +local_conf_header: >> + package-expand-on-first-boot: | >> + IMAGE_INSTALL:append = " expand-on-first-boot" > > -- > Siemens AG, Technology > Linux Expert Center >
diff --git a/kas/opt/expand-on-first-boot.yml b/kas/opt/expand-on-first-boot.yml new file mode 100644 index 0000000..03d666b --- /dev/null +++ b/kas/opt/expand-on-first-boot.yml @@ -0,0 +1,17 @@ +# +# CIP Core, generic profile +# +# Copyright (c) Siemens AG, 2024 +# +# Authors: +# Srinuvasan Arjunan <srinuvasan.a@siemens.com> +# +# SPDX-License-Identifier: MIT +# + +header: + version: 14 + +local_conf_header: + package-expand-on-first-boot: | + IMAGE_INSTALL:append = " expand-on-first-boot"