| Message ID | 20240401100058.15749-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: PCI: rockchip,rk3399-pcie: add missing maxItems to ep-gpios | expand |
On Mon, Apr 01, 2024 at 12:00:58PM +0200, Krzysztof Kozlowski wrote: > Properties with GPIOs should define number of actual GPIOs, so add > missing maxItems to ep-gpios. Otherwise multiple GPIOs could be > provided which is not a true hardware description. > > Fixes: aa222f9311e1 ("dt-bindings: PCI: Convert Rockchip RK3399 PCIe to DT schema") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
On Mon, 01 Apr 2024 12:00:58 +0200, Krzysztof Kozlowski wrote: > Properties with GPIOs should define number of actual GPIOs, so add > missing maxItems to ep-gpios. Otherwise multiple GPIOs could be > provided which is not a true hardware description. > > Fixes: aa222f9311e1 ("dt-bindings: PCI: Convert Rockchip RK3399 PCIe to DT schema") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 1 + > 1 file changed, 1 insertion(+) > Applied, thanks!
Hello, > Properties with GPIOs should define number of actual GPIOs, so add > missing maxItems to ep-gpios. Otherwise multiple GPIOs could be > provided which is not a true hardware description. Applied to dt-bindings, thank you! [1/1] dt-bindings: PCI: rockchip,rk3399-pcie: Add missing maxItems to ep-gpios https://git.kernel.org/pci/pci/c/52d06636a4ae Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml index 531008f0b6ac..002b728cbc71 100644 --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml @@ -37,6 +37,7 @@ properties: description: This property is needed if using 24MHz OSC for RC's PHY. ep-gpios: + maxItems: 1 description: pre-reset GPIO vpcie12v-supply:
Properties with GPIOs should define number of actual GPIOs, so add missing maxItems to ep-gpios. Otherwise multiple GPIOs could be provided which is not a true hardware description. Fixes: aa222f9311e1 ("dt-bindings: PCI: Convert Rockchip RK3399 PCIe to DT schema") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie.yaml | 1 + 1 file changed, 1 insertion(+)