diff mbox series

drm/edid: add non-desktop quirk to Bigscreen Beyond HMD

Message ID 20240517105555.654262-1-contact@scrumplex.net (mailing list archive)
State New, archived
Headers show
Series drm/edid: add non-desktop quirk to Bigscreen Beyond HMD | expand

Commit Message

Sefa Eyeoglu May 17, 2024, 10:55 a.m. UTC
The Bigscreen Beyond VR headset is a non-desktop output and should be
marked as such using an EDID quirk.

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
---
 drivers/gpu/drm/drm_edid.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jani Nikula May 17, 2024, 12:54 p.m. UTC | #1
On Fri, 17 May 2024, Sefa Eyeoglu <contact@scrumplex.net> wrote:
> The Bigscreen Beyond VR headset is a non-desktop output and should be
> marked as such using an EDID quirk.

I'd appreciate a bug being filed at [1], attaching the EDID of the panel
there, maybe dmesg with drm.debug=14 enabled too, and referencing the
bug in the commit message. It gets terribly hard to figure anything out
about the quirks afterwards when some time has passed.

Thanks,
Jani.



[1] https://gitlab.freedesktop.org/drm/misc/kernel/-/issues

>
> Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
> ---
>  drivers/gpu/drm/drm_edid.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 4f54c91b31b2..d407efc0fb55 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -200,6 +200,9 @@ static const struct edid_quirk {
>  	/* Rotel RSX-1058 forwards sink's EDID but only does HDMI 1.1*/
>  	EDID_QUIRK('E', 'T', 'R', 13896, EDID_QUIRK_FORCE_8BPC),
>  
> +	/* Bigscreen Beyond Headset */
> +	EDID_QUIRK('B', 'I', 'G', 0x1234, EDID_QUIRK_NON_DESKTOP),
> +
>  	/* Valve Index Headset */
>  	EDID_QUIRK('V', 'L', 'V', 0x91a8, EDID_QUIRK_NON_DESKTOP),
>  	EDID_QUIRK('V', 'L', 'V', 0x91b0, EDID_QUIRK_NON_DESKTOP),
Sefa Eyeoglu May 17, 2024, 2:14 p.m. UTC | #2
Hi Jani,

I have just just posted a modified patch with a link to the issue.

Best,
Sefa

On Fri, 2024-05-17 at 15:54 +0300, Jani Nikula wrote:
> On Fri, 17 May 2024, Sefa Eyeoglu <contact@scrumplex.net> wrote:
> > The Bigscreen Beyond VR headset is a non-desktop output and should
> > be
> > marked as such using an EDID quirk.
> 
> I'd appreciate a bug being filed at [1], attaching the EDID of the
> panel
> there, maybe dmesg with drm.debug=14 enabled too, and referencing the
> bug in the commit message. It gets terribly hard to figure anything
> out
> about the quirks afterwards when some time has passed.
> 
> Thanks,
> Jani.
> 
> 
> 
> [1] https://gitlab.freedesktop.org/drm/misc/kernel/-/issues
> 
> > 
> > Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
> > ---
> >  drivers/gpu/drm/drm_edid.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_edid.c
> > b/drivers/gpu/drm/drm_edid.c
> > index 4f54c91b31b2..d407efc0fb55 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -200,6 +200,9 @@ static const struct edid_quirk {
> >  	/* Rotel RSX-1058 forwards sink's EDID but only does HDMI
> > 1.1*/
> >  	EDID_QUIRK('E', 'T', 'R', 13896, EDID_QUIRK_FORCE_8BPC),
> >  
> > +	/* Bigscreen Beyond Headset */
> > +	EDID_QUIRK('B', 'I', 'G', 0x1234, EDID_QUIRK_NON_DESKTOP),
> > +
> >  	/* Valve Index Headset */
> >  	EDID_QUIRK('V', 'L', 'V', 0x91a8, EDID_QUIRK_NON_DESKTOP),
> >  	EDID_QUIRK('V', 'L', 'V', 0x91b0, EDID_QUIRK_NON_DESKTOP),
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 4f54c91b31b2..d407efc0fb55 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -200,6 +200,9 @@  static const struct edid_quirk {
 	/* Rotel RSX-1058 forwards sink's EDID but only does HDMI 1.1*/
 	EDID_QUIRK('E', 'T', 'R', 13896, EDID_QUIRK_FORCE_8BPC),
 
+	/* Bigscreen Beyond Headset */
+	EDID_QUIRK('B', 'I', 'G', 0x1234, EDID_QUIRK_NON_DESKTOP),
+
 	/* Valve Index Headset */
 	EDID_QUIRK('V', 'L', 'V', 0x91a8, EDID_QUIRK_NON_DESKTOP),
 	EDID_QUIRK('V', 'L', 'V', 0x91b0, EDID_QUIRK_NON_DESKTOP),