| Message ID | 20240520181439.1407634-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 25d3b629e4df3be30463750d46b843a78464983f |
| Headers | show |
| Series | [BlueZ,v2,1/3] device: Add btd_device_get_icon | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 20 May 2024 14:14:37 -0400 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This adds btd_device_get_icon which can be used to retriev the icon > string of a device object. > --- > src/device.c | 12 +++++------- > src/device.h | 1 + > 2 files changed, 6 insertions(+), 7 deletions(-) Here is the summary with links: - [BlueZ,v2,1/3] device: Add btd_device_get_icon https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=25d3b629e4df - [BlueZ,v2,2/3] hog-lib: Add force parameter to bt_hog_detach https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=db383a5b4a8d - [BlueZ,v2,3/3] shared/uhid: Add special handling for non-keyboards https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e4f6c68f2a4d You are awesome, thank you!
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=854479 ---Test result--- Test Summary: CheckPatch PASS 2.04 seconds GitLint PASS 1.00 seconds BuildEll PASS 25.00 seconds BluezMake PASS 1721.03 seconds MakeCheck PASS 13.21 seconds MakeDistcheck PASS 177.47 seconds CheckValgrind PASS 248.07 seconds CheckSmatch PASS 352.51 seconds bluezmakeextell PASS 119.33 seconds IncrementalBuild PASS 4586.72 seconds ScanBuild PASS 1004.39 seconds --- Regards, Linux Bluetooth
diff --git a/src/device.c b/src/device.c index 79d8bb7ebc9b..620bbd55ebad 100644 --- a/src/device.c +++ b/src/device.c @@ -1052,16 +1052,14 @@ static gboolean dev_property_get_appearance(const GDBusPropertyTable *property, return TRUE; } -static const char *get_icon(const GDBusPropertyTable *property, void *data) +const char *btd_device_get_icon(struct btd_device *device) { - struct btd_device *device = data; const char *icon = NULL; - uint16_t appearance; if (device->class != 0) icon = class_to_icon(device->class); - else if (get_appearance(property, data, &appearance)) - icon = gap_appearance_to_icon(appearance); + else if (device->appearance != 0) + icon = gap_appearance_to_icon(device->appearance); return icon; } @@ -1069,7 +1067,7 @@ static const char *get_icon(const GDBusPropertyTable *property, void *data) static gboolean dev_property_exists_icon( const GDBusPropertyTable *property, void *data) { - return get_icon(property, data) != NULL; + return btd_device_get_icon(data) != NULL; } static gboolean dev_property_get_icon(const GDBusPropertyTable *property, @@ -1077,7 +1075,7 @@ static gboolean dev_property_get_icon(const GDBusPropertyTable *property, { const char *icon; - icon = get_icon(property, data); + icon = btd_device_get_icon(data); if (icon == NULL) return FALSE; diff --git a/src/device.h b/src/device.h index 1a9f7e72a00f..a2b7bb15d200 100644 --- a/src/device.h +++ b/src/device.h @@ -41,6 +41,7 @@ uint16_t btd_device_get_vendor(struct btd_device *device); uint16_t btd_device_get_vendor_src(struct btd_device *device); uint16_t btd_device_get_product(struct btd_device *device); uint16_t btd_device_get_version(struct btd_device *device); +const char *btd_device_get_icon(struct btd_device *device); void device_remove_bonding(struct btd_device *device, uint8_t bdaddr_type); void device_remove(struct btd_device *device, gboolean remove_stored); int device_address_cmp(gconstpointer a, gconstpointer b);
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> This adds btd_device_get_icon which can be used to retriev the icon string of a device object. --- src/device.c | 12 +++++------- src/device.h | 1 + 2 files changed, 6 insertions(+), 7 deletions(-)