| Message ID | cover.1716399081.git.jani.nikula@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: identify all platforms in display probe | expand |
Quoting Jani Nikula (2024-05-22 14:33:37-03:00) >Add independent platform probe in display, in preparation for breaking >free from i915 and xe code. > >Up next would be adding separate IS_<PLATFORM>() style macros to >display. Not included here, because I couldn't come up with nice names >yet. IS_DISPLAY_<PLATFORM>() is a bit verbose. Drive-by comment: At least for recent hardware, we can use display-specific release names, e.g. IS_XE2LPD() for LNL's display, since theoretically that display IP could be reused in a different platform. -- Gustavo Sousa > >BR, >Jani. > >Jani Nikula (10): > drm/i915/display: move params copy at probe earlier > drm/i915/display: change probe for no display case > drm/i915/display: check platforms without display one level higher > drm/i915/display: change GMD ID display ip ver propagation at probe > drm/i915/display: add platform descriptors > drm/i915: add LNL PCI IDs > drm/i915/display: change display probe to identify GMD ID based > platforms > drm/i915/display: identify platforms with enum and name > drm/i915/display: add support for subplatforms > drm/i915/display: add probe message > > .../drm/i915/display/intel_display_device.c | 920 ++++++++++++------ > .../drm/i915/display/intel_display_device.h | 86 +- > include/drm/i915_pciids.h | 6 + > 3 files changed, 731 insertions(+), 281 deletions(-) > >-- >2.39.2 >
On Wed, 22 May 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote: > Quoting Jani Nikula (2024-05-22 14:33:37-03:00) >>Add independent platform probe in display, in preparation for breaking >>free from i915 and xe code. >> >>Up next would be adding separate IS_<PLATFORM>() style macros to >>display. Not included here, because I couldn't come up with nice names >>yet. IS_DISPLAY_<PLATFORM>() is a bit verbose. > > Drive-by comment: At least for recent hardware, we can use > display-specific release names, e.g. IS_XE2LPD() for LNL's display, > since theoretically that display IP could be reused in a different > platform. I think we should prefer the IP version checks over adding names like xe2lpd which IMO are hard to remember and associate with platforms or IP versions. And we'll still need the platform checks for a plethora of old platforms. BR, Jani.
On Wed, May 22, 2024 at 09:36:40PM +0300, Jani Nikula wrote: > On Wed, 22 May 2024, Gustavo Sousa <gustavo.sousa@intel.com> wrote: > > Quoting Jani Nikula (2024-05-22 14:33:37-03:00) > >>Add independent platform probe in display, in preparation for breaking > >>free from i915 and xe code. > >> > >>Up next would be adding separate IS_<PLATFORM>() style macros to > >>display. Not included here, because I couldn't come up with nice names > >>yet. IS_DISPLAY_<PLATFORM>() is a bit verbose. > > > > Drive-by comment: At least for recent hardware, we can use > > display-specific release names, e.g. IS_XE2LPD() for LNL's display, > > since theoretically that display IP could be reused in a different > > platform. > > I think we should prefer the IP version checks over adding names like > xe2lpd which IMO are hard to remember and associate with platforms or IP > versions. yeap, but perhaps we will need something like that anyway, because the mix and match from different platforms using same IP block or even the possibility of the same platform but different skus using different IP blocks. :/ > > And we'll still need the platform checks for a plethora of old > platforms. What about DISP_<PLATFORM> ? or <PLATFORM>_DISP ? or even DISPLAY_<PLATFORM> or <PLATFORM>_DISPLAY, but definitely getting rid of the extra 'IS'... > > > BR, > Jani. > > > -- > Jani Nikula, Intel
On Wed, 22 May 2024, Jani Nikula <jani.nikula@intel.com> wrote: > Add independent platform probe in display, in preparation for breaking > free from i915 and xe code. Merged to din, thanks for the review. BR, Jani.
Add independent platform probe in display, in preparation for breaking free from i915 and xe code. Up next would be adding separate IS_<PLATFORM>() style macros to display. Not included here, because I couldn't come up with nice names yet. IS_DISPLAY_<PLATFORM>() is a bit verbose. BR, Jani. Jani Nikula (10): drm/i915/display: move params copy at probe earlier drm/i915/display: change probe for no display case drm/i915/display: check platforms without display one level higher drm/i915/display: change GMD ID display ip ver propagation at probe drm/i915/display: add platform descriptors drm/i915: add LNL PCI IDs drm/i915/display: change display probe to identify GMD ID based platforms drm/i915/display: identify platforms with enum and name drm/i915/display: add support for subplatforms drm/i915/display: add probe message .../drm/i915/display/intel_display_device.c | 920 ++++++++++++------ .../drm/i915/display/intel_display_device.h | 86 +- include/drm/i915_pciids.h | 6 + 3 files changed, 731 insertions(+), 281 deletions(-)