| Message ID | 20240523203130.75681-1-mezin.alexander@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | hwmon: (nzxt-smart2) add another USB ID | expand |
On 5/23/24 13:31, Aleksandr Mezin wrote: > Fan speed control reported to be working with existing userspace (hidraw) > software, so I assume it's compatible. Fan channel count is the same. No known > differences from already supported devices, at least regarding fan speed > control and initialization. > > Discovered in liquidctl project: > > https://github.com/liquidctl/liquidctl/pull/702 > That is not an appropriate commit description. Guenter > Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com> > Cc: stable@vger.kernel.org # v6.1+ > --- > drivers/hwmon/nzxt-smart2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c > index 7aa586eb74be..df6fa72a6b59 100644 > --- a/drivers/hwmon/nzxt-smart2.c > +++ b/drivers/hwmon/nzxt-smart2.c > @@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = { > { HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */ > { HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */ > { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */ > + { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */ > {}, > }; >
I'm sorry, I don't understand what exactly is wrong with the description. Especially because patches with similar descriptions were accepted before. On Fri, May 24, 2024 at 12:47 AM Guenter Roeck <linux@roeck-us.net> wrote: > > On 5/23/24 13:31, Aleksandr Mezin wrote: > > Fan speed control reported to be working with existing userspace (hidraw) > > software, so I assume it's compatible. Fan channel count is the same. No known > > differences from already supported devices, at least regarding fan speed > > control and initialization. > > > > Discovered in liquidctl project: > > > > https://github.com/liquidctl/liquidctl/pull/702 > > > > That is not an appropriate commit description. > > Guenter > > > Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com> > > Cc: stable@vger.kernel.org # v6.1+ > > --- > > drivers/hwmon/nzxt-smart2.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c > > index 7aa586eb74be..df6fa72a6b59 100644 > > --- a/drivers/hwmon/nzxt-smart2.c > > +++ b/drivers/hwmon/nzxt-smart2.c > > @@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = { > > { HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */ > > { HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */ > > { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */ > > + { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */ > > {}, > > }; > > >
On 5/23/24 16:34, Aleksandr Mezin wrote: > I'm sorry, I don't understand what exactly is wrong with the > description. Especially because patches with similar descriptions were > accepted before. > See Documentation/process/submitting-patches.rst, "Describe your changes" And thanks for pointing out that I am not perfect. Guenter
diff --git a/drivers/hwmon/nzxt-smart2.c b/drivers/hwmon/nzxt-smart2.c index 7aa586eb74be..df6fa72a6b59 100644 --- a/drivers/hwmon/nzxt-smart2.c +++ b/drivers/hwmon/nzxt-smart2.c @@ -799,6 +799,7 @@ static const struct hid_device_id nzxt_smart2_hid_id_table[] = { { HID_USB_DEVICE(0x1e71, 0x2010) }, /* NZXT RGB & Fan Controller */ { HID_USB_DEVICE(0x1e71, 0x2011) }, /* NZXT RGB & Fan Controller (6 RGB) */ { HID_USB_DEVICE(0x1e71, 0x2019) }, /* NZXT RGB & Fan Controller (6 RGB) */ + { HID_USB_DEVICE(0x1e71, 0x2020) }, /* NZXT RGB & Fan Controller (6 RGB) */ {}, };
Fan speed control reported to be working with existing userspace (hidraw) software, so I assume it's compatible. Fan channel count is the same. No known differences from already supported devices, at least regarding fan speed control and initialization. Discovered in liquidctl project: https://github.com/liquidctl/liquidctl/pull/702 Signed-off-by: Aleksandr Mezin <mezin.alexander@gmail.com> Cc: stable@vger.kernel.org # v6.1+ --- drivers/hwmon/nzxt-smart2.c | 1 + 1 file changed, 1 insertion(+)