Message ID | 871q5tnuok.wl-kuninori.morimoto.gx@renesas.com (mailing list archive) |
---|---|
Headers | show |
Series | ASoC: grace time for DPCM cleanup | expand |
Hi Morimoto-san, > This is v4 of DPCM cleanup > > As we discussed in [1], we don't need to use dpcm_playback/capture flag, > so we remove it. But we have been using it for 10 years, some driver might > get damage. The most likely case is that the device/driver can use both > playback/capture, but have only one flag, and not using xxx_only flag. > [1/3] patch indicates warning in such case. > > These adds grace time for DPCM cleanup. > I'm not sure when dpcm_xxx will be removed, and Codec check bypass will be > error, but maybe v6.11 or v6.12 ? We're already finding warnings on all Intel SoundWire platforms: The DAIs are declared as supporting playback AND capture, but in practice they can only support one direction at a time. The direction is defined by the dailink when it includes specific DAIs. So if you don't mind I'd prefer it if we shared a patch with you to be included in a v5, to make sure at least the Intel platforms tested in CI are all ok from Day1, otherwise we're going to get lots of noise reported for no good reason. Shouldn't take long.
Hi Pierre-Louis > We're already finding warnings on all Intel SoundWire platforms: > > The DAIs are declared as supporting playback AND capture, but in > practice they can only support one direction at a time. > > The direction is defined by the dailink when it includes specific DAIs. > > So if you don't mind I'd prefer it if we shared a patch with you to be > included in a v5, to make sure at least the Intel platforms tested in CI > are all ok from Day1, otherwise we're going to get lots of noise > reported for no good reason. > Shouldn't take long. Thank you for reporting. OK, no problem. I will fixup pointed typo, and merge your patches into v5. Thank you for your help !! Best regards --- Renesas Electronics Ph.D. Kuninori Morimoto