| Message ID | 6bab1449c01c4537aa2d9cb4481e1d5da8aa2389.1714546173.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5128de84d8fc849400d00f7a6982711f129699ea |
| Headers | show |
| Series | Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb | expand |
Hello: This patch was applied to chrome-platform/linux.git (for-kernelci) by Dmitry Torokhov <dmitry.torokhov@gmail.com>: On Wed, 1 May 2024 08:49:47 +0200 you wrote: > In "struct cros_ec_keyb", the 'keymap_data' field is unused. > Remove it. > > Found with cppcheck, unusedStructMember. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > [...] Here is the summary with links: - Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb https://git.kernel.org/chrome-platform/c/5128de84d8fc You are awesome, thank you!
Hello: This patch was applied to chrome-platform/linux.git (for-next) by Dmitry Torokhov <dmitry.torokhov@gmail.com>: On Wed, 1 May 2024 08:49:47 +0200 you wrote: > In "struct cros_ec_keyb", the 'keymap_data' field is unused. > Remove it. > > Found with cppcheck, unusedStructMember. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > [...] Here is the summary with links: - Input: cros_ec_keyb - Remove an unused field in struct cros_ec_keyb https://git.kernel.org/chrome-platform/c/5128de84d8fc You are awesome, thank you!
diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index 30678a34cf64..12eb9df180ee 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c @@ -35,7 +35,6 @@ * @rows: Number of rows in the keypad * @cols: Number of columns in the keypad * @row_shift: log2 or number of rows, rounded up - * @keymap_data: Matrix keymap data used to convert to keyscan values * @ghost_filter: true to enable the matrix key-ghosting filter * @valid_keys: bitmap of existing keys for each matrix column * @old_kb_state: bitmap of keys pressed last scan @@ -50,7 +49,6 @@ struct cros_ec_keyb { unsigned int rows; unsigned int cols; int row_shift; - const struct matrix_keymap_data *keymap_data; bool ghost_filter; uint8_t *valid_keys; uint8_t *old_kb_state;
In "struct cros_ec_keyb", the 'keymap_data' field is unused. Remove it. Found with cppcheck, unusedStructMember. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only. It was added in the initial commit 6af6dc2d2aa6 ("input: Add ChromeOS EC keyboard driver") but was never used. --- drivers/input/keyboard/cros_ec_keyb.c | 2 -- 1 file changed, 2 deletions(-)