| Message ID | 20240522150141.1776196-1-adureghello@baylibre.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | minor fixes and improvements | expand |
On Wed, 2024-05-22 at 17:01 +0200, Angelo Dureghello wrote: > From: Angelo Dureghello <adureghello@baylibre.com> > > After testing this driver, add some minor fixes and improvements, > as adding single channel variants support (ad3541r, ad3551r), also as a > preparatory step to bigger future improvements related to fast-rate mode > for this DAC family. > > Previous patches (v1, 3/3) > https://lore.kernel.org/linux-iio/20240510141836.1624009-1-adureghello@baylibre.org > https://lore.kernel.org/linux-iio/20240510141836.1624009-2-adureghello@baylibre.org/ > https://lore.kernel.org/linux-iio/20240510141836.1624009-3-adureghello@baylibre.org/ > > Angelo Dureghello (6): > dt-bindings: iio: dac: fix ad3552r gain parameter names > dt-bindings: iio: dac: add ad35xxr single output variants > iio: dac: ad3552r: add model data structure > iio: dac: ad3552r: add support for ad3541r and ad3551r > iio: dac: ad3552r: change AD3552R_NUM_CH define name > iio: dac: ad3552r: uniform structure names > > .../bindings/iio/dac/adi,ad3552r.yaml | 43 ++++-- > drivers/iio/dac/ad3552r.c | 140 ++++++++++++------ > 2 files changed, 128 insertions(+), 55 deletions(-) > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
On Thu, 23 May 2024 14:45:01 +0200 Nuno Sá <noname.nuno@gmail.com> wrote: > On Wed, 2024-05-22 at 17:01 +0200, Angelo Dureghello wrote: > > From: Angelo Dureghello <adureghello@baylibre.com> > > > > After testing this driver, add some minor fixes and improvements, > > as adding single channel variants support (ad3541r, ad3551r), also as a > > preparatory step to bigger future improvements related to fast-rate mode > > for this DAC family. > > > > Previous patches (v1, 3/3) > > https://lore.kernel.org/linux-iio/20240510141836.1624009-1-adureghello@baylibre.org > > https://lore.kernel.org/linux-iio/20240510141836.1624009-2-adureghello@baylibre.org/ > > https://lore.kernel.org/linux-iio/20240510141836.1624009-3-adureghello@baylibre.org/ > > > > Angelo Dureghello (6): > > dt-bindings: iio: dac: fix ad3552r gain parameter names > > dt-bindings: iio: dac: add ad35xxr single output variants > > iio: dac: ad3552r: add model data structure > > iio: dac: ad3552r: add support for ad3541r and ad3551r > > iio: dac: ad3552r: change AD3552R_NUM_CH define name > > iio: dac: ad3552r: uniform structure names > > > > .../bindings/iio/dac/adi,ad3552r.yaml | 43 ++++-- > > drivers/iio/dac/ad3552r.c | 140 ++++++++++++------ > > 2 files changed, 128 insertions(+), 55 deletions(-) > > > > Reviewed-by: Nuno Sa <nuno.sa@analog.com> > This series crossed with a series using device_for_each_child_node_scoped() I've rebased on top of that. Was moderately straightforwards but given last week I messed a similar change up completely please check the testing branch of iio.git! The mess was all it the patch adding model_data Thanks, Jonathan >
Hi, On 25/05/24 7:06 PM, Jonathan Cameron wrote: > On Thu, 23 May 2024 14:45:01 +0200 > Nuno Sá <noname.nuno@gmail.com> wrote: > >> On Wed, 2024-05-22 at 17:01 +0200, Angelo Dureghello wrote: >>> From: Angelo Dureghello <adureghello@baylibre.com> >>> >>> After testing this driver, add some minor fixes and improvements, >>> as adding single channel variants support (ad3541r, ad3551r), also as a >>> preparatory step to bigger future improvements related to fast-rate mode >>> for this DAC family. >>> >>> Previous patches (v1, 3/3) >>> https://lore.kernel.org/linux-iio/20240510141836.1624009-1-adureghello@baylibre.org >>> https://lore.kernel.org/linux-iio/20240510141836.1624009-2-adureghello@baylibre.org/ >>> https://lore.kernel.org/linux-iio/20240510141836.1624009-3-adureghello@baylibre.org/ >>> >>> Angelo Dureghello (6): >>> dt-bindings: iio: dac: fix ad3552r gain parameter names >>> dt-bindings: iio: dac: add ad35xxr single output variants >>> iio: dac: ad3552r: add model data structure >>> iio: dac: ad3552r: add support for ad3541r and ad3551r >>> iio: dac: ad3552r: change AD3552R_NUM_CH define name >>> iio: dac: ad3552r: uniform structure names >>> >>> .../bindings/iio/dac/adi,ad3552r.yaml | 43 ++++-- >>> drivers/iio/dac/ad3552r.c | 140 ++++++++++++------ >>> 2 files changed, 128 insertions(+), 55 deletions(-) >>> >> Reviewed-by: Nuno Sa <nuno.sa@analog.com> >> > This series crossed with a series using > device_for_each_child_node_scoped() > > I've rebased on top of that. Was moderately straightforwards but > given last week I messed a similar change up completely please > check the testing branch of iio.git! > > The mess was all it the patch adding model_data Thanks for this, sure, will check. > Thanks, > > Jonathan Regards, angelo
Hi Jonathan, On 25/05/24 7:06 PM, Jonathan Cameron wrote: > On Thu, 23 May 2024 14:45:01 +0200 > Nuno Sá <noname.nuno@gmail.com> wrote: > >> On Wed, 2024-05-22 at 17:01 +0200, Angelo Dureghello wrote: >>> From: Angelo Dureghello <adureghello@baylibre.com> >>> >>> After testing this driver, add some minor fixes and improvements, >>> as adding single channel variants support (ad3541r, ad3551r), also as a >>> preparatory step to bigger future improvements related to fast-rate mode >>> for this DAC family. >>> >>> Previous patches (v1, 3/3) >>> https://lore.kernel.org/linux-iio/20240510141836.1624009-1-adureghello@baylibre.org >>> https://lore.kernel.org/linux-iio/20240510141836.1624009-2-adureghello@baylibre.org/ >>> https://lore.kernel.org/linux-iio/20240510141836.1624009-3-adureghello@baylibre.org/ >>> >>> Angelo Dureghello (6): >>> dt-bindings: iio: dac: fix ad3552r gain parameter names >>> dt-bindings: iio: dac: add ad35xxr single output variants >>> iio: dac: ad3552r: add model data structure >>> iio: dac: ad3552r: add support for ad3541r and ad3551r >>> iio: dac: ad3552r: change AD3552R_NUM_CH define name >>> iio: dac: ad3552r: uniform structure names >>> >>> .../bindings/iio/dac/adi,ad3552r.yaml | 43 ++++-- >>> drivers/iio/dac/ad3552r.c | 140 ++++++++++++------ >>> 2 files changed, 128 insertions(+), 55 deletions(-) >>> >> Reviewed-by: Nuno Sa <nuno.sa@analog.com> >> > This series crossed with a series using > device_for_each_child_node_scoped() > > I've rebased on top of that. Was moderately straightforwards but > given last week I messed a similar change up completely please > check the testing branch of iio.git! > > The mess was all it the patch adding model_data i tested the driver from the iio testing beranch, it works as expected. > Thanks, > > Jonathan Thanks, Regards, angelo
Hi Jonathan, Nuno, just to be sure, is there something else needed from my side for this patch-set ? Thanks, regards, angelo On 28/05/24 9:16 PM, Angelo Dureghello wrote: > Hi Jonathan, > > On 25/05/24 7:06 PM, Jonathan Cameron wrote: >> On Thu, 23 May 2024 14:45:01 +0200 >> Nuno Sá <noname.nuno@gmail.com> wrote: >> >>> On Wed, 2024-05-22 at 17:01 +0200, Angelo Dureghello wrote: >>>> From: Angelo Dureghello <adureghello@baylibre.com> >>>> >>>> After testing this driver, add some minor fixes and improvements, >>>> as adding single channel variants support (ad3541r, ad3551r), also >>>> as a >>>> preparatory step to bigger future improvements related to fast-rate >>>> mode >>>> for this DAC family. >>>> >>>> Previous patches (v1, 3/3) >>>> https://lore.kernel.org/linux-iio/20240510141836.1624009-1-adureghello@baylibre.org >>>> >>>> https://lore.kernel.org/linux-iio/20240510141836.1624009-2-adureghello@baylibre.org/ >>>> >>>> https://lore.kernel.org/linux-iio/20240510141836.1624009-3-adureghello@baylibre.org/ >>>> >>>> >>>> Angelo Dureghello (6): >>>> dt-bindings: iio: dac: fix ad3552r gain parameter names >>>> dt-bindings: iio: dac: add ad35xxr single output variants >>>> iio: dac: ad3552r: add model data structure >>>> iio: dac: ad3552r: add support for ad3541r and ad3551r >>>> iio: dac: ad3552r: change AD3552R_NUM_CH define name >>>> iio: dac: ad3552r: uniform structure names >>>> >>>> .../bindings/iio/dac/adi,ad3552r.yaml | 43 ++++-- >>>> drivers/iio/dac/ad3552r.c | 140 >>>> ++++++++++++------ >>>> 2 files changed, 128 insertions(+), 55 deletions(-) >>> Reviewed-by: Nuno Sa <nuno.sa@analog.com> >>> >> This series crossed with a series using >> device_for_each_child_node_scoped() >> >> I've rebased on top of that. Was moderately straightforwards but >> given last week I messed a similar change up completely please >> check the testing branch of iio.git! >> >> The mess was all it the patch adding model_data > > i tested the driver from the iio testing beranch, > it works as expected. > >> Thanks, >> >> Jonathan > > Thanks, > > Regards, > angelo > >
On Wed, 12 Jun 2024 18:35:32 +0200 Angelo Dureghello <adureghello@baylibre.com> wrote: > Hi Jonathan, Nuno, > > just to be sure, is there something else needed from my side > for this patch-set ? > All good now. It's queued up and so just a case of me sending a pull request to Greg KH. If he takes that it'll then be in char-misc and Greg will then send pull request to Linus when the merge window opens. Jonathan > > Thanks, > regards, > angelo > > On 28/05/24 9:16 PM, Angelo Dureghello wrote: > > Hi Jonathan, > > > > On 25/05/24 7:06 PM, Jonathan Cameron wrote: > >> On Thu, 23 May 2024 14:45:01 +0200 > >> Nuno Sá <noname.nuno@gmail.com> wrote: > >> > >>> On Wed, 2024-05-22 at 17:01 +0200, Angelo Dureghello wrote: > >>>> From: Angelo Dureghello <adureghello@baylibre.com> > >>>> > >>>> After testing this driver, add some minor fixes and improvements, > >>>> as adding single channel variants support (ad3541r, ad3551r), also > >>>> as a > >>>> preparatory step to bigger future improvements related to fast-rate > >>>> mode > >>>> for this DAC family. > >>>> > >>>> Previous patches (v1, 3/3) > >>>> https://lore.kernel.org/linux-iio/20240510141836.1624009-1-adureghello@baylibre.org > >>>> > >>>> https://lore.kernel.org/linux-iio/20240510141836.1624009-2-adureghello@baylibre.org/ > >>>> > >>>> https://lore.kernel.org/linux-iio/20240510141836.1624009-3-adureghello@baylibre.org/ > >>>> > >>>> > >>>> Angelo Dureghello (6): > >>>> dt-bindings: iio: dac: fix ad3552r gain parameter names > >>>> dt-bindings: iio: dac: add ad35xxr single output variants > >>>> iio: dac: ad3552r: add model data structure > >>>> iio: dac: ad3552r: add support for ad3541r and ad3551r > >>>> iio: dac: ad3552r: change AD3552R_NUM_CH define name > >>>> iio: dac: ad3552r: uniform structure names > >>>> > >>>> .../bindings/iio/dac/adi,ad3552r.yaml | 43 ++++-- > >>>> drivers/iio/dac/ad3552r.c | 140 > >>>> ++++++++++++------ > >>>> 2 files changed, 128 insertions(+), 55 deletions(-) > >>> Reviewed-by: Nuno Sa <nuno.sa@analog.com> > >>> > >> This series crossed with a series using > >> device_for_each_child_node_scoped() > >> > >> I've rebased on top of that. Was moderately straightforwards but > >> given last week I messed a similar change up completely please > >> check the testing branch of iio.git! > >> > >> The mess was all it the patch adding model_data > > > > i tested the driver from the iio testing beranch, > > it works as expected. > > > >> Thanks, > >> > >> Jonathan > > > > Thanks, > > > > Regards, > > angelo > > > >
From: Angelo Dureghello <adureghello@baylibre.com> After testing this driver, add some minor fixes and improvements, as adding single channel variants support (ad3541r, ad3551r), also as a preparatory step to bigger future improvements related to fast-rate mode for this DAC family. Previous patches (v1, 3/3) https://lore.kernel.org/linux-iio/20240510141836.1624009-1-adureghello@baylibre.org https://lore.kernel.org/linux-iio/20240510141836.1624009-2-adureghello@baylibre.org/ https://lore.kernel.org/linux-iio/20240510141836.1624009-3-adureghello@baylibre.org/ Angelo Dureghello (6): dt-bindings: iio: dac: fix ad3552r gain parameter names dt-bindings: iio: dac: add ad35xxr single output variants iio: dac: ad3552r: add model data structure iio: dac: ad3552r: add support for ad3541r and ad3551r iio: dac: ad3552r: change AD3552R_NUM_CH define name iio: dac: ad3552r: uniform structure names .../bindings/iio/dac/adi,ad3552r.yaml | 43 ++++-- drivers/iio/dac/ad3552r.c | 140 ++++++++++++------ 2 files changed, 128 insertions(+), 55 deletions(-)