mbox series

[v2,0/3] drm/loongson: Introduce component framework support

Message ID 20240526195826.109008-1-sui.jingfeng@linux.dev (mailing list archive)
Headers show
Series drm/loongson: Introduce component framework support | expand

Message

Sui Jingfeng May 26, 2024, 7:58 p.m. UTC
Introduce component framework to bind child and sibling devices, for better
modularity and offload the deferral probe issue to submodule if it need to
attach exterinal module someday. Also for better reflect the hardware
layout.

Hardware units that come with PCIe are all ready to drive, but there are
some board specific modules will return -EPROBE_DEFER to us. We need all
submodules ready to use before we can register the drm device to userspace.

The idea is to device the exterinal module dependent part and exterinal
module independent part. For example, the display controller and the
GPIO-I2C just belong to exterinal module independent part. While the
outputs are just belong to exterinal module dependent part.

We abstract the output ports as child devices, the output ports may
consists of encoder phy and level shifter. Well, the GPU are standalone
siblings relative to the DC. Those units are relatively separated
hardware units from display controller itself.

By design, the display controller PCI(e) is selected as master, gpio-i2c
go with master. Manually created virtual subdevice functional as agents
for the master, it could return the -EPROBE_DEFER back to the drvier core.
This allows the master don't have to tear down everything, thereore
majority setups work can be preserved. The potential cyclic dependency
problem can be solved then.

v1 -> v2:
	* Squash patch 0002 and patch 0003 into one
	* Fill type and improve commit message

Sui Jingfeng (3):
  drm/loongson: Add a helper for creating child devices
  drm/loongson: Introduce component framework support
  drm/loongson: Add dummy gpu driver as a subcomponent

 drivers/gpu/drm/loongson/Makefile             |   4 +
 drivers/gpu/drm/loongson/loong_gpu_pci_drv.c  |  90 ++++++++
 drivers/gpu/drm/loongson/loong_gpu_pci_drv.h  |  27 +++
 drivers/gpu/drm/loongson/loongson_device.c    |  42 ++++
 drivers/gpu/drm/loongson/loongson_module.c    |  26 ++-
 drivers/gpu/drm/loongson/loongson_module.h    |   8 +
 drivers/gpu/drm/loongson/lsdc_drv.c           | 217 +++++++++++-------
 drivers/gpu/drm/loongson/lsdc_drv.h           |  45 +---
 drivers/gpu/drm/loongson/lsdc_i2c.c           |   5 +-
 drivers/gpu/drm/loongson/lsdc_i2c.h           |   3 -
 drivers/gpu/drm/loongson/lsdc_output.c        | 176 ++++++++++++++
 drivers/gpu/drm/loongson/lsdc_output.h        |  38 ++-
 drivers/gpu/drm/loongson/lsdc_output_7a1000.c |   3 +-
 drivers/gpu/drm/loongson/lsdc_output_7a2000.c |  17 +-
 14 files changed, 564 insertions(+), 137 deletions(-)
 create mode 100644 drivers/gpu/drm/loongson/loong_gpu_pci_drv.c
 create mode 100644 drivers/gpu/drm/loongson/loong_gpu_pci_drv.h
 create mode 100644 drivers/gpu/drm/loongson/lsdc_output.c

Comments

Markus Elfring May 27, 2024, 8:05 a.m. UTC | #1
> Introduce component framework to bind child and sibling devices, for better
> modularity and offload the deferral probe issue to submodule if it need to

                                                                     needs?


> attach exterinal module someday. Also for better reflect the hardware

         external?                 Reflect the hardware layout better?


> layout.> consists of encoder phy and level shifter. Well, the GPU are standalone

                                                           is stand-alone?


…
> for the master, it could return the -EPROBE_DEFER back to the drvier core.

                                                                driver?


> This allows the master don't have to tear down everything, thereore

                                                             therefore?

Less typos would be nicer also for such a cover letter.

Regards,
Markus