[BlueZ,1/6] shared/bap: Remove DISABLING case from bcast state cb

Commit Message

Iulia Tanasescu May 27, 2024, 7:54 a.m. UTC

This removes the switch case for the DISABLING state from
bap_bcast_set_state, since this state is not used for broadcast.
---
 src/shared/bap.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

[e-mail] May 27, 2024, 11:54 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=856047

---Test result---

Test Summary:
CheckPatch                    PASS      2.74 seconds
GitLint                       PASS      1.89 seconds
BuildEll                      PASS      24.37 seconds
BluezMake                     PASS      1633.36 seconds
MakeCheck                     PASS      13.23 seconds
MakeDistcheck                 PASS      176.30 seconds
CheckValgrind                 PASS      248.67 seconds
CheckSmatch                   WARNING   352.24 seconds
bluezmakeextell               PASS      119.17 seconds
IncrementalBuild              PASS      9382.93 seconds
ScanBuild                     PASS      980.76 seconds

Details
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/bap.c:286:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:286:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:286:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:286:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:286:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:286:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structures


---
Regards,
Linux Bluetooth

Patch

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 639149520..1d9f59f21 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -2056,10 +2056,6 @@  static void bap_bcast_set_state(struct bt_bap_stream *stream, uint8_t state)
 		if (stream->ops && stream->ops->detach)
 			stream->ops->detach(stream);
 		break;
-	case BT_ASCS_ASE_STATE_DISABLING:
-		bap_stream_io_detach(stream);
-		stream_set_state(stream, BT_BAP_STREAM_STATE_QOS);
-		break;
 	case BT_ASCS_ASE_STATE_RELEASING:
 		bap_stream_io_detach(stream);
 		stream_set_state(stream, BT_BAP_STREAM_STATE_IDLE);