[v7,0/3] arm64: qcom: sa8775p: add cache coherency support for SA8775P

Message

Mrinmay Sarkar March 11, 2024, 2:11 p.m. UTC

Due to some hardware changes, SA8775P has set the NO_SNOOP attribute
in its TLP for all the PCIe controllers. NO_SNOOP attribute when set,
the requester is indicating that no cache coherency issues exist for
the addressed memory on the host i.e., memory is not cached. But in
reality, requester cannot assume this unless there is a complete
control/visibility over the addressed memory on the host.

And worst case, if the memory is cached on the host, it may lead to
memory corruption issues. It should be noted that the caching of memory
on the host is not solely dependent on the NO_SNOOP attribute in TLP.

So to avoid the corruption, this patch overrides the NO_SNOOP attribute
by setting the PCIE_PARF_NO_SNOOP_OVERIDE register. This patch is not
needed for other upstream supported platforms since they do not set
NO_SNOOP attribute by default.

This series is to enable cache snooping logic in both RC and EP driver
and add the "dma-coherent" property in dtsi to support cache coherency
in SA8775P platform.

Dependency
----------

Depends on:
https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/ [1]

V6 -> V7:
- removed redundant comment in both patches 1 & 2
- added Reviewed-by and Acked-by tag

V5 -> V6:
- updated commit message as per comments
- added Kdoc comments in patch1
- change variable name from enable_cache_snoop to
  override_no_snoop
- sort reg offset define in patch2

V4 -> V5:
- Updated commit message in both Patch1 and patch2
- change variable name from no_snoop_override to
  enable_cache_snoop
- rebased patch2 on top of [1]

v3 -> v4:
- added new cfg(cfg_1_34_0) for SA8775P in both RC and EP driver.
- populated a flag in the data structures instead of doing
  of_device_is_compatible() in both RC and EP patch.
- update commit mesaage and added reveiwed-by tag in commit message
  in dtsi patch.

v2 -> v3:
- update commit message(8755 -> 8775).

v1 -> v2:
- update cover letter with explanation.
- define each of these bits and ORing at usage time rather than
  directly writing value in register.

Mrinmay Sarkar (3):
  PCI: qcom: Override NO_SNOOP attribute for SA8775P RC
  PCI: qcom-ep: Override NO_SNOOP attribute for SA8775P EP
  arm64: dts: qcom: sa8775p: Mark PCIe EP controller as cache coherent

 arch/arm64/boot/dts/qcom/sa8775p.dtsi     |  1 +
 drivers/pci/controller/dwc/pcie-qcom-ep.c | 19 ++++++++++++++++---
 drivers/pci/controller/dwc/pcie-qcom.c    | 24 +++++++++++++++++++++++-
 3 files changed, 40 insertions(+), 4 deletions(-)

Comments

Krzysztof Wilczyński May 17, 2024, 5:20 p.m. UTC | #1

Hello,

> Due to some hardware changes, SA8775P has set the NO_SNOOP attribute
> in its TLP for all the PCIe controllers. NO_SNOOP attribute when set,
> the requester is indicating that no cache coherency issues exist for
> the addressed memory on the host i.e., memory is not cached. But in
> reality, requester cannot assume this unless there is a complete
> control/visibility over the addressed memory on the host.
> 
> And worst case, if the memory is cached on the host, it may lead to
> memory corruption issues. It should be noted that the caching of memory
> on the host is not solely dependent on the NO_SNOOP attribute in TLP.
> 
> So to avoid the corruption, this patch overrides the NO_SNOOP attribute
> by setting the PCIE_PARF_NO_SNOOP_OVERIDE register. This patch is not
> needed for other upstream supported platforms since they do not set
> NO_SNOOP attribute by default.
> 
> This series is to enable cache snooping logic in both RC and EP driver
> and add the "dma-coherent" property in dtsi to support cache coherency
> in SA8775P platform.
> 
> Dependency
> ----------
> 
> Depends on:
> https://lore.kernel.org/all/[e-mail]/
> https://lore.kernel.org/all/[e-mail]/ [1]

Applied to qcom, thank you!

[01/02] PCI: qcom: Override NO_SNOOP attribute for SA8775P RC
        https://git.kernel.org/pci/pci/c/a51da87be9db
[02/02] PCI: qcom-ep: Override NO_SNOOP attribute for SA8775P EP
        https://git.kernel.org/pci/pci/c/ce38ead6a0ed

	Krzysztof

Bjorn Andersson May 28, 2024, 3:32 a.m. UTC | #2

On Mon, 11 Mar 2024 19:41:34 +0530, Mrinmay Sarkar wrote:
> Due to some hardware changes, SA8775P has set the NO_SNOOP attribute
> in its TLP for all the PCIe controllers. NO_SNOOP attribute when set,
> the requester is indicating that no cache coherency issues exist for
> the addressed memory on the host i.e., memory is not cached. But in
> reality, requester cannot assume this unless there is a complete
> control/visibility over the addressed memory on the host.
> 
> [...]

Applied, thanks!

[3/3] arm64: dts: qcom: sa8775p: Mark PCIe EP controller as cache coherent
      commit: 4b220c6fa9f379cb8803dbca73ae1f4128dfa5c8

Best regards,