diff mbox series

[1/2] net/core: remove redundant sk_callback_lock initialization

Message ID 20240526145718.9542-1-gouhao@uniontech.com (mailing list archive)
State Accepted
Commit c65b6521115ed478471bf8c4a3687059fcea01aa
Delegated to: Netdev Maintainers
Headers show
Series [1/2] net/core: remove redundant sk_callback_lock initialization | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 908 this patch: 908
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 4 of 4 maintainers
netdev/build_clang success Errors and warnings before: 906 this patch: 906
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 912 this patch: 912
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 9 this patch: 9
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-05-27--21-00 (tests: 1037)

Commit Message

Gou Hao May 26, 2024, 2:57 p.m. UTC
sk_callback_lock has already been initialized in sk_init_common().

Signed-off-by: Gou Hao <gouhao@uniontech.com>
---
 net/core/sock.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Breno Leitao May 28, 2024, 8 a.m. UTC | #1
On Sun, May 26, 2024 at 10:57:17PM +0800, Gou Hao wrote:
> sk_callback_lock has already been initialized in sk_init_common().
> 
> Signed-off-by: Gou Hao <gouhao@uniontech.com>

Reviewed-by: Breno Leitao <leitao@debian.org>
patchwork-bot+netdevbpf@kernel.org May 28, 2024, noon UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Sun, 26 May 2024 22:57:17 +0800 you wrote:
> sk_callback_lock has already been initialized in sk_init_common().
> 
> Signed-off-by: Gou Hao <gouhao@uniontech.com>
> ---
>  net/core/sock.c | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [1/2] net/core: remove redundant sk_callback_lock initialization
    https://git.kernel.org/netdev/net-next/c/c65b6521115e
  - [2/2] net/core: move the lockdep-init of sk_callback_lock to sk_init_common()
    https://git.kernel.org/netdev/net-next/c/de31e96cf423

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/core/sock.c b/net/core/sock.c
index 8629f9aecf91..67b10954e0cf 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -3460,7 +3460,6 @@  void sock_init_data_uid(struct socket *sock, struct sock *sk, kuid_t uid)
 	}
 	sk->sk_uid	=	uid;
 
-	rwlock_init(&sk->sk_callback_lock);
 	if (sk->sk_kern_sock)
 		lockdep_set_class_and_name(
 			&sk->sk_callback_lock,