| Message ID | 20240528102603.1016587-1-amadeus@jmu.edu.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/1] dt-bindings: net: rfkill-gpio: document reset-gpios | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 28/05/2024 12:26, Chukun Pan wrote: > The rfkill-gpio driver supports setting two optional gpio: > "reset-gpios" and "shutdown-gpios". > The "reset-gpios" property is missing, so document it. > Please focus instead on why. https://lore.kernel.org/all/d096d9ea-39db-4a15-9c4d-ae228db970cb@linaro.org/ NAK Best regards, Krzysztof
> Please focus instead on why. > > https://lore.kernel.org/all/d096d9ea-39db-4a15-9c4d-ae228db970cb@linaro.org/ Thanks for the link, I missed it. But for the 4/5G modules, it usually has multiple gpio connections and cannot be controlled through just one gpio. For example, when rfkill unblock, if the module is not reset again, it will not work. In this case, can rfkill-gpio be allowed to use reset-gpios property? Thanks, Chukun
On 28/05/2024 14:00, Chukun Pan wrote: >> Please focus instead on why. >> >> https://lore.kernel.org/all/d096d9ea-39db-4a15-9c4d-ae228db970cb@linaro.org/ > > Thanks for the link, I missed it. > But for the 4/5G modules, it usually has multiple gpio connections > and cannot be controlled through just one gpio. For example, when > rfkill unblock, if the module is not reset again, it will not work. Please send a patch with proper hardware description used as rationale. Your argument - driver has it - is not correct for the bindings. Bindings do not describe drivers. Read the old v1 (which had reset GPIO) and the arguments presented there. Include your counter-arguments to that old v1 arguments in your patch. > In this case, can rfkill-gpio be allowed to use reset-gpios property? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml index 9630c8466fac..d01cefef6115 100644 --- a/Documentation/devicetree/bindings/net/rfkill-gpio.yaml +++ b/Documentation/devicetree/bindings/net/rfkill-gpio.yaml @@ -29,6 +29,9 @@ properties: - wlan - wwan + reset-gpios: + maxItems: 1 + shutdown-gpios: maxItems: 1
The rfkill-gpio driver supports setting two optional gpio: "reset-gpios" and "shutdown-gpios". The "reset-gpios" property is missing, so document it. Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn> --- Documentation/devicetree/bindings/net/rfkill-gpio.yaml | 3 +++ 1 file changed, 3 insertions(+)