mbox series

[0/4] mdadm/tests: fix and enhance some cases

Message ID 20240528135150.26823-1-xni@redhat.com (mailing list archive)
Headers show
Series mdadm/tests: fix and enhance some cases | expand

Message

Xiao Ni May 28, 2024, 1:51 p.m. UTC 
Hi all

This is the third patch set that fix and enhance some test cases.

Xiao Ni (4):
  mdadm/tests: bitmap cases enhance
  mdadm/tests: 04update-uuid
  mdadm/tests: 05r1-re-add-nosuper
  mdadm/tests: remove strace test

 tests/04update-uuid           |  4 ++--
 tests/05r1-grow-internal      | 11 ++++-------
 tests/05r1-grow-internal-1    | 12 ++++--------
 tests/05r1-internalbitmap     | 22 ++++++++++------------
 tests/05r1-internalbitmap-v1a | 22 ++++++++++------------
 tests/05r1-internalbitmap-v1b | 23 ++++++++++-------------
 tests/05r1-internalbitmap-v1c | 22 ++++++++++------------
 tests/05r1-re-add-nosuper     |  2 +-
 tests/07revert-grow           |  2 +-
 tests/07revert-inplace        |  2 +-
 10 files changed, 53 insertions(+), 69 deletions(-)

Comments

Mariusz Tkaczyk May 28, 2024, 3:15 p.m. UTC | #1 
On Tue, 28 May 2024 21:51:46 +0800
Xiao Ni <xni@redhat.com> wrote:

> Hi all
> 
> This is the third patch set that fix and enhance some test cases.

Applied all. Here some minor comments:
> 
> Xiao Ni (4):
>   mdadm/tests: bitmap cases enhance
>   mdadm/tests: 04update-uuid
you can remove testing of bitmap file.

>   mdadm/tests: 05r1-re-add-nosuper
same in this test.

I missed those tests but I wrote in 50b100768a11:

"The implementation of custom bitmap file looks like it's
abandoned. It cannot be done by Incremental so it is not respected by
any udev based system and it seems to not be recorded by metadata.
User must assemble such volume manually."

I do not consider it as a real-life feature. We should help it to become
deprecated (it is in kernel) and dropping tests is reasonable for me.

Thanks for patches,
Mariusz