| Message ID | 20240529080013.2325748-1-mripard@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/display: Fix HDMI state helper dependency | expand |
Maxime Ripard <mripard@kernel.org> writes: > During the life of the series that introduced the > DRM_DISPLAY_HDMI_STATE_HELPER option, we reworked the Kconfig option > dependency setup to rely on depends on with commit f6d2dc03fa85 ("drm: > Switch DRM_DISPLAY_HDMI_HELPER to depends on") which got reverted later > on because it was creating too many issues by commit d7c128cb775e > ("Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on""). > > However, since the series was out of tree at that time, > DRM_DISPLAY_HDMI_STATE_HELPER wasn't properly updated to take the revert > into account and is now creating build issues. > > Let's switch the depends on to a select to fix this. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202405290332.Sqtt0ix0-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405290438.TOYhXMIn-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405290803.c3178DYT-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405291109.PQdqc46g-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405291221.a0NStxHE-lkp@intel.com/ > Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state") > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On Wed, May 29, 2024 at 10:00:13AM +0200, Maxime Ripard wrote: > During the life of the series that introduced the > DRM_DISPLAY_HDMI_STATE_HELPER option, we reworked the Kconfig option > dependency setup to rely on depends on with commit f6d2dc03fa85 ("drm: > Switch DRM_DISPLAY_HDMI_HELPER to depends on") which got reverted later > on because it was creating too many issues by commit d7c128cb775e > ("Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on""). > > However, since the series was out of tree at that time, > DRM_DISPLAY_HDMI_STATE_HELPER wasn't properly updated to take the revert > into account and is now creating build issues. > > Let's switch the depends on to a select to fix this. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202405290332.Sqtt0ix0-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405290438.TOYhXMIn-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405290803.c3178DYT-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405291109.PQdqc46g-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405291221.a0NStxHE-lkp@intel.com/ > Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state") > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- > drivers/gpu/drm/display/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Wed, 29 May 2024 10:00:13 +0200, Maxime Ripard wrote: > During the life of the series that introduced the > DRM_DISPLAY_HDMI_STATE_HELPER option, we reworked the Kconfig option > dependency setup to rely on depends on with commit f6d2dc03fa85 ("drm: > Switch DRM_DISPLAY_HDMI_HELPER to depends on") which got reverted later > on because it was creating too many issues by commit d7c128cb775e > ("Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on""). > > [...] Applied to misc/kernel.git (drm-misc-next). Thanks! Maxime
diff --git a/drivers/gpu/drm/display/Kconfig b/drivers/gpu/drm/display/Kconfig index 14114b597ef4..479e62690d75 100644 --- a/drivers/gpu/drm/display/Kconfig +++ b/drivers/gpu/drm/display/Kconfig @@ -72,8 +72,8 @@ config DRM_DISPLAY_HDMI_HELPER DRM display helpers for HDMI. config DRM_DISPLAY_HDMI_STATE_HELPER bool depends on DRM_DISPLAY_HELPER - depends on DRM_DISPLAY_HDMI_HELPER + select DRM_DISPLAY_HDMI_HELPER help DRM KMS state helpers for HDMI.
During the life of the series that introduced the DRM_DISPLAY_HDMI_STATE_HELPER option, we reworked the Kconfig option dependency setup to rely on depends on with commit f6d2dc03fa85 ("drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on") which got reverted later on because it was creating too many issues by commit d7c128cb775e ("Revert "drm: Switch DRM_DISPLAY_HDMI_HELPER to depends on""). However, since the series was out of tree at that time, DRM_DISPLAY_HDMI_STATE_HELPER wasn't properly updated to take the revert into account and is now creating build issues. Let's switch the depends on to a select to fix this. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202405290332.Sqtt0ix0-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202405290438.TOYhXMIn-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202405290803.c3178DYT-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202405291109.PQdqc46g-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202405291221.a0NStxHE-lkp@intel.com/ Fixes: 54cb39e2293b ("drm/connector: hdmi: Create an HDMI sub-state") Signed-off-by: Maxime Ripard <mripard@kernel.org> --- drivers/gpu/drm/display/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)