| Message ID | 20240528151056.2104153-1-mripard@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: Fix compilation error | expand |
Maxime Ripard <mripard@kernel.org> writes: Hello Maxime, > Commit ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") > introduced a dependency that got renamed in a previous version, but > wasn't properly updated in that driver. Fix the name of the function. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202405282205.EU7NUoeQ-lkp@intel.com/ > Closes: https://lore.kernel.org/oe-kbuild-all/202405282248.U2lhPvCK-lkp@intel.com/ > Fixes: ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") > Signed-off-by: Maxime Ripard <mripard@kernel.org> > --- Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On Tue, 28 May 2024 17:10:56 +0200, Maxime Ripard wrote: > Commit ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") > introduced a dependency that got renamed in a previous version, but > wasn't properly updated in that driver. Fix the name of the function. > > Applied to misc/kernel.git (drm-misc-next). Thanks! Maxime
On Wed, May 29, 2024 at 10:14:55AM +0200, Maxime Ripard wrote: > On Tue, 28 May 2024 17:10:56 +0200, Maxime Ripard wrote: > > Commit ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") > > introduced a dependency that got renamed in a previous version, but > > wasn't properly updated in that driver. Fix the name of the function. > > > > > > Applied to misc/kernel.git (drm-misc-next). Just to note, I don't see this commit in drm-misc-next. > > Thanks! > Maxime >
On Wed, May 29, 2024 at 11:33:43AM GMT, Dmitry Baryshkov wrote: > On Wed, May 29, 2024 at 10:14:55AM +0200, Maxime Ripard wrote: > > On Tue, 28 May 2024 17:10:56 +0200, Maxime Ripard wrote: > > > Commit ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") > > > introduced a dependency that got renamed in a previous version, but > > > wasn't properly updated in that driver. Fix the name of the function. > > > > > > > > > > Applied to misc/kernel.git (drm-misc-next). > > Just to note, I don't see this commit in drm-misc-next. Thanks for the notice, I forgot to push it indeed. It's now fixed Maxime
diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index 0e652dd480c9..b3649449de30 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -207,13 +207,12 @@ static int sun4i_hdmi_connector_atomic_check(struct drm_connector *connector, static enum drm_mode_status sun4i_hdmi_connector_mode_valid(struct drm_connector *connector, struct drm_display_mode *mode) { - unsigned long long rate = - drm_connector_hdmi_compute_mode_clock(mode, 8, - HDMI_COLORSPACE_RGB); + unsigned long long rate = drm_hdmi_compute_mode_clock(mode, 8, + HDMI_COLORSPACE_RGB); return sun4i_hdmi_connector_clock_valid(connector, mode, rate); } static int sun4i_hdmi_get_modes(struct drm_connector *connector)
Commit ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") introduced a dependency that got renamed in a previous version, but wasn't properly updated in that driver. Fix the name of the function. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202405282205.EU7NUoeQ-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202405282248.U2lhPvCK-lkp@intel.com/ Fixes: ea64761a54a2 ("drm/sun4i: hdmi: Switch to HDMI connector") Signed-off-by: Maxime Ripard <mripard@kernel.org> --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)