mbox series

[net,0/8] Intel Wired LAN Driver Updates 2024-05-28 (e1000e, i40e, ice)

Message ID 20240528-net-2024-05-28-intel-net-fixes-v1-0-dc8593d2bbc6@intel.com (mailing list archive)
Headers show
Series Intel Wired LAN Driver Updates 2024-05-28 (e1000e, i40e, ice) | expand

Message

Jacob Keller May 28, 2024, 10:06 p.m. UTC
This series includes a variety of fixes that have been accumulating on the
Intel Wired LAN dev-queue.

Hui Wang provides a fix for suspend/resume on e1000e due to failure
to correctly setup the SMBUS in enable_ulp().

Thinh Tran provides a fix for EEH I/O suspend/resume on i40e to
ensure that I/O operations can continue after a resume. To avoid duplicate
code, the common logic is factored out of i40e_suspend and i40e_resume.

Michal Kubiak provides a fix for i40e XDP in if the user tries to rmmod the
i40e driver while an XDP program is loaded.

Paul Greenwalt provides a fix to correctly map the 200G PHY types to link
speeds in the ice driver.

Wojciech Drewek provides a fix to ice to resolve sporadic issues with
downloading the firmware package over the Admin queue.

Jacob provides a fix for the ice driver to correct reading the Shadow RAM
portion of the NVM for some of the newer devices including E830 and E825-C
devices.

Dave Ertman provides a fix correcting devlink parameter unregistration in
the event that the driver loads in safe mode and some of the parameters
were not registered.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
Dave Ertman (1):
      ice: check for unregistering correct number of devlink params

Hui Wang (1):
      e1000e: move force SMBUS near the end of enable_ulp function

Jacob Keller (1):
      ice: fix reads from NVM Shadow RAM on E830 and E825-C devices

Michal Kubiak (1):
      i40e: Fix XDP program unloading while removing the driver

Paul Greenwalt (1):
      ice: fix 200G PHY types to link speed mapping

Thinh Tran (2):
      i40e: factoring out i40e_suspend/i40e_resume
      i40e: Fully suspend and resume IO operations in EEH case

Wojciech Drewek (1):
      ice: implement AQ download pkg retry

 drivers/net/ethernet/intel/e1000e/ich8lan.c      |  22 ++
 drivers/net/ethernet/intel/e1000e/netdev.c       |  18 --
 drivers/net/ethernet/intel/i40e/i40e_main.c      | 277 +++++++++++++----------
 drivers/net/ethernet/intel/ice/devlink/devlink.c |  31 ++-
 drivers/net/ethernet/intel/ice/ice_common.c      |  10 +
 drivers/net/ethernet/intel/ice/ice_ddp.c         |  19 +-
 drivers/net/ethernet/intel/ice/ice_nvm.c         |  88 ++++++-
 drivers/net/ethernet/intel/ice/ice_type.h        |  14 +-
 8 files changed, 319 insertions(+), 160 deletions(-)
---
base-commit: 56a5cf538c3f2d935b0d81040a8303b6e7fc5fd8
change-id: 20240528-net-2024-05-28-intel-net-fixes-6d50e8e27b76

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org May 30, 2024, 2 a.m. UTC | #1
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 28 May 2024 15:06:03 -0700 you wrote:
> This series includes a variety of fixes that have been accumulating on the
> Intel Wired LAN dev-queue.
> 
> Hui Wang provides a fix for suspend/resume on e1000e due to failure
> to correctly setup the SMBUS in enable_ulp().
> 
> Thinh Tran provides a fix for EEH I/O suspend/resume on i40e to
> ensure that I/O operations can continue after a resume. To avoid duplicate
> code, the common logic is factored out of i40e_suspend and i40e_resume.
> 
> [...]

Here is the summary with links:
  - [net,1/8] e1000e: move force SMBUS near the end of enable_ulp function
    https://git.kernel.org/netdev/net/c/bfd546a552e1
  - [net,2/8] i40e: factoring out i40e_suspend/i40e_resume
    https://git.kernel.org/netdev/net/c/218ed820d364
  - [net,3/8] i40e: Fully suspend and resume IO operations in EEH case
    https://git.kernel.org/netdev/net/c/c80b6538d35a
  - [net,4/8] i40e: Fix XDP program unloading while removing the driver
    (no matching commit)
  - [net,5/8] ice: fix 200G PHY types to link speed mapping
    https://git.kernel.org/netdev/net/c/2a6d8f2de222
  - [net,6/8] ice: implement AQ download pkg retry
    (no matching commit)
  - [net,7/8] ice: fix reads from NVM Shadow RAM on E830 and E825-C devices
    (no matching commit)
  - [net,8/8] ice: check for unregistering correct number of devlink params
    https://git.kernel.org/netdev/net/c/a51c9b1c9ab2

You are awesome, thank you!
Jacob Keller May 30, 2024, 4:45 p.m. UTC | #2
On 5/29/2024 7:00 PM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This series was applied to netdev/net.git (main)
> by Jakub Kicinski <kuba@kernel.org>:
> 
> On Tue, 28 May 2024 15:06:03 -0700 you wrote:
>> This series includes a variety of fixes that have been accumulating on the
>> Intel Wired LAN dev-queue.
>>
>> Hui Wang provides a fix for suspend/resume on e1000e due to failure
>> to correctly setup the SMBUS in enable_ulp().
>>
>> Thinh Tran provides a fix for EEH I/O suspend/resume on i40e to
>> ensure that I/O operations can continue after a resume. To avoid duplicate
>> code, the common logic is factored out of i40e_suspend and i40e_resume.
>>
>> [...]
> 

Some of the series didn't get applied. The two you commented on with
issues or questions make sense.

> Here is the summary with links:
>   - [net,1/8] e1000e: move force SMBUS near the end of enable_ulp function
>     https://git.kernel.org/netdev/net/c/bfd546a552e1
>   - [net,2/8] i40e: factoring out i40e_suspend/i40e_resume
>     https://git.kernel.org/netdev/net/c/218ed820d364
>   - [net,3/8] i40e: Fully suspend and resume IO operations in EEH case
>     https://git.kernel.org/netdev/net/c/c80b6538d35a
>   - [net,4/8] i40e: Fix XDP program unloading while removing the driver
>     (no matching commit)
>   - [net,5/8] ice: fix 200G PHY types to link speed mapping
>     https://git.kernel.org/netdev/net/c/2a6d8f2de222
>   - [net,6/8] ice: implement AQ download pkg retry
>     (no matching commit)
>   - [net,7/8] ice: fix reads from NVM Shadow RAM on E830 and E825-C devices
>     (no matching commit)

I saw this one didn't get applied either, but don't see any comment on
the list regarding if you have any objections or questions.

Thanks,
Jake

>   - [net,8/8] ice: check for unregistering correct number of devlink params
>     https://git.kernel.org/netdev/net/c/a51c9b1c9ab2

> 
> You are awesome, thank you!
Jakub Kicinski May 30, 2024, 4:58 p.m. UTC | #3
On Thu, 30 May 2024 09:45:29 -0700 Jacob Keller wrote:
> >   - [net,7/8] ice: fix reads from NVM Shadow RAM on E830 and E825-C devices
> >     (no matching commit)  
> 
> I saw this one didn't get applied either, but don't see any comment on
> the list regarding if you have any objections or questions.

I wasn't 100% sure there's no dependency on 6, better safe than sorry?
:)
Jacob Keller May 30, 2024, 5:04 p.m. UTC | #4
On 5/30/2024 9:58 AM, Jakub Kicinski wrote:
> On Thu, 30 May 2024 09:45:29 -0700 Jacob Keller wrote:
>>>   - [net,7/8] ice: fix reads from NVM Shadow RAM on E830 and E825-C devices
>>>     (no matching commit)  
>>
>> I saw this one didn't get applied either, but don't see any comment on
>> the list regarding if you have any objections or questions.
> 
> I wasn't 100% sure there's no dependency on 6, better safe than sorry?
> :)

Sure. I can include it in the next batch of fixes. I think we just got a
few more through testing yesterday.

Thanks,
Jake