| Message ID | 20240530194250.1801701-4-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | cpus: a few tweaks to CPU realization | expand |
On 5/30/24 12:42, Alex Bennée wrote: > The thread_id isn't valid until the threads are created. There is no > point setting it here. The only thing that cares about the thread_id > is qmp_query_cpus_fast. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > cpu-target.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/cpu-target.c b/cpu-target.c > index 5af120e8aa..499facf774 100644 > --- a/cpu-target.c > +++ b/cpu-target.c > @@ -241,7 +241,6 @@ void cpu_exec_initfn(CPUState *cpu) > cpu->num_ases = 0; > > #ifndef CONFIG_USER_ONLY > - cpu->thread_id = qemu_get_thread_id(); > cpu->memory = get_system_memory(); > object_ref(OBJECT(cpu->memory)); > #endif Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
On 30/5/24 21:42, Alex Bennée wrote: > The thread_id isn't valid until the threads are created. There is no > point setting it here. The only thing that cares about the thread_id > is qmp_query_cpus_fast. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > cpu-target.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/cpu-target.c b/cpu-target.c index 5af120e8aa..499facf774 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -241,7 +241,6 @@ void cpu_exec_initfn(CPUState *cpu) cpu->num_ases = 0; #ifndef CONFIG_USER_ONLY - cpu->thread_id = qemu_get_thread_id(); cpu->memory = get_system_memory(); object_ref(OBJECT(cpu->memory)); #endif
The thread_id isn't valid until the threads are created. There is no point setting it here. The only thing that cares about the thread_id is qmp_query_cpus_fast. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- cpu-target.c | 1 - 1 file changed, 1 deletion(-)