| Message ID | 20240530074544.25444-5-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate | expand |
On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: > Prefer @dump-s390-skeys which is target agnostic. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > docs/about/deprecated.rst | 5 +++++ > qapi/misc-target.json | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst > index 40585ca7d5..3cb43085ba 100644 > --- a/docs/about/deprecated.rst > +++ b/docs/about/deprecated.rst > @@ -148,6 +148,11 @@ accepted incorrect commands will return an error. Users should make sure that > all arguments passed to ``device_add`` are consistent with the documented > property types. > > +``dump-skeys`` (since 9.1) > +'''''''''''''''''''''''''' > + > +Use the more generic ``dump-s390-skeys`` command. FWIW, that's "more specific", not "more generic". But as I said in my reply to the cover letter, we should maybe consider a more generic command instead, indeed. Thomas
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 40585ca7d5..3cb43085ba 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -148,6 +148,11 @@ accepted incorrect commands will return an error. Users should make sure that all arguments passed to ``device_add`` are consistent with the documented property types. +``dump-skeys`` (since 9.1) +'''''''''''''''''''''''''' + +Use the more generic ``dump-s390-skeys`` command. + QEMU Machine Protocol (QMP) events ---------------------------------- diff --git a/qapi/misc-target.json b/qapi/misc-target.json index 4e0a6492a9..e5109b1265 100644 --- a/qapi/misc-target.json +++ b/qapi/misc-target.json @@ -237,6 +237,10 @@ # # @filename: the path to the file to dump to # +# Features: +# +# @deprecated: This command is deprecated. Use @dump-s390-skeys instead. +# # Since: 2.5 # # Example: @@ -247,6 +251,7 @@ ## { 'command': 'dump-skeys', 'data': { 'filename': 'str' }, + 'features': ['deprecated'], 'if': 'TARGET_S390X' } ##
Prefer @dump-s390-skeys which is target agnostic. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- docs/about/deprecated.rst | 5 +++++ qapi/misc-target.json | 5 +++++ 2 files changed, 10 insertions(+)