| Message ID | 20240531081136.582-1-chenhx.fnst@fujitsu.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: bridge: Clean up one inconsistent indenting warn reported by smatch | expand |
On 5/31/24 11:11, Chen Hanxiao wrote: > smatch complains: > net/bridge/br_netlink_tunnel.c: > 318 br_process_vlan_tunnel_info() warn: inconsistent indenting > > Fix it with proper indenting. > > Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com> > --- > net/bridge/br_netlink_tunnel.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c > index 17abf092f7ca..25ac3a5386ef 100644 > --- a/net/bridge/br_netlink_tunnel.c > +++ b/net/bridge/br_netlink_tunnel.c > @@ -315,8 +315,9 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br, > > if (curr_change) > *changed = curr_change; > - __vlan_tunnel_handle_range(p, &v_start, &v_end, v, > - curr_change); > + Drop the extra new line. > + __vlan_tunnel_handle_range(p, &v_start, &v_end, v, > + curr_change); > } > if (v_start && v_end) > br_vlan_notify(br, p, v_start->vid, v_end->vid, The patch should be targeted at net-next (subject PATCH net-next). Also please remove the "reported by smatch" from the subject we have a Reported-by tag, but I think that information is not needed here. Just "fix inconsistent indentation" is enough, you've already mentioned it was found by smatch in the commit msg. Thanks, Nik
diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c index 17abf092f7ca..25ac3a5386ef 100644 --- a/net/bridge/br_netlink_tunnel.c +++ b/net/bridge/br_netlink_tunnel.c @@ -315,8 +315,9 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br, if (curr_change) *changed = curr_change; - __vlan_tunnel_handle_range(p, &v_start, &v_end, v, - curr_change); + + __vlan_tunnel_handle_range(p, &v_start, &v_end, v, + curr_change); } if (v_start && v_end) br_vlan_notify(br, p, v_start->vid, v_end->vid,
smatch complains: net/bridge/br_netlink_tunnel.c: 318 br_process_vlan_tunnel_info() warn: inconsistent indenting Fix it with proper indenting. Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com> --- net/bridge/br_netlink_tunnel.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)