| Message ID | 20240531-dt-bindings-qcom-gcc-v1-0-b37d49fe1421@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | dt-bindings: clock: qcom: reference qcom-gcc.yaml | expand |
On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where > applicable. Several existing bindings for these display/GPU/CAM clock > controllers already do it. The series looks good to me with a single point in mind. You are writing that dispcc/videocc/etc are a variant of GCC. However GCC is a Global Clock Controller. What about renaming qcom,gcc.yaml to qcom,cc-common.yaml ? Then the rest makes total sense to me. > > No external dependencies, this CAN be applied independently, but require > power-domain-cells in each binding, just like Dmitry's new set is doing. > > https://lore.kernel.org/all/20240529-qcom-gdscs-v2-0-69c63d0ae1e7@linaro.org/ > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (16): > dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,videocc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sc8280xp: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sm6350: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sm8x50: reference qcom,gcc.yaml > dt-bindings: clock: qcom,gpucc-sdm660: reference qcom,gcc.yaml > dt-bindings: clock: qcom,gpucc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,msm8998-gpucc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,qcm2290-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sc7180-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sc7280-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sdm845-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm6115-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8450-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8550-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8450-gpucc: reference qcom,gcc.yaml > > .../bindings/clock/qcom,dispcc-sc8280xp.yaml | 20 ++++---------------- > .../bindings/clock/qcom,dispcc-sm6350.yaml | 20 ++++---------------- > .../bindings/clock/qcom,dispcc-sm8x50.yaml | 18 ++---------------- > .../devicetree/bindings/clock/qcom,gpucc-sdm660.yaml | 20 ++++---------------- > .../devicetree/bindings/clock/qcom,gpucc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,msm8998-gpucc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,qcm2290-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sc7180-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sc7280-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sdm845-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sm6115-dispcc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sm8450-dispcc.yaml | 20 ++++---------------- > .../devicetree/bindings/clock/qcom,sm8450-gpucc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sm8450-videocc.yaml | 20 ++++---------------- > .../bindings/clock/qcom,sm8550-dispcc.yaml | 20 ++++---------------- > .../devicetree/bindings/clock/qcom,videocc.yaml | 19 +++---------------- > 16 files changed, 61 insertions(+), 256 deletions(-) > --- > base-commit: b0afb900b7d235d879f8e8e4babfe77d9db76f2f > change-id: 20240531-dt-bindings-qcom-gcc-e2955fd60004 > > Best regards, > -- > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >
On 31/05/2024 17:14, Dmitry Baryshkov wrote: > On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote: >> Hi, >> >> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where >> applicable. Several existing bindings for these display/GPU/CAM clock >> controllers already do it. > > The series looks good to me with a single point in mind. You are writing > that dispcc/videocc/etc are a variant of GCC. However GCC is a Global > Clock Controller. Yeah, that's simplification from my side and assumption that at first they designed GCC and then they copied the design to other blocks. > What about renaming qcom,gcc.yaml to > qcom,cc-common.yaml ? Then the rest makes total sense to me. Several gpu/disp/cam clock controllers already include qcom,gcc.yaml, so I would say this should not be a requirement for this patchset. We can rename, although it always is a bit of churn - git log needs special option, backporting is a bit trickier. Best regards, Krzysztof
On Fri, 31 May 2024 at 18:19, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 31/05/2024 17:14, Dmitry Baryshkov wrote: > > On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote: > >> Hi, > >> > >> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where > >> applicable. Several existing bindings for these display/GPU/CAM clock > >> controllers already do it. > > > > The series looks good to me with a single point in mind. You are writing > > that dispcc/videocc/etc are a variant of GCC. However GCC is a Global > > Clock Controller. > > Yeah, that's simplification from my side and assumption that at first > they designed GCC and then they copied the design to other blocks. > > > What about renaming qcom,gcc.yaml to > > qcom,cc-common.yaml ? Then the rest makes total sense to me. > > Several gpu/disp/cam clock controllers already include qcom,gcc.yaml, so > I would say this should not be a requirement for this patchset. > > We can rename, although it always is a bit of churn - git log needs > special option, backporting is a bit trickier. Ok. For the series: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Fri, May 31, 2024 at 05:19:19PM GMT, Krzysztof Kozlowski wrote: > On 31/05/2024 17:14, Dmitry Baryshkov wrote: > > On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote: > >> Hi, > >> > >> Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where > >> applicable. Several existing bindings for these display/GPU/CAM clock > >> controllers already do it. > > > > The series looks good to me with a single point in mind. You are writing > > that dispcc/videocc/etc are a variant of GCC. However GCC is a Global > > Clock Controller. > > Yeah, that's simplification from my side and assumption that at first > they designed GCC and then they copied the design to other blocks. > That may or may not be the case, who knows... I also don't have a strong opinion about tying it all to gcc.yaml if that work... But the claim in the commit messages should the be that we inherit gcc.yaml because it's convenient, not because all clock controllers are derived from gcc. Regards, Bjorn > > What about renaming qcom,gcc.yaml to > > qcom,cc-common.yaml ? Then the rest makes total sense to me. > > Several gpu/disp/cam clock controllers already include qcom,gcc.yaml, so > I would say this should not be a requirement for this patchset. > > We can rename, although it always is a bit of churn - git log needs > special option, backporting is a bit trickier. > > > Best regards, > Krzysztof >
On Fri, May 31, 2024 at 03:52:18PM +0200, Krzysztof Kozlowski wrote: > Hi, > > Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where > applicable. Several existing bindings for these display/GPU/CAM clock > controllers already do it. > > No external dependencies, this CAN be applied independently, but require > power-domain-cells in each binding, just like Dmitry's new set is doing. > > https://lore.kernel.org/all/20240529-qcom-gdscs-v2-0-69c63d0ae1e7@linaro.org/ > > Best regards, > Krzysztof > > --- > Krzysztof Kozlowski (16): > dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,videocc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sc8280xp: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sm6350: reference qcom,gcc.yaml > dt-bindings: clock: qcom,dispcc-sm8x50: reference qcom,gcc.yaml > dt-bindings: clock: qcom,gpucc-sdm660: reference qcom,gcc.yaml > dt-bindings: clock: qcom,gpucc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,msm8998-gpucc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,qcm2290-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sc7180-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sc7280-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sdm845-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm6115-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8450-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8550-dispcc: reference qcom,gcc.yaml > dt-bindings: clock: qcom,sm8450-gpucc: reference qcom,gcc.yaml Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Hi, Unify Qualcomm clock controllers by referencing qcom,gcc.yaml where applicable. Several existing bindings for these display/GPU/CAM clock controllers already do it. No external dependencies, this CAN be applied independently, but require power-domain-cells in each binding, just like Dmitry's new set is doing. https://lore.kernel.org/all/20240529-qcom-gdscs-v2-0-69c63d0ae1e7@linaro.org/ Best regards, Krzysztof --- Krzysztof Kozlowski (16): dt-bindings: clock: qcom,sm8450-videocc: reference qcom,gcc.yaml dt-bindings: clock: qcom,videocc: reference qcom,gcc.yaml dt-bindings: clock: qcom,dispcc-sc8280xp: reference qcom,gcc.yaml dt-bindings: clock: qcom,dispcc-sm6350: reference qcom,gcc.yaml dt-bindings: clock: qcom,dispcc-sm8x50: reference qcom,gcc.yaml dt-bindings: clock: qcom,gpucc-sdm660: reference qcom,gcc.yaml dt-bindings: clock: qcom,gpucc: reference qcom,gcc.yaml dt-bindings: clock: qcom,msm8998-gpucc: reference qcom,gcc.yaml dt-bindings: clock: qcom,qcm2290-dispcc: reference qcom,gcc.yaml dt-bindings: clock: qcom,sc7180-dispcc: reference qcom,gcc.yaml dt-bindings: clock: qcom,sc7280-dispcc: reference qcom,gcc.yaml dt-bindings: clock: qcom,sdm845-dispcc: reference qcom,gcc.yaml dt-bindings: clock: qcom,sm6115-dispcc: reference qcom,gcc.yaml dt-bindings: clock: qcom,sm8450-dispcc: reference qcom,gcc.yaml dt-bindings: clock: qcom,sm8550-dispcc: reference qcom,gcc.yaml dt-bindings: clock: qcom,sm8450-gpucc: reference qcom,gcc.yaml .../bindings/clock/qcom,dispcc-sc8280xp.yaml | 20 ++++---------------- .../bindings/clock/qcom,dispcc-sm6350.yaml | 20 ++++---------------- .../bindings/clock/qcom,dispcc-sm8x50.yaml | 18 ++---------------- .../devicetree/bindings/clock/qcom,gpucc-sdm660.yaml | 20 ++++---------------- .../devicetree/bindings/clock/qcom,gpucc.yaml | 20 ++++---------------- .../bindings/clock/qcom,msm8998-gpucc.yaml | 20 ++++---------------- .../bindings/clock/qcom,qcm2290-dispcc.yaml | 20 ++++---------------- .../bindings/clock/qcom,sc7180-dispcc.yaml | 20 ++++---------------- .../bindings/clock/qcom,sc7280-dispcc.yaml | 20 ++++---------------- .../bindings/clock/qcom,sdm845-dispcc.yaml | 20 ++++---------------- .../bindings/clock/qcom,sm6115-dispcc.yaml | 20 ++++---------------- .../bindings/clock/qcom,sm8450-dispcc.yaml | 20 ++++---------------- .../devicetree/bindings/clock/qcom,sm8450-gpucc.yaml | 20 ++++---------------- .../bindings/clock/qcom,sm8450-videocc.yaml | 20 ++++---------------- .../bindings/clock/qcom,sm8550-dispcc.yaml | 20 ++++---------------- .../devicetree/bindings/clock/qcom,videocc.yaml | 19 +++---------------- 16 files changed, 61 insertions(+), 256 deletions(-) --- base-commit: b0afb900b7d235d879f8e8e4babfe77d9db76f2f change-id: 20240531-dt-bindings-qcom-gcc-e2955fd60004 Best regards,