Message ID | 20240530095408.31608-3-npiggin@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | tests/qtest/migration-test: Improve shared | expand |
Nicholas Piggin <npiggin@gmail.com> writes: > Fabiano pointed out this test probably is not flaky, just that it could > not run under Gitlab CI due to very small shm filesystem size in that > environment. > > Now that it has moved to use /tmp instead of /dev/shm files, enable it. > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> Reviewed-by: Fabiano Rosas <farosas@suse.de>
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 8bbf45313d..de380757be 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -3469,15 +3469,7 @@ int main(int argc, char **argv) test_precopy_file_offset); migration_test_add("/migration/precopy/file/offset/bad", test_precopy_file_offset_bad); - - /* - * Our CI system has problems with shared memory. - * Don't run this test until we find a workaround. - */ - if (getenv("QEMU_TEST_FLAKY_TESTS")) { - migration_test_add("/migration/mode/reboot", test_mode_reboot); - } - + migration_test_add("/migration/mode/reboot", test_mode_reboot); migration_test_add("/migration/precopy/file/mapped-ram", test_precopy_file_mapped_ram); migration_test_add("/migration/precopy/file/mapped-ram/live",
Fabiano pointed out this test probably is not flaky, just that it could not run under Gitlab CI due to very small shm filesystem size in that environment. Now that it has moved to use /tmp instead of /dev/shm files, enable it. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- tests/qtest/migration-test.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)