| Message ID | 20240601135230.89980-2-aford173@gmail.com (mailing list archive) |
|---|---|
| State | In Next, archived |
| Headers | show |
| Series | [V3,1/2] arm64: dts: imx8mp-beacon-kit: Enable ADV7535 Hot Plug Detect | expand |
On Sat, Jun 1, 2024 at 10:52 AM Adam Ford <aford173@gmail.com> wrote: > adv_bridge: hdmi@3d { > compatible = "adi,adv7535"; > - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; > - reg-names = "main", "cec", "edid", "packet"; > + reg = <0x3d>; > + reg-names = "main"; > interrupt-parent = <&gpio4>; > interrupts = <27 IRQ_TYPE_EDGE_FALLING>; > adi,dsi-lanes = <4>; > #sound-dai-cells = <0>; > + avdd-supply = <&buck5>; > + dvdd-supply = <&buck5>; > + pvdd-supply = <&buck5>; > + a2vdd-supply = <&buck5>; > + v1p2-supply = <&buck5>; > + v3p3-supply = <&buck4>; > + The extra blank line is not needed. Thanks for fixing the dt-schema warnings: Reviewed-by: Fabio Estevam <festevam@gmail.com>
On Sat, Jun 01, 2024 at 02:43:07PM -0300, Fabio Estevam wrote: > On Sat, Jun 1, 2024 at 10:52 AM Adam Ford <aford173@gmail.com> wrote: > > > adv_bridge: hdmi@3d { > > compatible = "adi,adv7535"; > > - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; > > - reg-names = "main", "cec", "edid", "packet"; > > + reg = <0x3d>; > > + reg-names = "main"; > > interrupt-parent = <&gpio4>; > > interrupts = <27 IRQ_TYPE_EDGE_FALLING>; > > adi,dsi-lanes = <4>; > > #sound-dai-cells = <0>; > > + avdd-supply = <&buck5>; > > + dvdd-supply = <&buck5>; > > + pvdd-supply = <&buck5>; > > + a2vdd-supply = <&buck5>; > > + v1p2-supply = <&buck5>; > > + v3p3-supply = <&buck4>; > > + > > The extra blank line is not needed. Fixed it up and applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts index da836172ae46..5c4b68c18bb2 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts @@ -302,12 +302,19 @@ pca6416_3: gpio@20 { adv_bridge: hdmi@3d { compatible = "adi,adv7535"; - reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>; - reg-names = "main", "cec", "edid", "packet"; + reg = <0x3d>; + reg-names = "main"; interrupt-parent = <&gpio4>; interrupts = <27 IRQ_TYPE_EDGE_FALLING>; adi,dsi-lanes = <4>; #sound-dai-cells = <0>; + avdd-supply = <&buck5>; + dvdd-supply = <&buck5>; + pvdd-supply = <&buck5>; + a2vdd-supply = <&buck5>; + v1p2-supply = <&buck5>; + v3p3-supply = <&buck4>; + ports { #address-cells = <1>;
The adv7535 has some unnecessary entries which can be removed since they were not setup properly anyway and the defaults work just fine. Removing them and adding some required regulators make the errors detected from CHECK_DTBS go away: reg-names:1: 'edid' was expected reg-names:2: 'cec' was expected 'avdd-supply' is a required property 'dvdd-supply' is a required property 'pvdd-supply' is a required property 'a2vdd-supply' is a required property 'v3p3-supply' is a required property Signed-off-by: Adam Ford <aford173@gmail.com> --- V2: No Change V3: Update commit message, no functional changes.