| Message ID | 20240530-x1e80100-dts-fix-usb-phy-supplies-v1-2-6eb72a546227@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: x1e80100: Fix the supplies to the USB1 SS[0-2] PHYs | expand |
On Thu, May 30, 2024 at 07:35:46PM +0300, Abel Vesa wrote: > The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J. > Also add the missing supplies to QMP PHYs. > > Fixes: 22b82135c02d ("arm64: dts: qcom: x1e80100-qcp: Enable more support") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On Thu, May 30, 2024 at 07:35:46PM GMT, Abel Vesa wrote: > The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J. > Also add the missing supplies to QMP PHYs. > > Fixes: 22b82135c02d ("arm64: dts: qcom: x1e80100-qcp: Enable more support") This isn't the right hash. I'm fixing this one up, but please check make sure your fixes are based on merged commits. Regards, Bjorn
On 24-06-01 17:58:19, Bjorn Andersson wrote: > On Thu, May 30, 2024 at 07:35:46PM GMT, Abel Vesa wrote: > > The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J. > > Also add the missing supplies to QMP PHYs. > > > > Fixes: 22b82135c02d ("arm64: dts: qcom: x1e80100-qcp: Enable more support") > > This isn't the right hash. I'm fixing this one up, but please check make > sure your fixes are based on merged commits. > Sorry about that. Will double check next time. Thanks for fixing it. > Regards, > Bjorn
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts index 3de7565dda19..f4b47e6b3a2f 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts @@ -537,7 +537,7 @@ &uart21 { &usb_1_ss0_hsphy { vdd-supply = <&vreg_l2e_0p8>; - vdda12-supply = <&vreg_l3e_1p2>; + vdda12-supply = <&vreg_l2j_1p2>; phys = <&smb2360_0_eusb2_repeater>; @@ -545,6 +545,9 @@ &usb_1_ss0_hsphy { }; &usb_1_ss0_qmpphy { + vdda-phy-supply = <&vreg_l3e_1p2>; + vdda-pll-supply = <&vreg_l1j_0p8>; + status = "okay"; }; @@ -558,7 +561,7 @@ &usb_1_ss0_dwc3 { &usb_1_ss1_hsphy { vdd-supply = <&vreg_l2e_0p8>; - vdda12-supply = <&vreg_l3e_1p2>; + vdda12-supply = <&vreg_l2j_1p2>; phys = <&smb2360_1_eusb2_repeater>; @@ -566,6 +569,9 @@ &usb_1_ss1_hsphy { }; &usb_1_ss1_qmpphy { + vdda-phy-supply = <&vreg_l3e_1p2>; + vdda-pll-supply = <&vreg_l2d_0p9>; + status = "okay"; }; @@ -579,7 +585,7 @@ &usb_1_ss1_dwc3 { &usb_1_ss2_hsphy { vdd-supply = <&vreg_l2e_0p8>; - vdda12-supply = <&vreg_l3e_1p2>; + vdda12-supply = <&vreg_l2j_1p2>; phys = <&smb2360_2_eusb2_repeater>; @@ -587,6 +593,9 @@ &usb_1_ss2_hsphy { }; &usb_1_ss2_qmpphy { + vdda-phy-supply = <&vreg_l3e_1p2>; + vdda-pll-supply = <&vreg_l2d_0p9>; + status = "okay"; };
The 1.2v HS PHY shared regulator is actually LDO2 from PM8550ve id J. Also add the missing supplies to QMP PHYs. Fixes: 22b82135c02d ("arm64: dts: qcom: x1e80100-qcp: Enable more support") Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)