| Message ID | SN7PR12MB81019093E9E5D29BEC4B821FA4F22@SN7PR12MB8101.namprd12.prod.outlook.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iio-proximity-hx9023s-Add-TYHX-HX9023S-sensor-driver | expand |
On 29/05/2024 06:57, Yasin Lee wrote: > From: Yasin Lee <yasin.lee.x@gmail.com> > > v3: > - Renamed the files to keep the file names consistent with the chip name. > - Removed custom bit operation macro definitions. > - Deleted redundant documentation that duplicated the Standard ABI. > - Deleted unused header files. > - Deleted unused register definitions. > - Changed parts of the code related to circuit design to be configurable through DTS. > - Removed unnecessary print statements. > - Fixed the error in hx9031as_write_event_val. > - Removed unnecessary threshold settings in the probe. > - Replaced enable_irq(data->client->irq) with interrupt enable register operations. > - Fixed style issues. Please do not ignore comments but respond to them. Go back to 15th of May and acknowledge all of them. You repeated every single issue... Best regards, Krzysztof
On Wed, 29 May 2024 12:57:47 +0800 Yasin Lee <yasin.lee.x@outlook.com> wrote: > From: Yasin Lee <yasin.lee.x@gmail.com> > Hi Yasin, Don't send a new version in reply to an old one. Given how many revisions some kernel patches go through, it becomes impossible to follow some threads where this is done. On a more practical basis it ends up off the top of my screen in my email client so I may miss your series entirely. Patchwork was tracking it so I noticed this time. Jonathan > v3: > - Renamed the files to keep the file names consistent with the chip name. > - Removed custom bit operation macro definitions. > - Deleted redundant documentation that duplicated the Standard ABI. > - Deleted unused header files. > - Deleted unused register definitions. > - Changed parts of the code related to circuit design to be configurable through DTS. > - Removed unnecessary print statements. > - Fixed the error in hx9031as_write_event_val. > - Removed unnecessary threshold settings in the probe. > - Replaced enable_irq(data->client->irq) with interrupt enable register operations. > - Fixed style issues. > > v2: > - Deleted the global data structures, replacing them with dynamic allocation. > - Delete debugfs. > - Fixed styles issues. > > Yasin Lee (2): > dt-bindings:iio:proximity: Add hx9023s binding > iio:proximity:hx9023s: Add TYHX HX9023S sensor driver > > .../bindings/iio/proximity/tyhx,hx9023s.yaml | 106 ++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > drivers/iio/proximity/Kconfig | 14 + > drivers/iio/proximity/Makefile | 2 +- > drivers/iio/proximity/hx9023s.c | 1428 +++++++++++++++++ > 5 files changed, 1551 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml > create mode 100644 drivers/iio/proximity/hx9023s.c >
On 31/05/2024 09:52, Krzysztof Kozlowski wrote: > On 29/05/2024 06:57, Yasin Lee wrote: >> From: Yasin Lee <yasin.lee.x@gmail.com> >> >> v3: >> - Renamed the files to keep the file names consistent with the chip name. >> - Removed custom bit operation macro definitions. >> - Deleted redundant documentation that duplicated the Standard ABI. >> - Deleted unused header files. >> - Deleted unused register definitions. >> - Changed parts of the code related to circuit design to be configurable through DTS. >> - Removed unnecessary print statements. >> - Fixed the error in hx9031as_write_event_val. >> - Removed unnecessary threshold settings in the probe. >> - Replaced enable_irq(data->client->irq) with interrupt enable register operations. >> - Fixed style issues. > > Please do not ignore comments but respond to them. Go back to 15th of > May and acknowledge all of them. You repeated every single issue... Where did you responded to this? Best regards, Krzysztof
From: Yasin Lee <yasin.lee.x@gmail.com> v3: - Renamed the files to keep the file names consistent with the chip name. - Removed custom bit operation macro definitions. - Deleted redundant documentation that duplicated the Standard ABI. - Deleted unused header files. - Deleted unused register definitions. - Changed parts of the code related to circuit design to be configurable through DTS. - Removed unnecessary print statements. - Fixed the error in hx9031as_write_event_val. - Removed unnecessary threshold settings in the probe. - Replaced enable_irq(data->client->irq) with interrupt enable register operations. - Fixed style issues. v2: - Deleted the global data structures, replacing them with dynamic allocation. - Delete debugfs. - Fixed styles issues. Yasin Lee (2): dt-bindings:iio:proximity: Add hx9023s binding iio:proximity:hx9023s: Add TYHX HX9023S sensor driver .../bindings/iio/proximity/tyhx,hx9023s.yaml | 106 ++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/iio/proximity/Kconfig | 14 + drivers/iio/proximity/Makefile | 2 +- drivers/iio/proximity/hx9023s.c | 1428 +++++++++++++++++ 5 files changed, 1551 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml create mode 100644 drivers/iio/proximity/hx9023s.c