| Message ID | 20240531085402.1838-1-chenhx.fnst@fujitsu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cdbdb3c62af5bc13e6e8a9310470c71c33340d26 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: bridge: fix an inconsistent indentation | expand |
On 5/31/24 11:54, Chen Hanxiao wrote: > Smatch complains: > net/bridge/br_netlink_tunnel.c: > 318 br_process_vlan_tunnel_info() warn: inconsistent indenting > > Fix it with a proper indenting > > Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com> > --- > v2: > add net-next tag > modify subject > > net/bridge/br_netlink_tunnel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c > index 17abf092f7ca..71a12da30004 100644 > --- a/net/bridge/br_netlink_tunnel.c > +++ b/net/bridge/br_netlink_tunnel.c > @@ -315,8 +315,8 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br, > > if (curr_change) > *changed = curr_change; > - __vlan_tunnel_handle_range(p, &v_start, &v_end, v, > - curr_change); > + __vlan_tunnel_handle_range(p, &v_start, &v_end, v, > + curr_change); > } > if (v_start && v_end) > br_vlan_notify(br, p, v_start->vid, v_end->vid, Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
On Fri, 2024-05-31 at 16:54 +0800, Chen Hanxiao wrote: > Smatch complains: > net/bridge/br_netlink_tunnel.c: > 318 br_process_vlan_tunnel_info() warn: inconsistent indenting > > Fix it with a proper indenting > > Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com> My take is that purely format changes should be part of larger/features-based change, to avoid any later stable fix harder for no real reason. Thanks, Paolo
On June 4, 2024 4:57:12 PM GMT+03:00, Paolo Abeni <pabeni@redhat.com> wrote: >On Fri, 2024-05-31 at 16:54 +0800, Chen Hanxiao wrote: >> Smatch complains: >> net/bridge/br_netlink_tunnel.c: >> 318 br_process_vlan_tunnel_info() warn: inconsistent indenting >> >> Fix it with a proper indenting >> >> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com> > >My take is that purely format changes should be part of >larger/features-based change, to avoid any later stable fix harder for >no real reason. > >Thanks, > >Paolo > This is new, I don't see anything wrong with fixing bad indentation. Waiting for a set which touches this code which hasn't changed for a long time ib order to fix it is doesn't sound good to me. It is very trivial to resolve for anyone. Cheers, Nik
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 31 May 2024 16:54:02 +0800 you wrote: > Smatch complains: > net/bridge/br_netlink_tunnel.c: > 318 br_process_vlan_tunnel_info() warn: inconsistent indenting > > Fix it with a proper indenting > > Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com> > > [...] Here is the summary with links: - [net-next] net: bridge: fix an inconsistent indentation https://git.kernel.org/netdev/net-next/c/cdbdb3c62af5 You are awesome, thank you!
diff --git a/net/bridge/br_netlink_tunnel.c b/net/bridge/br_netlink_tunnel.c index 17abf092f7ca..71a12da30004 100644 --- a/net/bridge/br_netlink_tunnel.c +++ b/net/bridge/br_netlink_tunnel.c @@ -315,8 +315,8 @@ int br_process_vlan_tunnel_info(const struct net_bridge *br, if (curr_change) *changed = curr_change; - __vlan_tunnel_handle_range(p, &v_start, &v_end, v, - curr_change); + __vlan_tunnel_handle_range(p, &v_start, &v_end, v, + curr_change); } if (v_start && v_end) br_vlan_notify(br, p, v_start->vid, v_end->vid,
Smatch complains: net/bridge/br_netlink_tunnel.c: 318 br_process_vlan_tunnel_info() warn: inconsistent indenting Fix it with a proper indenting Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com> --- v2: add net-next tag modify subject net/bridge/br_netlink_tunnel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)