Bluetooth: iso: remove unused struct 'iso_list_data'

Commit Message

Dr. David Alan Gilbert May 31, 2024, 11:26 p.m. UTC

From: "Dr. David Alan Gilbert" <[e-mail]>

'iso_list_data' has been unused since the original
commit ccf74f2390d6 ("Bluetooth: Add BTPROTO_ISO socket type").

Remove it.

Signed-off-by: Dr. David Alan Gilbert <[e-mail]>
---
 net/bluetooth/iso.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

[e-mail] May 31, 2024, 11:56 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=857869

---Test result---

Test Summary:
CheckPatch                    PASS      0.47 seconds
GitLint                       PASS      0.20 seconds
SubjectPrefix                 PASS      0.07 seconds
BuildKernel                   PASS      29.53 seconds
CheckAllWarning               PASS      32.27 seconds
CheckSparse                   PASS      37.81 seconds
CheckSmatch                   FAIL      34.51 seconds
BuildKernel32                 PASS      29.74 seconds
TestRunnerSetup               PASS      515.75 seconds
TestRunner_l2cap-tester       PASS      20.27 seconds
TestRunner_iso-tester         FAIL      34.58 seconds
TestRunner_bnep-tester        PASS      4.72 seconds
TestRunner_mgmt-tester        PASS      110.94 seconds
TestRunner_rfcomm-tester      PASS      7.30 seconds
TestRunner_sco-tester         PASS      14.90 seconds
TestRunner_ioctl-tester       PASS      7.69 seconds
TestRunner_mesh-tester        PASS      5.83 seconds
TestRunner_smp-tester         PASS      7.20 seconds
TestRunner_userchan-tester    PASS      4.92 seconds
IncrementalBuild              PASS      28.08 seconds

Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 116 (95.1%), Failed: 2, Not Run: 4

Failed Test Cases
ISO Connect Suspend - Success                        Failed       4.169 seconds
ISO Connect2 Suspend - Success                       Failed       6.225 seconds


---
Regards,
Linux Bluetooth

[e-mail] June 3, 2024, 1 p.m. UTC | #2

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Sat,  1 Jun 2024 00:26:14 +0100 you wrote:
> From: "Dr. David Alan Gilbert" <[e-mail]>
> 
> 'iso_list_data' has been unused since the original
> commit ccf74f2390d6 ("Bluetooth: Add BTPROTO_ISO socket type").
> 
> Remove it.
> 
> [...]

Here is the summary with links:
  - Bluetooth: iso: remove unused struct 'iso_list_data'
    https://git.kernel.org/bluetooth/bluetooth-next/c/d8b6a4e3ad78

You are awesome, thank you!

Patch

diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index cc055b952ce6..e439c5d15092 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -1721,11 +1721,6 @@  static void iso_sock_ready(struct sock *sk)
 	release_sock(sk);
 }
 
-struct iso_list_data {
-	struct hci_conn *hcon;
-	int count;
-};
-
 static bool iso_match_big(struct sock *sk, void *data)
 {
 	struct hci_evt_le_big_sync_estabilished *ev = data;