| Message ID | 20240517232617.230767-1-linux@treblig.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/6] drm/bridge: analogix: remove unused struct 'bridge_init' | expand |
* linux@treblig.org (linux@treblig.org) wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > 'init_exec' is unused since > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new > init table parser") > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Ping. > --- > drivers/gpu/drm/nouveau/nouveau_bios.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c > index 79cfab53f80e..8c3c1f1e01c5 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bios.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c > @@ -43,11 +43,6 @@ > #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg) > #define LOG_OLD_VALUE(x) > > -struct init_exec { > - bool execute; > - bool repeat; > -}; > - > static bool nv_cksum(const uint8_t *data, unsigned int length) > { > /* > -- > 2.45.1 >
On 5/18/24 01:26, linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > 'init_exec' is unused since > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new > init table parser") > Remove it. > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Acked-by: Danilo Krummrich <dakr@redhat.com> To which series does this patch belong? Need me to apply it? - Danilo > --- > drivers/gpu/drm/nouveau/nouveau_bios.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c > index 79cfab53f80e..8c3c1f1e01c5 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bios.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c > @@ -43,11 +43,6 @@ > #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg) > #define LOG_OLD_VALUE(x) > > -struct init_exec { > - bool execute; > - bool repeat; > -}; > - > static bool nv_cksum(const uint8_t *data, unsigned int length) > { > /*
* Danilo Krummrich (dakr@redhat.com) wrote: > On 5/18/24 01:26, linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > 'init_exec' is unused since > > commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new > > init table parser") > > Remove it. > > > > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> > > Acked-by: Danilo Krummrich <dakr@redhat.com> > > To which series does this patch belong? Actually all of them were independent patches on drm some of which are all in, so it can be taken by itself. > Need me to apply it? Yes please! Thanks, Dave > - Danilo > > > --- > > drivers/gpu/drm/nouveau/nouveau_bios.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c > > index 79cfab53f80e..8c3c1f1e01c5 100644 > > --- a/drivers/gpu/drm/nouveau/nouveau_bios.c > > +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c > > @@ -43,11 +43,6 @@ > > #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg) > > #define LOG_OLD_VALUE(x) > > -struct init_exec { > > - bool execute; > > - bool repeat; > > -}; > > - > > static bool nv_cksum(const uint8_t *data, unsigned int length) > > { > > /* >
On 6/11/24 12:37, Dr. David Alan Gilbert wrote: > * Danilo Krummrich (dakr@redhat.com) wrote: >> On 5/18/24 01:26, linux@treblig.org wrote: >>> From: "Dr. David Alan Gilbert" <linux@treblig.org> >>> >>> 'init_exec' is unused since >>> commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new >>> init table parser") >>> Remove it. >>> >>> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> >> >> Acked-by: Danilo Krummrich <dakr@redhat.com> >> >> To which series does this patch belong? > > Actually all of them were independent patches on drm > some of which are all in, so it can be taken by itself. > >> Need me to apply it? > > Yes please! Applied to drm-misc-fixes, thanks! > > Thanks, > > Dave > >> - Danilo >> >>> --- >>> drivers/gpu/drm/nouveau/nouveau_bios.c | 5 ----- >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c >>> index 79cfab53f80e..8c3c1f1e01c5 100644 >>> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c >>> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c >>> @@ -43,11 +43,6 @@ >>> #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg) >>> #define LOG_OLD_VALUE(x) >>> -struct init_exec { >>> - bool execute; >>> - bool repeat; >>> -}; >>> - >>> static bool nv_cksum(const uint8_t *data, unsigned int length) >>> { >>> /* >>
diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c index 79cfab53f80e..8c3c1f1e01c5 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bios.c +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c @@ -43,11 +43,6 @@ #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg) #define LOG_OLD_VALUE(x) -struct init_exec { - bool execute; - bool repeat; -}; - static bool nv_cksum(const uint8_t *data, unsigned int length) { /*