| Message ID | 20240603092757.71902-11-christophe.roullier@foss.st.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Series to deliver Ethernet for STM32MP13 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On 6/3/24 11:27 AM, Christophe Roullier wrote: > Ethernet1: RMII with crystal > PHY used is SMSC (LAN8742A) > > Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> > --- > arch/arm/boot/dts/st/stm32mp135f-dk.dts | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts b/arch/arm/boot/dts/st/stm32mp135f-dk.dts > index 567e53ad285fa..cebe9b91eced9 100644 > --- a/arch/arm/boot/dts/st/stm32mp135f-dk.dts > +++ b/arch/arm/boot/dts/st/stm32mp135f-dk.dts > @@ -19,6 +19,7 @@ / { > compatible = "st,stm32mp135f-dk", "st,stm32mp135"; > > aliases { > + ethernet0 = ðernet1; > serial0 = &uart4; > serial1 = &usart1; > serial2 = &uart8; > @@ -141,6 +142,29 @@ &cryp { > status = "okay"; > }; > > +ðernet1 { > + status = "okay"; > + pinctrl-0 = <ð1_rmii_pins_a>; > + pinctrl-1 = <ð1_rmii_sleep_pins_a>; > + pinctrl-names = "default", "sleep"; > + phy-mode = "rmii"; > + max-speed = <100>; Is this needed ? RMII cannot go faster than 100 . Also, keep the list sorted alphabetically , P goes after M . > + phy-handle = <&phy0_eth1>; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + > + phy0_eth1: ethernet-phy@0 { > + compatible = "ethernet-phy-id0007.c131"; > + reset-gpios = <&mcp23017 9 GPIO_ACTIVE_LOW>; Extra space between = and < , please drop.
On 6/3/24 15:08, Marek Vasut wrote: > On 6/3/24 11:27 AM, Christophe Roullier wrote: >> Ethernet1: RMII with crystal >> PHY used is SMSC (LAN8742A) >> >> Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> >> --- >> arch/arm/boot/dts/st/stm32mp135f-dk.dts | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts >> b/arch/arm/boot/dts/st/stm32mp135f-dk.dts >> index 567e53ad285fa..cebe9b91eced9 100644 >> --- a/arch/arm/boot/dts/st/stm32mp135f-dk.dts >> +++ b/arch/arm/boot/dts/st/stm32mp135f-dk.dts >> @@ -19,6 +19,7 @@ / { >> compatible = "st,stm32mp135f-dk", "st,stm32mp135"; >> aliases { >> + ethernet0 = ðernet1; >> serial0 = &uart4; >> serial1 = &usart1; >> serial2 = &uart8; >> @@ -141,6 +142,29 @@ &cryp { >> status = "okay"; >> }; >> +ðernet1 { >> + status = "okay"; >> + pinctrl-0 = <ð1_rmii_pins_a>; >> + pinctrl-1 = <ð1_rmii_sleep_pins_a>; >> + pinctrl-names = "default", "sleep"; >> + phy-mode = "rmii"; >> + max-speed = <100>; > > Is this needed ? RMII cannot go faster than 100 . > ok (I will put in v4) > Also, keep the list sorted alphabetically , P goes after M . ok (I will put in v4) > >> + phy-handle = <&phy0_eth1>; >> + >> + mdio { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "snps,dwmac-mdio"; >> + >> + phy0_eth1: ethernet-phy@0 { >> + compatible = "ethernet-phy-id0007.c131"; >> + reset-gpios = <&mcp23017 9 GPIO_ACTIVE_LOW>; > > Extra space between = and < , please drop. ok (I will put in v4)
diff --git a/arch/arm/boot/dts/st/stm32mp135f-dk.dts b/arch/arm/boot/dts/st/stm32mp135f-dk.dts index 567e53ad285fa..cebe9b91eced9 100644 --- a/arch/arm/boot/dts/st/stm32mp135f-dk.dts +++ b/arch/arm/boot/dts/st/stm32mp135f-dk.dts @@ -19,6 +19,7 @@ / { compatible = "st,stm32mp135f-dk", "st,stm32mp135"; aliases { + ethernet0 = ðernet1; serial0 = &uart4; serial1 = &usart1; serial2 = &uart8; @@ -141,6 +142,29 @@ &cryp { status = "okay"; }; +ðernet1 { + status = "okay"; + pinctrl-0 = <ð1_rmii_pins_a>; + pinctrl-1 = <ð1_rmii_sleep_pins_a>; + pinctrl-names = "default", "sleep"; + phy-mode = "rmii"; + max-speed = <100>; + phy-handle = <&phy0_eth1>; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + compatible = "snps,dwmac-mdio"; + + phy0_eth1: ethernet-phy@0 { + compatible = "ethernet-phy-id0007.c131"; + reset-gpios = <&mcp23017 9 GPIO_ACTIVE_LOW>; + reg = <0>; + wakeup-source; + }; + }; +}; + &i2c1 { pinctrl-names = "default", "sleep"; pinctrl-0 = <&i2c1_pins_a>;
Ethernet1: RMII with crystal PHY used is SMSC (LAN8742A) Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> --- arch/arm/boot/dts/st/stm32mp135f-dk.dts | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)