[net-next,0/3] tcp: refactor skb_cmp_decrypted() checks

Message

Jakub Kicinski May 30, 2024, 11:36 p.m. UTC

Refactor the input patch coalescing checks and wrap "EOR forcing"
logic into a helper. This will hopefully make the code easier to
follow. While at it throw some DEBUG_NET checks into skb_shift().

Jakub Kicinski (3):
  tcp: wrap mptcp and decrypted checks into tcp_skb_can_collapse_rx()
  tcp: add a helper for setting EOR on tail skb
  net: skb: add compatibility warnings to skb_shift()

 include/net/tcp.h    | 16 ++++++++++++++++
 net/core/skbuff.c    |  3 +++
 net/ipv4/tcp_input.c | 11 +++--------
 net/ipv4/tcp_ipv4.c  |  3 +--
 net/tls/tls_device.c | 11 ++---------
 5 files changed, 25 insertions(+), 19 deletions(-)

Comments

MPTCP CI May 31, 2024, 12:28 a.m. UTC | #1

Hi Jakub,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/9310667506

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/9ff802fa78d3
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=857501


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

[e-mail] June 4, 2024, 11:30 a.m. UTC | #2

Hello:

This series was applied to netdev/net-next.git (main)
by Paolo Abeni <[e-mail]>:

On Thu, 30 May 2024 16:36:13 -0700 you wrote:
> Refactor the input patch coalescing checks and wrap "EOR forcing"
> logic into a helper. This will hopefully make the code easier to
> follow. While at it throw some DEBUG_NET checks into skb_shift().
> 
> Jakub Kicinski (3):
>   tcp: wrap mptcp and decrypted checks into tcp_skb_can_collapse_rx()
>   tcp: add a helper for setting EOR on tail skb
>   net: skb: add compatibility warnings to skb_shift()
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] tcp: wrap mptcp and decrypted checks into tcp_skb_can_collapse_rx()
    https://git.kernel.org/netdev/net-next/c/071115301838
  - [net-next,2/3] tcp: add a helper for setting EOR on tail skb
    https://git.kernel.org/netdev/net-next/c/1be68a87ab33
  - [net-next,3/3] net: skb: add compatibility warnings to skb_shift()
    https://git.kernel.org/netdev/net-next/c/99b8add01f98

You are awesome, thank you!