| Message ID | 20240604120555.16643-1-karol.kolacinski@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 323a359f9b077f382f4483023d096a4d316fd135 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] ptp: Fix error message on failed pin verification | expand |
On Tue, Jun 04, 2024 at 02:05:27PM +0200, Karol Kolacinski wrote: > On failed verification of PTP clock pin, error message prints channel > number instead of pin index after "pin", which is incorrect. > > Fix error message by adding channel number to the message and printing > pin number instead of channel number. > > Fixes: 6092315dfdec ("ptp: introduce programmable pins.") > Cc: Richard Cochran <richardcochran@gmail.com> > Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com> Nice find! Acked-by: Richard Cochran <richardcochran@gmail.com>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 4 Jun 2024 14:05:27 +0200 you wrote: > On failed verification of PTP clock pin, error message prints channel > number instead of pin index after "pin", which is incorrect. > > Fix error message by adding channel number to the message and printing > pin number instead of channel number. > > Fixes: 6092315dfdec ("ptp: introduce programmable pins.") > Cc: Richard Cochran <richardcochran@gmail.com> > Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com> > > [...] Here is the summary with links: - [net] ptp: Fix error message on failed pin verification https://git.kernel.org/netdev/net/c/323a359f9b07 You are awesome, thank you!
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c index 7513018c9f9a..2067b0120d08 100644 --- a/drivers/ptp/ptp_chardev.c +++ b/drivers/ptp/ptp_chardev.c @@ -85,7 +85,8 @@ int ptp_set_pinfunc(struct ptp_clock *ptp, unsigned int pin, } if (info->verify(info, pin, func, chan)) { - pr_err("driver cannot use function %u on pin %u\n", func, chan); + pr_err("driver cannot use function %u and channel %u on pin %u\n", + func, chan, pin); return -EOPNOTSUPP; }
On failed verification of PTP clock pin, error message prints channel number instead of pin index after "pin", which is incorrect. Fix error message by adding channel number to the message and printing pin number instead of channel number. Fixes: 6092315dfdec ("ptp: introduce programmable pins.") Cc: Richard Cochran <richardcochran@gmail.com> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com> --- drivers/ptp/ptp_chardev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) base-commit: 2ab79514109578fc4b6df90633d500cf281eb689