| Message ID | 20240604221327.299184-2-jesse.brandeburg@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ice: add standard stats | expand |
On Tue, 04 Jun, 2024 15:13:21 -0700 Jesse Brandeburg <jesse.brandeburg@intel.com> wrote: > While trying to figure out ethtool -I | --include-statistics, I noticed > some docs got missed when implementing commit 0e9c127729be ("ethtool: > add interface to read Tx hardware timestamping statistics"). > > Fix up the docs to match the kernel code, and while there, sort them in > alphabetical order. > > Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com> > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > I didn't add a Fixes: tag because this is not an urgent kind of fix that > should require backports. > --- > Documentation/networking/statistics.rst | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/networking/statistics.rst b/Documentation/networking/statistics.rst > index 75e017dfa825..22503a90e369 100644 > --- a/Documentation/networking/statistics.rst > +++ b/Documentation/networking/statistics.rst > @@ -184,9 +184,11 @@ Protocol-related statistics can be requested in get commands by setting > the `ETHTOOL_FLAG_STATS` flag in `ETHTOOL_A_HEADER_FLAGS`. Currently > statistics are supported in the following commands: > > - - `ETHTOOL_MSG_PAUSE_GET` > - `ETHTOOL_MSG_FEC_GET` > + - 'ETHTOOL_MSG_LINKSTATE_GET' > - `ETHTOOL_MSG_MM_GET` > + - `ETHTOOL_MSG_PAUSE_GET` > + - 'ETHTOOL_MSG_TSINFO_GET' > > debugfs > ------- Thanks for catching this. Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
On Tue, 4 Jun 2024 15:13:21 -0700 Jesse Brandeburg wrote: > - - `ETHTOOL_MSG_PAUSE_GET` > - `ETHTOOL_MSG_FEC_GET` > + - 'ETHTOOL_MSG_LINKSTATE_GET' > - `ETHTOOL_MSG_MM_GET` > + - `ETHTOOL_MSG_PAUSE_GET` > + - 'ETHTOOL_MSG_TSINFO_GET' I was going to steal this directly but: ` vs ' so I'll let it go via the Intel tree :)
On 6/5/2024 5:48 PM, Jakub Kicinski wrote: > On Tue, 4 Jun 2024 15:13:21 -0700 Jesse Brandeburg wrote: >> - - `ETHTOOL_MSG_PAUSE_GET` >> - `ETHTOOL_MSG_FEC_GET` >> + - 'ETHTOOL_MSG_LINKSTATE_GET' >> - `ETHTOOL_MSG_MM_GET` >> + - `ETHTOOL_MSG_PAUSE_GET` >> + - 'ETHTOOL_MSG_TSINFO_GET' > > I was going to steal this directly but: > ` vs ' > so I'll let it go via the Intel tree :) > Thank you Jakub, I had to stare really deeply at that comment to understand "backtick vs single-quote" as for the longest time I couldn't understand why you were quoting the word "vs" - sheesh :-) I didn't even know/remember the docs required backticks vs some other quote looking thing, it never even occurred to me, so thanks for calling that out. I'll send a v2 with the fix so Jake can pick it up while Tony is out. -Jesse
On 6/5/2024 5:48 PM, Jakub Kicinski wrote: > On Tue, 4 Jun 2024 15:13:21 -0700 Jesse Brandeburg wrote: >> - - `ETHTOOL_MSG_PAUSE_GET` >> - `ETHTOOL_MSG_FEC_GET` >> + - 'ETHTOOL_MSG_LINKSTATE_GET' >> - `ETHTOOL_MSG_MM_GET` >> + - `ETHTOOL_MSG_PAUSE_GET` >> + - 'ETHTOOL_MSG_TSINFO_GET' > > I was going to steal this directly but: > ` vs ' > so I'll let it go via the Intel tree :) Yea, this needs to be consistently ` here for rST formatting to match.
diff --git a/Documentation/networking/statistics.rst b/Documentation/networking/statistics.rst index 75e017dfa825..22503a90e369 100644 --- a/Documentation/networking/statistics.rst +++ b/Documentation/networking/statistics.rst @@ -184,9 +184,11 @@ Protocol-related statistics can be requested in get commands by setting the `ETHTOOL_FLAG_STATS` flag in `ETHTOOL_A_HEADER_FLAGS`. Currently statistics are supported in the following commands: - - `ETHTOOL_MSG_PAUSE_GET` - `ETHTOOL_MSG_FEC_GET` + - 'ETHTOOL_MSG_LINKSTATE_GET' - `ETHTOOL_MSG_MM_GET` + - `ETHTOOL_MSG_PAUSE_GET` + - 'ETHTOOL_MSG_TSINFO_GET' debugfs -------
While trying to figure out ethtool -I | --include-statistics, I noticed some docs got missed when implementing commit 0e9c127729be ("ethtool: add interface to read Tx hardware timestamping statistics"). Fix up the docs to match the kernel code, and while there, sort them in alphabetical order. Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- I didn't add a Fixes: tag because this is not an urgent kind of fix that should require backports. --- Documentation/networking/statistics.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)