diff mbox series

[1/2] bindings: frequency: adf4350: add clk provider

Message ID 20240603112447.23308-1-antoniu.miclaus@analog.com (mailing list archive)
State Superseded
Headers show
Series [1/2] bindings: frequency: adf4350: add clk provider | expand

Commit Message

Antoniu Miclaus June 3, 2024, 11:24 a.m. UTC
Update dt-bindings for clock provider support within adf4350 driver.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 .../devicetree/bindings/iio/frequency/adi,adf4350.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Conor Dooley June 4, 2024, 5:08 p.m. UTC | #1
On Mon, Jun 03, 2024 at 02:24:43PM +0300, Antoniu Miclaus wrote:
> Update dt-bindings for clock provider support within adf4350 driver.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Krzysztof Kozlowski June 5, 2024, 7:09 a.m. UTC | #2
On 03/06/2024 13:24, Antoniu Miclaus wrote:
> Update dt-bindings for clock provider support within adf4350 driver.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Hint: it is not bindings

Commit msg: explain the hardware, not drivers.

> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
>  .../devicetree/bindings/iio/frequency/adi,adf4350.yaml      | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,adf4350.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,adf4350.yaml
index 43cbf27114c7..d1d1311332f8 100644
--- a/Documentation/devicetree/bindings/iio/frequency/adi,adf4350.yaml
+++ b/Documentation/devicetree/bindings/iio/frequency/adi,adf4350.yaml
@@ -28,6 +28,12 @@  properties:
   clock-names:
     const: clkin
 
+  '#clock-cells':
+    const: 0
+
+  clock-output-names:
+    maxItems: 1
+
   gpios:
     maxItems: 1
     description: Lock detect GPIO.